[INFO] cloning repository https://github.com/coralogix/protofetch [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/coralogix/protofetch" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoralogix%2Fprotofetch", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoralogix%2Fprotofetch'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8531549b768173c5b89dd1f92f9b342de79f00ef [INFO] checking coralogix/protofetch/8531549b768173c5b89dd1f92f9b342de79f00ef against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoralogix%2Fprotofetch" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/coralogix/protofetch on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/.cargo/config.toml [INFO] removed /workspace/builds/worker-3-tc2/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/coralogix/protofetch [INFO] finished tweaking git repo https://github.com/coralogix/protofetch [INFO] tweaked toml for git repo https://github.com/coralogix/protofetch written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/coralogix/protofetch already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5ef7869ffb723651535216c9be5a5ac5ba589fbd8e1f739ba6fa5e01a0775c6b [INFO] running `Command { std: "docker" "start" "-a" "5ef7869ffb723651535216c9be5a5ac5ba589fbd8e1f739ba6fa5e01a0775c6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5ef7869ffb723651535216c9be5a5ac5ba589fbd8e1f739ba6fa5e01a0775c6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ef7869ffb723651535216c9be5a5ac5ba589fbd8e1f739ba6fa5e01a0775c6b", kill_on_drop: false }` [INFO] [stdout] 5ef7869ffb723651535216c9be5a5ac5ba589fbd8e1f739ba6fa5e01a0775c6b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 285f728a101a15e0652bc98fc5d65d36a17dec5da850e663597c7bd78ed90b9b [INFO] running `Command { std: "docker" "start" "-a" "285f728a101a15e0652bc98fc5d65d36a17dec5da850e663597c7bd78ed90b9b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling thiserror v1.0.62 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Checking project-root v0.2.2 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling cc v1.1.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling libz-sys v1.1.18 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking fs4 v0.9.1 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Checking ssh-key v0.6.6 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.62 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_edit v0.22.15 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking config v0.14.0 [INFO] [stderr] Checking protofetch v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/builder.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 76 | let git_config = git2::Config::open_default()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | let cache = ProtofetchGitCache::new(cache_directory, git_config, config.default_protocol)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | [INFO] [stdout] 80 | Ok(Protofetch { [INFO] [stdout] | ____________^ [INFO] [stdout] 81 | | cache, [INFO] [stdout] 82 | | root, [INFO] [stdout] 83 | | module_file_name, [INFO] [stdout] 84 | | lock_file_name, [INFO] [stdout] 85 | | output_directory_name, [INFO] [stdout] 86 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/command_handlers.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 184 | let module_descriptor = Descriptor::from_file(&root.join(module_file_name)).or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | ProtodepDescriptor::from_file(&root.join("protodep.toml")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 55 | config_override: Option, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut builder = Config::builder(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | / builder [INFO] [stdout] 74 | | .add_source( [INFO] [stdout] 75 | | Environment::with_prefix("PROTOFETCH") [INFO] [stdout] 76 | | .separator("_") [INFO] [stdout] 77 | | .source(env_override), [INFO] [stdout] 78 | | ) [INFO] [stdout] 79 | | .build()? [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/cache.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 43 | git_config: Config, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let lock = Self::acquire_lock(&location)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(ProtofetchGitCache { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | location, [INFO] [stdout] 61 | | worktrees, [INFO] [stdout] 62 | | git_config, [INFO] [stdout] 63 | | default_protocol, [INFO] [stdout] 64 | | _lock: lock, [INFO] [stdout] 65 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/cache.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 85 | let repo = if path.exists() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok(ProtoGitRepository::new(self, repo, url)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/mod.rs:543:18 [INFO] [stdout] | [INFO] [stdout] 543 | .map(|v| v.clone().try_into::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/mod.rs:549:23 [INFO] [stdout] | [INFO] [stdout] 549 | .and_then(|x| x.clone().try_into::().map_err(|e| e.into())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/mod.rs:561:18 [INFO] [stdout] | [INFO] [stdout] 561 | .map(|v| v.clone().try_into::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/mod.rs:567:18 [INFO] [stdout] | [INFO] [stdout] 567 | .map(|v| v.clone().try_into::>()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/mod.rs:576:18 [INFO] [stdout] | [INFO] [stdout] 576 | .map(|v| v.clone().try_into::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/mod.rs:601:18 [INFO] [stdout] | [INFO] [stdout] 601 | .map(|v| v.clone().try_into::>()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/lock.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 29 | let mut table = toml::from_str::(s)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | match table.remove("version") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto.rs:212:8 [INFO] [stdout] | [INFO] [stdout] 171 | let mut found_proto_deps: HashSet = HashSet::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | let mut visited: HashSet = HashSet::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let mut visited_dep: HashSet = HashSet::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | Ok(found_proto_deps [INFO] [stdout] | ________^ [INFO] [stdout] 213 | | .into_iter() [INFO] [stdout] 214 | | .map(|p| ProtoFileMapping { [INFO] [stdout] 215 | | from: p.full_path, [INFO] [stdout] 216 | | to: p.package_path, [INFO] [stdout] 217 | | }) [INFO] [stdout] 218 | | .collect()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/builder.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 76 | let git_config = git2::Config::open_default()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | let cache = ProtofetchGitCache::new(cache_directory, git_config, config.default_protocol)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | [INFO] [stdout] 80 | Ok(Protofetch { [INFO] [stdout] | ____________^ [INFO] [stdout] 81 | | cache, [INFO] [stdout] 82 | | root, [INFO] [stdout] 83 | | module_file_name, [INFO] [stdout] 84 | | lock_file_name, [INFO] [stdout] 85 | | output_directory_name, [INFO] [stdout] 86 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/command_handlers.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 184 | let module_descriptor = Descriptor::from_file(&root.join(module_file_name)).or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | ProtodepDescriptor::from_file(&root.join("protodep.toml")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 55 | config_override: Option, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut builder = Config::builder(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | / builder [INFO] [stdout] 74 | | .add_source( [INFO] [stdout] 75 | | Environment::with_prefix("PROTOFETCH") [INFO] [stdout] 76 | | .separator("_") [INFO] [stdout] 77 | | .source(env_override), [INFO] [stdout] 78 | | ) [INFO] [stdout] 79 | | .build()? [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/cache.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 43 | git_config: Config, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let lock = Self::acquire_lock(&location)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(ProtofetchGitCache { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | location, [INFO] [stdout] 61 | | worktrees, [INFO] [stdout] 62 | | git_config, [INFO] [stdout] 63 | | default_protocol, [INFO] [stdout] 64 | | _lock: lock, [INFO] [stdout] 65 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/cache.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 85 | let repo = if path.exists() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok(ProtoGitRepository::new(self, repo, url)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/mod.rs:543:18 [INFO] [stdout] | [INFO] [stdout] 543 | .map(|v| v.clone().try_into::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/mod.rs:549:23 [INFO] [stdout] | [INFO] [stdout] 549 | .and_then(|x| x.clone().try_into::().map_err(|e| e.into())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/mod.rs:561:18 [INFO] [stdout] | [INFO] [stdout] 561 | .map(|v| v.clone().try_into::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/mod.rs:567:18 [INFO] [stdout] | [INFO] [stdout] 567 | .map(|v| v.clone().try_into::>()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/mod.rs:576:18 [INFO] [stdout] | [INFO] [stdout] 576 | .map(|v| v.clone().try_into::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/mod.rs:601:18 [INFO] [stdout] | [INFO] [stdout] 601 | .map(|v| v.clone().try_into::>()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/protofetch/lock.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 29 | let mut table = toml::from_str::(s)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | match table.remove("version") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto.rs:212:8 [INFO] [stdout] | [INFO] [stdout] 171 | let mut found_proto_deps: HashSet = HashSet::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | let mut visited: HashSet = HashSet::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let mut visited_dep: HashSet = HashSet::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | Ok(found_proto_deps [INFO] [stdout] | ________^ [INFO] [stdout] 213 | | .into_iter() [INFO] [stdout] 214 | | .map(|p| ProtoFileMapping { [INFO] [stdout] 215 | | from: p.full_path, [INFO] [stdout] 216 | | to: p.package_path, [INFO] [stdout] 217 | | }) [INFO] [stdout] 218 | | .collect()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protofetch` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protofetch` (lib test) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "285f728a101a15e0652bc98fc5d65d36a17dec5da850e663597c7bd78ed90b9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "285f728a101a15e0652bc98fc5d65d36a17dec5da850e663597c7bd78ed90b9b", kill_on_drop: false }` [INFO] [stdout] 285f728a101a15e0652bc98fc5d65d36a17dec5da850e663597c7bd78ed90b9b