[INFO] cloning repository https://github.com/coral/carltrace [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/coral/carltrace" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoral%2Fcarltrace", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoral%2Fcarltrace'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6879c923c4ba84b46abe1259bc10f2873b2494d6 [INFO] checking coral/carltrace/6879c923c4ba84b46abe1259bc10f2873b2494d6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoral%2Fcarltrace" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/coral/carltrace on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/coral/carltrace [INFO] finished tweaking git repo https://github.com/coral/carltrace [INFO] tweaked toml for git repo https://github.com/coral/carltrace written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/coral/carltrace already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 430f775a7a338367eec148c6c1523263b0b01cd75b330fc6aea4da5b3f51b35f [INFO] running `Command { std: "docker" "start" "-a" "430f775a7a338367eec148c6c1523263b0b01cd75b330fc6aea4da5b3f51b35f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "430f775a7a338367eec148c6c1523263b0b01cd75b330fc6aea4da5b3f51b35f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "430f775a7a338367eec148c6c1523263b0b01cd75b330fc6aea4da5b3f51b35f", kill_on_drop: false }` [INFO] [stdout] 430f775a7a338367eec148c6c1523263b0b01cd75b330fc6aea4da5b3f51b35f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 476e0ed03c62c35ed8751ff1490744344388a548c0152fdbad3c9bd72ca1b62a [INFO] running `Command { std: "docker" "start" "-a" "476e0ed03c62c35ed8751ff1490744344388a548c0152fdbad3c9bd72ca1b62a", kill_on_drop: false }` [INFO] [stderr] Compiling version-compare v0.1.0 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Compiling anyhow v1.0.60 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking c_vec v2.0.0 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking carltrace v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/main.rs:2:14 [INFO] [stdout] | [INFO] [stdout] 2 | use anyhow::{Context, Result}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/overview.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | let x = 0.0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/overview.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | let mut a = s.camera.angle - (s.camera.fov / 2.0); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `w` [INFO] [stdout] --> src/tracer.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | let (w, h) = canvas.window().size(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_w` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/tracer.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | let (w, h) = canvas.window().size(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `h` and `scaling_factor` are never read [INFO] [stdout] --> src/overview.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Overview { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | h: u32, [INFO] [stdout] | ^ [INFO] [stdout] 12 | scaling_factor: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `height`, `ew`, and `eh` are never read [INFO] [stdout] --> src/state.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 65 | pub struct Map { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 68 | pub height: i64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 69 | [INFO] [stdout] 70 | pub ew: f64, [INFO] [stdout] | ^^ [INFO] [stdout] 71 | pub eh: f64, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `i` is never read [INFO] [stdout] --> src/tracer.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Tracer { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 5 | c: sdl2::render::Canvas, [INFO] [stdout] 6 | i: u8, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/overview.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn bootstrap(w: sdl2::video::Window) -> anyhow::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let canvas = w.into_canvas().build()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(Overview { [INFO] [stdout] | ____________^ [INFO] [stdout] 21 | | c: canvas, [INFO] [stdout] 22 | | w, [INFO] [stdout] 23 | | h, [INFO] [stdout] 24 | | scaling_factor: w as f64 / 100.0, [INFO] [stdout] 25 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracer.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn bootstrap(w: sdl2::video::Window) -> anyhow::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let canvas = w.into_canvas().build()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | Ok(Tracer { c: canvas, i: 0 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `carltrace` (bin "carltrace") due to 3 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/main.rs:2:14 [INFO] [stdout] | [INFO] [stdout] 2 | use anyhow::{Context, Result}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/overview.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | let x = 0.0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/overview.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | let mut a = s.camera.angle - (s.camera.fov / 2.0); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `w` [INFO] [stdout] --> src/tracer.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | let (w, h) = canvas.window().size(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_w` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/tracer.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | let (w, h) = canvas.window().size(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `h` and `scaling_factor` are never read [INFO] [stdout] --> src/overview.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Overview { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | h: u32, [INFO] [stdout] | ^ [INFO] [stdout] 12 | scaling_factor: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `height`, `ew`, and `eh` are never read [INFO] [stdout] --> src/state.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 65 | pub struct Map { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 68 | pub height: i64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 69 | [INFO] [stdout] 70 | pub ew: f64, [INFO] [stdout] | ^^ [INFO] [stdout] 71 | pub eh: f64, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `i` is never read [INFO] [stdout] --> src/tracer.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Tracer { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 5 | c: sdl2::render::Canvas, [INFO] [stdout] 6 | i: u8, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/overview.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn bootstrap(w: sdl2::video::Window) -> anyhow::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let canvas = w.into_canvas().build()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(Overview { [INFO] [stdout] | ____________^ [INFO] [stdout] 21 | | c: canvas, [INFO] [stdout] 22 | | w, [INFO] [stdout] 23 | | h, [INFO] [stdout] 24 | | scaling_factor: w as f64 / 100.0, [INFO] [stdout] 25 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracer.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn bootstrap(w: sdl2::video::Window) -> anyhow::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let canvas = w.into_canvas().build()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | Ok(Tracer { c: canvas, i: 0 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `carltrace` (bin "carltrace" test) due to 3 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "476e0ed03c62c35ed8751ff1490744344388a548c0152fdbad3c9bd72ca1b62a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "476e0ed03c62c35ed8751ff1490744344388a548c0152fdbad3c9bd72ca1b62a", kill_on_drop: false }` [INFO] [stdout] 476e0ed03c62c35ed8751ff1490744344388a548c0152fdbad3c9bd72ca1b62a