[INFO] cloning repository https://github.com/coopersimon/e-mips [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/coopersimon/e-mips" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoopersimon%2Fe-mips", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoopersimon%2Fe-mips'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 60901afbe8d9f821cc5ef4f04e4686816a5a5793 [INFO] checking coopersimon/e-mips/60901afbe8d9f821cc5ef4f04e4686816a5a5793 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoopersimon%2Fe-mips" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/coopersimon/e-mips on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/coopersimon/e-mips [INFO] finished tweaking git repo https://github.com/coopersimon/e-mips [INFO] tweaked toml for git repo https://github.com/coopersimon/e-mips written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/coopersimon/e-mips already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c424569609fe973db8c67ac51f5143204bcf3c0a40e9292e37302c6d1dc73678 [INFO] running `Command { std: "docker" "start" "-a" "c424569609fe973db8c67ac51f5143204bcf3c0a40e9292e37302c6d1dc73678", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c424569609fe973db8c67ac51f5143204bcf3c0a40e9292e37302c6d1dc73678", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c424569609fe973db8c67ac51f5143204bcf3c0a40e9292e37302c6d1dc73678", kill_on_drop: false }` [INFO] [stdout] c424569609fe973db8c67ac51f5143204bcf3c0a40e9292e37302c6d1dc73678 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa062c1320a23757f3ab75f83b041b7632c0ed168edb2da820e8ad7106484243 [INFO] running `Command { std: "docker" "start" "-a" "aa062c1320a23757f3ab75f83b041b7632c0ed168edb2da820e8ad7106484243", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking mips v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Mem16` [INFO] [stdout] --> src/cpu/mips1/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Mem16, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `exception` [INFO] [stdout] --> src/cpu/mips1/mod.rs:207:37 [INFO] [stdout] | [INFO] [stdout] 207 | fn trigger_exception(&mut self, exception: ExceptionCode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_exception` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bit` is never used [INFO] [stdout] --> src/common.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | pub const fn bit(num: usize) -> u32 { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_bit` is never used [INFO] [stdout] --> src/common.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | pub const fn test_bit(val: u32, bit_num: usize) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `make16` is never used [INFO] [stdout] --> src/common.rs:19:14 [INFO] [stdout] | [INFO] [stdout] 19 | pub const fn make16(lo: u8, hi: u8) -> u16 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `lo16` is never used [INFO] [stdout] --> src/common.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 24 | pub const fn lo16(val: u16) -> u8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `hi16` is never used [INFO] [stdout] --> src/common.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | pub const fn hi16(val: u16) -> u8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `make32` is never used [INFO] [stdout] --> src/common.rs:35:14 [INFO] [stdout] | [INFO] [stdout] 35 | pub const fn make32(b0: u8, b1: u8, b2: u8, b3: u8) -> u32 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bytes32` is never used [INFO] [stdout] --> src/common.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 41 | pub const fn bytes32(val: u32) -> (u8, u8, u8, u8) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `make64` is never used [INFO] [stdout] --> src/common.rs:46:14 [INFO] [stdout] | [INFO] [stdout] 46 | pub const fn make64(b0: u8, b1: u8, b2: u8, b3: u8, b4: u8, b5: u8, b6: u8, b7: u8) -> u64 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bytes64` is never used [INFO] [stdout] --> src/common.rs:52:14 [INFO] [stdout] | [INFO] [stdout] 52 | pub const fn bytes64(val: u64) -> (u8, u8, u8, u8, u8, u8, u8, u8) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/mod.rs:16:19 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new>(val: Other) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Self { [INFO] [stdout] 16 | addr: val.into() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/mod.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn inc(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Addr { [INFO] [stdout] 22 | addr: self.addr + Width::one() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/mips1/mod.rs:124:25 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn add_coproc1(self, coproc1: NewC1) -> MIPSIBuilder { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | coproc1: Some(coproc1), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/mips1/mod.rs:136:25 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn add_coproc2(self, coproc2: NewC2) -> MIPSIBuilder { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | coproc2: Some(coproc2), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/mips1/mod.rs:148:25 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn add_coproc3(self, coproc3: NewC3) -> MIPSIBuilder { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | coproc3: Some(coproc3), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mips` (lib) due to 6 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused import: `Mem16` [INFO] [stdout] --> src/cpu/mips1/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Mem16, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `exception` [INFO] [stdout] --> src/cpu/mips1/mod.rs:207:37 [INFO] [stdout] | [INFO] [stdout] 207 | fn trigger_exception(&mut self, exception: ExceptionCode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_exception` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bit` is never used [INFO] [stdout] --> src/common.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | pub const fn bit(num: usize) -> u32 { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_bit` is never used [INFO] [stdout] --> src/common.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | pub const fn test_bit(val: u32, bit_num: usize) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `make64` is never used [INFO] [stdout] --> src/common.rs:46:14 [INFO] [stdout] | [INFO] [stdout] 46 | pub const fn make64(b0: u8, b1: u8, b2: u8, b3: u8, b4: u8, b5: u8, b6: u8, b7: u8) -> u64 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bytes64` is never used [INFO] [stdout] --> src/common.rs:52:14 [INFO] [stdout] | [INFO] [stdout] 52 | pub const fn bytes64(val: u64) -> (u8, u8, u8, u8, u8, u8, u8, u8) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/mod.rs:16:19 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new>(val: Other) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Self { [INFO] [stdout] 16 | addr: val.into() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/mod.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn inc(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Addr { [INFO] [stdout] 22 | addr: self.addr + Width::one() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/mips1/mod.rs:124:25 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn add_coproc1(self, coproc1: NewC1) -> MIPSIBuilder { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | coproc1: Some(coproc1), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/mips1/mod.rs:136:25 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn add_coproc2(self, coproc2: NewC2) -> MIPSIBuilder { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | coproc2: Some(coproc2), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/mips1/mod.rs:148:25 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn add_coproc3(self, coproc3: NewC3) -> MIPSIBuilder { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | coproc3: Some(coproc3), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mips` (lib test) due to 6 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aa062c1320a23757f3ab75f83b041b7632c0ed168edb2da820e8ad7106484243", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa062c1320a23757f3ab75f83b041b7632c0ed168edb2da820e8ad7106484243", kill_on_drop: false }` [INFO] [stdout] aa062c1320a23757f3ab75f83b041b7632c0ed168edb2da820e8ad7106484243