[INFO] cloning repository https://github.com/connec/present [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/connec/present" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconnec%2Fpresent", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconnec%2Fpresent'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 14c44371edc9b1b45891f30a249fa879c8bd37a6 [INFO] checking connec/present/14c44371edc9b1b45891f30a249fa879c8bd37a6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconnec%2Fpresent" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/connec/present on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/connec/present [INFO] finished tweaking git repo https://github.com/connec/present [INFO] tweaked toml for git repo https://github.com/connec/present written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/connec/present already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Adding present v0.1.0 (/workspace/builds/worker-1-tc2/source) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1d466cd9dcb586787fdf89a5639988946841a9cab1192e13b7d457203c43a568 [INFO] running `Command { std: "docker" "start" "-a" "1d466cd9dcb586787fdf89a5639988946841a9cab1192e13b7d457203c43a568", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1d466cd9dcb586787fdf89a5639988946841a9cab1192e13b7d457203c43a568", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d466cd9dcb586787fdf89a5639988946841a9cab1192e13b7d457203c43a568", kill_on_drop: false }` [INFO] [stdout] 1d466cd9dcb586787fdf89a5639988946841a9cab1192e13b7d457203c43a568 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5bdaf37e5d29fd9f9071ed196d631f2ce3ac2f389216795925dfe159d47618b0 [INFO] running `Command { std: "docker" "start" "-a" "5bdaf37e5d29fd9f9071ed196d631f2ce3ac2f389216795925dfe159d47618b0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking tracing-core v0.1.22 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling httparse v1.6.0 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking tower-layer v0.3.1 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking http-range-header v0.3.0 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking sync_wrapper v0.1.1 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking matchit v0.4.6 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.8.0 [INFO] [stderr] Checking getrandom v0.2.5 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking sha-1 v0.10.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking headers v0.3.7 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tracing-attributes v0.1.19 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tungstenite v0.16.0 [INFO] [stderr] Checking tracing v0.1.31 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Checking tracing-subscriber v0.3.9 [INFO] [stderr] Checking axum-core v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking tokio-util v0.7.0 [INFO] [stderr] Checking hyper v0.14.17 [INFO] [stderr] Checking tokio-tungstenite v0.16.1 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking tower v0.4.12 [INFO] [stderr] Checking tower-http v0.2.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking axum v0.4.6 [INFO] [stderr] Checking present v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:45:87 [INFO] [stdout] | [INFO] [stdout] 40 | Extension(presence): Extension, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | ws.on_upgrade(move |socket| async move { connection(presence, tag, topic, socket).await }) [INFO] [stdout] | ------ ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:58:20 [INFO] [stdout] | [INFO] [stdout] 57 | fn from(msg: Message) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Self::Text(serde_json::to_string(&msg).expect("BUG: unserializable message")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:78:43 [INFO] [stdout] | [INFO] [stdout] 78 | stream::once(close_rx).map(|_| Ok(Event::Closed)), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/presence.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 86 | fn new(joined: Joined) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | msg_rx: BroadcastStream::new(joined.msg_rx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/presence.rs:115:36 [INFO] [stdout] | [INFO] [stdout] 115 | item => item.map(|opt| opt.flatten().map(Ok)), [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/presence.rs:192:54 [INFO] [stdout] | [INFO] [stdout] 192 | .filter_map(|res: Result<_, _>| Box::pin(async move { res.ok() })) [INFO] [stdout] | ----------------- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/presence.rs:278:69 [INFO] [stdout] | [INFO] [stdout] 278 | .and_then(|(k, v): (&Arc, &Weak<()>)| Some((k.clone(), v.upgrade()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:45:87 [INFO] [stdout] | [INFO] [stdout] 40 | Extension(presence): Extension, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | ws.on_upgrade(move |socket| async move { connection(presence, tag, topic, socket).await }) [INFO] [stdout] | ------ ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:58:20 [INFO] [stdout] | [INFO] [stdout] 57 | fn from(msg: Message) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Self::Text(serde_json::to_string(&msg).expect("BUG: unserializable message")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:78:43 [INFO] [stdout] | [INFO] [stdout] 78 | stream::once(close_rx).map(|_| Ok(Event::Closed)), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/presence.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 86 | fn new(joined: Joined) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | msg_rx: BroadcastStream::new(joined.msg_rx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/presence.rs:115:36 [INFO] [stdout] | [INFO] [stdout] 115 | item => item.map(|opt| opt.flatten().map(Ok)), [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/presence.rs:192:54 [INFO] [stdout] | [INFO] [stdout] 192 | .filter_map(|res: Result<_, _>| Box::pin(async move { res.ok() })) [INFO] [stdout] | ----------------- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/presence.rs:278:69 [INFO] [stdout] | [INFO] [stdout] 278 | .and_then(|(k, v): (&Arc, &Weak<()>)| Some((k.clone(), v.upgrade()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `present` (bin "present" test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `present` (bin "present") due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "5bdaf37e5d29fd9f9071ed196d631f2ce3ac2f389216795925dfe159d47618b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bdaf37e5d29fd9f9071ed196d631f2ce3ac2f389216795925dfe159d47618b0", kill_on_drop: false }` [INFO] [stdout] 5bdaf37e5d29fd9f9071ed196d631f2ce3ac2f389216795925dfe159d47618b0