[INFO] cloning repository https://github.com/connec/kvs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/connec/kvs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconnec%2Fkvs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconnec%2Fkvs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] afdf5b99b4c0ccf111900cc121486f05e1e54be1 [INFO] checking connec/kvs/afdf5b99b4c0ccf111900cc121486f05e1e54be1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconnec%2Fkvs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/connec/kvs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/connec/kvs [INFO] finished tweaking git repo https://github.com/connec/kvs [INFO] tweaked toml for git repo https://github.com/connec/kvs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/connec/kvs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ad675957807a3c2e1da71112584fb20d93a10c2d14cceab5c7a6fce4da96860e [INFO] running `Command { std: "docker" "start" "-a" "ad675957807a3c2e1da71112584fb20d93a10c2d14cceab5c7a6fce4da96860e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ad675957807a3c2e1da71112584fb20d93a10c2d14cceab5c7a6fce4da96860e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad675957807a3c2e1da71112584fb20d93a10c2d14cceab5c7a6fce4da96860e", kill_on_drop: false }` [INFO] [stdout] ad675957807a3c2e1da71112584fb20d93a10c2d14cceab5c7a6fce4da96860e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d50499bc3f0fe59e93a228e93c36af76fcdf8523de5c2e625fc55be62cfdc29a [INFO] running `Command { std: "docker" "start" "-a" "d50499bc3f0fe59e93a228e93c36af76fcdf8523de5c2e625fc55be62cfdc29a", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.4 [INFO] [stderr] Compiling libc v0.2.58 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling syn v0.15.36 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling serde v1.0.92 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling rayon-core v1.5.0 [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling ryu v0.2.8 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling bincode v1.1.4 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling slog v2.4.1 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking crc32fast v1.2.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rayon v1.1.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking historian v4.0.3 [INFO] [stderr] Checking futures v0.1.28 [INFO] [stderr] Checking rmp v0.8.7 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking chrono v0.4.7 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking isatty v0.1.9 [INFO] [stderr] Compiling regex v1.1.7 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking slog-async v2.3.0 [INFO] [stderr] Checking regex-syntax v0.6.7 [INFO] [stderr] Checking aho-corasick v0.7.3 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking tempfile v3.0.8 [INFO] [stderr] Compiling escargot v0.4.0 [INFO] [stderr] Checking utf8-ranges v1.0.3 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking csv-core v0.1.5 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking walkdir v2.2.8 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.92 [INFO] [stderr] Checking predicates v1.0.1 [INFO] [stderr] Checking hashbrown v0.3.1 [INFO] [stderr] Checking serde_json v1.0.39 [INFO] [stderr] Checking serde_bytes v0.11.1 [INFO] [stderr] Checking rmp-serde v0.13.7 [INFO] [stderr] Checking csv v1.0.7 [INFO] [stderr] Checking pagecache v0.17.0 [INFO] [stderr] Checking tinytemplate v1.0.2 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stderr] Checking assert_cmd v0.11.1 [INFO] [stderr] Checking sled v0.24.1 [INFO] [stderr] Checking kvs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn connect(address: A) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let stream = TcpStream::connect(address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Ok(Client { stream }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn connect(address: A) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let stream = TcpStream::connect(address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Ok(Client { stream }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let mut readers = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let writer = open_writer(&path, write_index)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(Store { [INFO] [stdout] | ____________^ [INFO] [stdout] 95 | | path, [INFO] [stdout] 96 | | log_index: write_index, [INFO] [stdout] 97 | | writer, [INFO] [stdout] ... | [INFO] [stdout] 100 | | uncompacted, [INFO] [stdout] 101 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:243:18 [INFO] [stdout] | [INFO] [stdout] 242 | fn open_writer>(path: P, log_index: u64) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | Writer::init(OpenOptions::new().create(true).write(true).open(log_path(path, log_index))?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:247:8 [INFO] [stdout] | [INFO] [stdout] 246 | fn open_reader>(path: P, log_index: u64) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | Ok(Reader::new(File::open(log_path(path, log_index))?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:252:45 [INFO] [stdout] | [INFO] [stdout] 252 | .flat_map(|entry| -> Result<_> { Ok(entry?.path()) }) [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/engine/kvs.rs:274:17 [INFO] [stdout] | [INFO] [stdout] 274 | mem::replace(old_entry, new_entry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 274 | let _ = mem::replace(old_entry, new_entry); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs/log.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | #[derive(Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs/log.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 80 | fn init(mut reader: R) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | reader.seek(SeekFrom::Start(0))?; [INFO] [stdout] 82 | Ok(ReaderIterator { reader, offset: 0 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs/log.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn init(mut file: File) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let offset = file.seek(SeekFrom::End(0))?; [INFO] [stdout] 119 | Ok(Writer { file, offset }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | #[derive(Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | #[derive(Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn start(log: slog::Logger, engine: E, address: A) -> Result { [INFO] [stdout] | ----------------- --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | info!(log, "Starting server"); [INFO] [stdout] 22 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | log, [INFO] [stdout] 24 | | engine, [INFO] [stdout] 25 | | listener: TcpListener::bind(address)?, [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let mut readers = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let writer = open_writer(&path, write_index)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(Store { [INFO] [stdout] | ____________^ [INFO] [stdout] 95 | | path, [INFO] [stdout] 96 | | log_index: write_index, [INFO] [stdout] 97 | | writer, [INFO] [stdout] ... | [INFO] [stdout] 100 | | uncompacted, [INFO] [stdout] 101 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:243:18 [INFO] [stdout] | [INFO] [stdout] 242 | fn open_writer>(path: P, log_index: u64) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | Writer::init(OpenOptions::new().create(true).write(true).open(log_path(path, log_index))?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:247:8 [INFO] [stdout] | [INFO] [stdout] 246 | fn open_reader>(path: P, log_index: u64) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | Ok(Reader::new(File::open(log_path(path, log_index))?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:252:45 [INFO] [stdout] | [INFO] [stdout] 252 | .flat_map(|entry| -> Result<_> { Ok(entry?.path()) }) [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/engine/kvs.rs:274:17 [INFO] [stdout] | [INFO] [stdout] 274 | mem::replace(old_entry, new_entry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 274 | let _ = mem::replace(old_entry, new_entry); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs/log.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | #[derive(Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs/log.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 80 | fn init(mut reader: R) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | reader.seek(SeekFrom::Start(0))?; [INFO] [stdout] 82 | Ok(ReaderIterator { reader, offset: 0 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs/log.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn init(mut file: File) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let offset = file.seek(SeekFrom::End(0))?; [INFO] [stdout] 119 | Ok(Writer { file, offset }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | #[derive(Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib test) due to 13 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | #[derive(Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn start(log: slog::Logger, engine: E, address: A) -> Result { [INFO] [stdout] | ----------------- --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | info!(log, "Starting server"); [INFO] [stdout] 22 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | log, [INFO] [stdout] 24 | | engine, [INFO] [stdout] 25 | | listener: TcpListener::bind(address)?, [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib) due to 13 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d50499bc3f0fe59e93a228e93c36af76fcdf8523de5c2e625fc55be62cfdc29a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d50499bc3f0fe59e93a228e93c36af76fcdf8523de5c2e625fc55be62cfdc29a", kill_on_drop: false }` [INFO] [stdout] d50499bc3f0fe59e93a228e93c36af76fcdf8523de5c2e625fc55be62cfdc29a