[INFO] cloning repository https://github.com/conaticus/click [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/conaticus/click" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconaticus%2Fclick", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconaticus%2Fclick'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ab88c8e6fc3a7cce5a791758638d5083f355f8b1 [INFO] checking conaticus/click/ab88c8e6fc3a7cce5a791758638d5083f355f8b1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconaticus%2Fclick" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/conaticus/click on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/conaticus/click [INFO] finished tweaking git repo https://github.com/conaticus/click [INFO] tweaked toml for git repo https://github.com/conaticus/click written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/conaticus/click already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b1e741b3bf9eb68e1efea2ae445f7c868cc0fe6dc4f90e4da54956e0908740fc [INFO] running `Command { std: "docker" "start" "-a" "b1e741b3bf9eb68e1efea2ae445f7c868cc0fe6dc4f90e4da54956e0908740fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b1e741b3bf9eb68e1efea2ae445f7c868cc0fe6dc4f90e4da54956e0908740fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b1e741b3bf9eb68e1efea2ae445f7c868cc0fe6dc4f90e4da54956e0908740fc", kill_on_drop: false }` [INFO] [stdout] b1e741b3bf9eb68e1efea2ae445f7c868cc0fe6dc4f90e4da54956e0908740fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6ff5270f3c8951e185457b90049cece9e518076b8b14eae317370ac784fc3c4 [INFO] running `Command { std: "docker" "start" "-a" "b6ff5270f3c8951e185457b90049cece9e518076b8b14eae317370ac784fc3c4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling openssl v0.10.57 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling syn v2.0.36 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling semver v1.0.18 [INFO] [stderr] Compiling thiserror v1.0.48 [INFO] [stderr] Compiling async-trait v0.1.73 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking xattr v1.0.1 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking base64 v0.21.4 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Compiling openssl-sys v0.9.93 [INFO] [stderr] Checking flate2 v1.0.27 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking symlink v0.1.0 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.48 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.20 [INFO] [stderr] Checking click v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `path::Path` [INFO] [stdout] --> src/cache.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | path::Path, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `path::Path` [INFO] [stdout] --> src/cache.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | path::Path, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn extract_tarball(bytes: Bytes, dest: String) -> Result<(), CommandError> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let bytes = &bytes.to_vec()[..]; [INFO] [stdout] 18 | let gz = GzDecoder::new(bytes); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let mut archive = Archive::new(gz); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | / archive [INFO] [stdout] 23 | | .unpack(&dest) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn add_task(future: T) -> JoinHandle [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 38 | | Self::increment_tasks(); [INFO] [stdout] 39 | | let future_result = future.await; [INFO] [stdout] 40 | | Self::decrement_tasks(); [INFO] [stdout] 41 | | [INFO] [stdout] 42 | | future_result [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:51:37 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn add_blocking(f: F) -> JoinHandle [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | tokio::task::spawn_blocking(move || { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 52 | | Self::increment_tasks(); [INFO] [stdout] 53 | | let task_result = f(); [INFO] [stdout] 54 | | Self::decrement_tasks(); [INFO] [stdout] 55 | | [INFO] [stdout] 56 | | task_result [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versions.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 39 | let mut version = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | VersionReq::parse(raw_version).map_err(ParseError::InvalidVersionNotation)?; [INFO] [stdout] 41 | Ok(version.comparators.remove(0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versions.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 51 | let comparator = Self::parse_semantic_version(&version_raw)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Ok((name, Some(comparator))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `click` (bin "click" test) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn extract_tarball(bytes: Bytes, dest: String) -> Result<(), CommandError> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let bytes = &bytes.to_vec()[..]; [INFO] [stdout] 18 | let gz = GzDecoder::new(bytes); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let mut archive = Archive::new(gz); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | / archive [INFO] [stdout] 23 | | .unpack(&dest) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn add_task(future: T) -> JoinHandle [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 38 | | Self::increment_tasks(); [INFO] [stdout] 39 | | let future_result = future.await; [INFO] [stdout] 40 | | Self::decrement_tasks(); [INFO] [stdout] 41 | | [INFO] [stdout] 42 | | future_result [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:51:37 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn add_blocking(f: F) -> JoinHandle [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | tokio::task::spawn_blocking(move || { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 52 | | Self::increment_tasks(); [INFO] [stdout] 53 | | let task_result = f(); [INFO] [stdout] 54 | | Self::decrement_tasks(); [INFO] [stdout] 55 | | [INFO] [stdout] 56 | | task_result [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versions.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 39 | let mut version = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | VersionReq::parse(raw_version).map_err(ParseError::InvalidVersionNotation)?; [INFO] [stdout] 41 | Ok(version.comparators.remove(0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versions.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 51 | let comparator = Self::parse_semantic_version(&version_raw)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Ok((name, Some(comparator))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `click` (bin "click") due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b6ff5270f3c8951e185457b90049cece9e518076b8b14eae317370ac784fc3c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6ff5270f3c8951e185457b90049cece9e518076b8b14eae317370ac784fc3c4", kill_on_drop: false }` [INFO] [stdout] b6ff5270f3c8951e185457b90049cece9e518076b8b14eae317370ac784fc3c4