[INFO] cloning repository https://github.com/collinoc/cargo-lookup [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/collinoc/cargo-lookup" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcollinoc%2Fcargo-lookup", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcollinoc%2Fcargo-lookup'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cac8af9611e3c0b5f8805ae5fa570ed8e2e96910 [INFO] checking collinoc/cargo-lookup/cac8af9611e3c0b5f8805ae5fa570ed8e2e96910 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcollinoc%2Fcargo-lookup" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/collinoc/cargo-lookup on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/collinoc/cargo-lookup [INFO] finished tweaking git repo https://github.com/collinoc/cargo-lookup [INFO] tweaked toml for git repo https://github.com/collinoc/cargo-lookup written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/collinoc/cargo-lookup already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec51b4dea11e5ff661f9cfd4ff7500ae534e71e66d2c11deb182fa5e7958c78b [INFO] running `Command { std: "docker" "start" "-a" "ec51b4dea11e5ff661f9cfd4ff7500ae534e71e66d2c11deb182fa5e7958c78b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec51b4dea11e5ff661f9cfd4ff7500ae534e71e66d2c11deb182fa5e7958c78b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec51b4dea11e5ff661f9cfd4ff7500ae534e71e66d2c11deb182fa5e7958c78b", kill_on_drop: false }` [INFO] [stdout] ec51b4dea11e5ff661f9cfd4ff7500ae534e71e66d2c11deb182fa5e7958c78b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] efe19d4e3e54232576442024859fc63f362f4043e3e1bf587520a577488dad2f [INFO] running `Command { std: "docker" "start" "-a" "efe19d4e3e54232576442024859fc63f362f4043e3e1bf587520a577488dad2f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking rustls-pki-types v1.3.1 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling rustls v0.22.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking rustls-webpki v0.102.2 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stderr] Checking ureq v2.9.6 [INFO] [stderr] Checking cargo-lookup v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 72 | let version_req = version_req [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | name: name.to_owned(), [INFO] [stdout] 78 | | version_req, [INFO] [stdout] 79 | | custom_index: None, [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:24 [INFO] [stdout] | [INFO] [stdout] 73 | .map(|req| VersionReq::parse(req).map_err(Error::InvalidVersion)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:100:43 [INFO] [stdout] | [INFO] [stdout] 100 | .map_err(|err| Error::Request(Box::new(err)))? [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn into_version(self, version_req: &semver::VersionReq) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | / self.releases [INFO] [stdout] 168 | | .into_iter() [INFO] [stdout] 169 | | .rev() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn from_index(content: T) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let releases: Result> = content [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let releases = releases?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Ok(Package { [INFO] [stdout] | ____________^ [INFO] [stdout] 208 | | name, [INFO] [stdout] 209 | | index_path, [INFO] [stdout] 210 | | releases, [INFO] [stdout] 211 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:195:28 [INFO] [stdout] | [INFO] [stdout] 195 | .map(|release| serde_json::from_str(release).map_err(Error::Deserialize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-lookup` (lib) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 72 | let version_req = version_req [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | name: name.to_owned(), [INFO] [stdout] 78 | | version_req, [INFO] [stdout] 79 | | custom_index: None, [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:24 [INFO] [stdout] | [INFO] [stdout] 73 | .map(|req| VersionReq::parse(req).map_err(Error::InvalidVersion)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:100:43 [INFO] [stdout] | [INFO] [stdout] 100 | .map_err(|err| Error::Request(Box::new(err)))? [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn into_version(self, version_req: &semver::VersionReq) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | / self.releases [INFO] [stdout] 168 | | .into_iter() [INFO] [stdout] 169 | | .rev() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn from_index(content: T) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let releases: Result> = content [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let releases = releases?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Ok(Package { [INFO] [stdout] | ____________^ [INFO] [stdout] 208 | | name, [INFO] [stdout] 209 | | index_path, [INFO] [stdout] 210 | | releases, [INFO] [stdout] 211 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:195:28 [INFO] [stdout] | [INFO] [stdout] 195 | .map(|release| serde_json::from_str(release).map_err(Error::Deserialize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-lookup` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "efe19d4e3e54232576442024859fc63f362f4043e3e1bf587520a577488dad2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "efe19d4e3e54232576442024859fc63f362f4043e3e1bf587520a577488dad2f", kill_on_drop: false }` [INFO] [stdout] efe19d4e3e54232576442024859fc63f362f4043e3e1bf587520a577488dad2f