[INFO] cloning repository https://github.com/colin-heffernan/reflex [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/colin-heffernan/reflex" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcolin-heffernan%2Freflex", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcolin-heffernan%2Freflex'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a2d44c18bd5bc17addbc6d382be3581ad1ab0a7b [INFO] checking colin-heffernan/reflex/a2d44c18bd5bc17addbc6d382be3581ad1ab0a7b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcolin-heffernan%2Freflex" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/colin-heffernan/reflex on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/colin-heffernan/reflex [INFO] finished tweaking git repo https://github.com/colin-heffernan/reflex [INFO] tweaked toml for git repo https://github.com/colin-heffernan/reflex written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/colin-heffernan/reflex already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 342365d0f503302801819322cb4410001a553c4aa09eba89b3622d368232bb22 [INFO] running `Command { std: "docker" "start" "-a" "342365d0f503302801819322cb4410001a553c4aa09eba89b3622d368232bb22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "342365d0f503302801819322cb4410001a553c4aa09eba89b3622d368232bb22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "342365d0f503302801819322cb4410001a553c4aa09eba89b3622d368232bb22", kill_on_drop: false }` [INFO] [stdout] 342365d0f503302801819322cb4410001a553c4aa09eba89b3622d368232bb22 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e5df65ea7ec2f03ff35a7d555dff60d20fcd62b7b70bc823f2cb57bf0c3c1908 [INFO] running `Command { std: "docker" "start" "-a" "e5df65ea7ec2f03ff35a7d555dff60d20fcd62b7b70bc823f2cb57bf0c3c1908", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking str_indices v0.4.3 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking ropey v1.6.1 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking reflex-editor v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 62 | let default_buffer = if args.len() > 1 { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let file_name = &args[1]; [INFO] [stdout] 64 | let wrapped_doc = FileBuffer::open(file_name); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | if let Ok(document) = wrapped_doc { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | terminal: Terminal::new().expect("Failed to initialize terminal"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 62 | let default_buffer = if args.len() > 1 { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let file_name = &args[1]; [INFO] [stdout] 64 | let wrapped_doc = FileBuffer::open(file_name); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | if let Ok(document) = wrapped_doc { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | terminal: Terminal::new().expect("Failed to initialize terminal"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filebuffer.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 60 | let file_contents = Rope::from_reader(BufReader::new(File::open(file_path)?))?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | // buffer_has_content: true, [INFO] [stdout] 63 | | file_contents, [INFO] [stdout] 64 | | file_path: Some(file_path.to_string()), [INFO] [stdout] ... | [INFO] [stdout] 67 | | ..Default::default() [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filebuffer.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 60 | let file_contents = Rope::from_reader(BufReader::new(File::open(file_path)?))?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | // buffer_has_content: true, [INFO] [stdout] 63 | | file_contents, [INFO] [stdout] 64 | | file_path: Some(file_path.to_string()), [INFO] [stdout] ... | [INFO] [stdout] 67 | | ..Default::default() [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reflex-editor` (bin "rflx") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `reflex-editor` (bin "rflx" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "e5df65ea7ec2f03ff35a7d555dff60d20fcd62b7b70bc823f2cb57bf0c3c1908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5df65ea7ec2f03ff35a7d555dff60d20fcd62b7b70bc823f2cb57bf0c3c1908", kill_on_drop: false }` [INFO] [stdout] e5df65ea7ec2f03ff35a7d555dff60d20fcd62b7b70bc823f2cb57bf0c3c1908