[INFO] cloning repository https://github.com/cognivore/icfpc2004-tbd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cognivore/icfpc2004-tbd" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcognivore%2Ficfpc2004-tbd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcognivore%2Ficfpc2004-tbd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 059407aa9903c84f28767bf6e27b6f92696a93a9 [INFO] checking cognivore/icfpc2004-tbd/059407aa9903c84f28767bf6e27b6f92696a93a9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcognivore%2Ficfpc2004-tbd" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cognivore/icfpc2004-tbd on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cognivore/icfpc2004-tbd [INFO] finished tweaking git repo https://github.com/cognivore/icfpc2004-tbd [INFO] tweaked toml for git repo https://github.com/cognivore/icfpc2004-tbd written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cognivore/icfpc2004-tbd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62eea3bf0bbfa12daa2480a5213d7e8ee6bd69056c0e0dc934531810d823b83f [INFO] running `Command { std: "docker" "start" "-a" "62eea3bf0bbfa12daa2480a5213d7e8ee6bd69056c0e0dc934531810d823b83f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62eea3bf0bbfa12daa2480a5213d7e8ee6bd69056c0e0dc934531810d823b83f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62eea3bf0bbfa12daa2480a5213d7e8ee6bd69056c0e0dc934531810d823b83f", kill_on_drop: false }` [INFO] [stdout] 62eea3bf0bbfa12daa2480a5213d7e8ee6bd69056c0e0dc934531810d823b83f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6201cbb34e99931ea643308c82e064cca1d84a1f49c422452bda6a2e14c42187 [INFO] running `Command { std: "docker" "start" "-a" "6201cbb34e99931ea643308c82e064cca1d84a1f49c422452bda6a2e14c42187", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking tinyvec v1.2.0 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Compiling icfpc2004-tbd v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking bimap v0.4.0 [INFO] [stderr] Checking htmlescape v0.3.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking quickcheck v0.9.2 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling enum-display-derive v0.1.1 [INFO] [stderr] Compiling quickcheck_macros v0.9.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dev_server.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn body(mut self, body: impl AsRef<[u8]>) -> HandlerResult { [INFO] [stdout] | -------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(Some(self.stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prelude.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | (0..n).map(|x| FromPrimitive::from_i8(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/structured_compiler.rs:114:14 [INFO] [stdout] | [INFO] [stdout] 113 | fn with_ctx(f: impl FnOnce(&mut CompilerCtx) -> T) -> T { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | CTX.with(|ctx| -> T { [INFO] [stdout] | ______________^ [INFO] [stdout] 115 | | f(&mut ctx.borrow_mut().as_mut().expect("Call compile()")) [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/structured_compiler.rs:115:16 [INFO] [stdout] | [INFO] [stdout] 113 | fn with_ctx(f: impl FnOnce(&mut CompilerCtx) -> T) -> T { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | CTX.with(|ctx| -> T { [INFO] [stdout] 115 | f(&mut ctx.borrow_mut().as_mut().expect("Call compile()")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/structured_compiler.rs:122:14 [INFO] [stdout] | [INFO] [stdout] 121 | fn with_fixup(f: impl FnOnce(Fixup) -> FixableInstruction) { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | with_ctx(|ctx| { [INFO] [stdout] | ______________^ [INFO] [stdout] 123 | | ctx.fixup(); [INFO] [stdout] 124 | | let fixup = ctx.set_fixup(); [INFO] [stdout] 125 | | ctx.insns.push(f(fixup)); [INFO] [stdout] 126 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/py/ast.rs:399:12 [INFO] [stdout] | [INFO] [stdout] 397 | let body = self.parse_block()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | self.consume_expected_kind(TokenKind::Dedent)?; [INFO] [stdout] 399 | Ok(Stmt::Def { [INFO] [stdout] | ____________^ [INFO] [stdout] 400 | | token_idx, [INFO] [stdout] 401 | | name, [INFO] [stdout] 402 | | args, [INFO] [stdout] 403 | | body, [INFO] [stdout] 404 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/py/ast.rs:430:12 [INFO] [stdout] | [INFO] [stdout] 408 | let left = self.parse_expr()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | let right = self.parse_expr()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 429 | [INFO] [stdout] 430 | Ok(Stmt::Assign { [INFO] [stdout] | ____________^ [INFO] [stdout] 431 | | left, right, op [INFO] [stdout] 432 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `icfpc2004-tbd` (bin "icfpc2004-tbd") due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dev_server.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn body(mut self, body: impl AsRef<[u8]>) -> HandlerResult { [INFO] [stdout] | -------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(Some(self.stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prelude.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | (0..n).map(|x| FromPrimitive::from_i8(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/structured_compiler.rs:114:14 [INFO] [stdout] | [INFO] [stdout] 113 | fn with_ctx(f: impl FnOnce(&mut CompilerCtx) -> T) -> T { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | CTX.with(|ctx| -> T { [INFO] [stdout] | ______________^ [INFO] [stdout] 115 | | f(&mut ctx.borrow_mut().as_mut().expect("Call compile()")) [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/structured_compiler.rs:115:16 [INFO] [stdout] | [INFO] [stdout] 113 | fn with_ctx(f: impl FnOnce(&mut CompilerCtx) -> T) -> T { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | CTX.with(|ctx| -> T { [INFO] [stdout] 115 | f(&mut ctx.borrow_mut().as_mut().expect("Call compile()")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/structured_compiler.rs:122:14 [INFO] [stdout] | [INFO] [stdout] 121 | fn with_fixup(f: impl FnOnce(Fixup) -> FixableInstruction) { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | with_ctx(|ctx| { [INFO] [stdout] | ______________^ [INFO] [stdout] 123 | | ctx.fixup(); [INFO] [stdout] 124 | | let fixup = ctx.set_fixup(); [INFO] [stdout] 125 | | ctx.insns.push(f(fixup)); [INFO] [stdout] 126 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/py/ast.rs:399:12 [INFO] [stdout] | [INFO] [stdout] 397 | let body = self.parse_block()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | self.consume_expected_kind(TokenKind::Dedent)?; [INFO] [stdout] 399 | Ok(Stmt::Def { [INFO] [stdout] | ____________^ [INFO] [stdout] 400 | | token_idx, [INFO] [stdout] 401 | | name, [INFO] [stdout] 402 | | args, [INFO] [stdout] 403 | | body, [INFO] [stdout] 404 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/py/ast.rs:430:12 [INFO] [stdout] | [INFO] [stdout] 408 | let left = self.parse_expr()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | let right = self.parse_expr()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 429 | [INFO] [stdout] 430 | Ok(Stmt::Assign { [INFO] [stdout] | ____________^ [INFO] [stdout] 431 | | left, right, op [INFO] [stdout] 432 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `icfpc2004-tbd` (bin "icfpc2004-tbd" test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "6201cbb34e99931ea643308c82e064cca1d84a1f49c422452bda6a2e14c42187", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6201cbb34e99931ea643308c82e064cca1d84a1f49c422452bda6a2e14c42187", kill_on_drop: false }` [INFO] [stdout] 6201cbb34e99931ea643308c82e064cca1d84a1f49c422452bda6a2e14c42187