[INFO] cloning repository https://github.com/codepr/sake [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/codepr/sake" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodepr%2Fsake", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodepr%2Fsake'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6569bdb3a416519750758de47e2d4f9a5f5b9fdd [INFO] checking codepr/sake/6569bdb3a416519750758de47e2d4f9a5f5b9fdd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodepr%2Fsake" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/codepr/sake on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/codepr/sake [INFO] finished tweaking git repo https://github.com/codepr/sake [INFO] tweaked toml for git repo https://github.com/codepr/sake written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/codepr/sake already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ddc65529669ea6aefd90eb191d8e3314753a8763db250b9698a3f777977758e0 [INFO] running `Command { std: "docker" "start" "-a" "ddc65529669ea6aefd90eb191d8e3314753a8763db250b9698a3f777977758e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ddc65529669ea6aefd90eb191d8e3314753a8763db250b9698a3f777977758e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ddc65529669ea6aefd90eb191d8e3314753a8763db250b9698a3f777977758e0", kill_on_drop: false }` [INFO] [stdout] ddc65529669ea6aefd90eb191d8e3314753a8763db250b9698a3f777977758e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b8631c8a0d226d1ee32e7933ebfc004ded966b8f59450e2ad65f34112fe1709e [INFO] running `Command { std: "docker" "start" "-a" "b8631c8a0d226d1ee32e7933ebfc004ded966b8f59450e2ad65f34112fe1709e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling io-lifetimes v1.0.5 [INFO] [stderr] Compiling rustix v0.36.8 [INFO] [stderr] Checking os_str_bytes v6.4.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking shlex v1.1.0 [INFO] [stderr] Checking clap_lex v0.3.1 [INFO] [stderr] Checking is-terminal v0.4.3 [INFO] [stderr] Checking clap v4.1.6 [INFO] [stderr] Checking sake v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/mqtt/subscribe.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 17 | impl SubscribePacket { [INFO] [stdout] | -------------------- associated function in this implementation [INFO] [stdout] 18 | pub fn new(packet_id: u16, subscription_topics: Vec) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mqtt/mod.rs:601:12 [INFO] [stdout] | [INFO] [stdout] 600 | pub fn with_stream(stream: TcpStream) -> io::Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 601 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 602 | | reader: io::BufReader::new(stream.try_clone()?), [INFO] [stdout] 603 | | stream, [INFO] [stdout] 604 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/mqtt/subscribe.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | protocol::write_string(buf, &s.topic); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 30 | let _ = protocol::write_string(buf, &s.topic); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/mqtt/subscribe.rs:31:17 [INFO] [stdout] | [INFO] [stdout] 31 | buf.write_u8(s.qos as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 31 | let _ = buf.write_u8(s.qos as u8); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sake` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/mqtt/subscribe.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 17 | impl SubscribePacket { [INFO] [stdout] | -------------------- associated function in this implementation [INFO] [stdout] 18 | pub fn new(packet_id: u16, subscription_topics: Vec) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mqtt/mod.rs:601:12 [INFO] [stdout] | [INFO] [stdout] 600 | pub fn with_stream(stream: TcpStream) -> io::Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 601 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 602 | | reader: io::BufReader::new(stream.try_clone()?), [INFO] [stdout] 603 | | stream, [INFO] [stdout] 604 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/mqtt/subscribe.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | protocol::write_string(buf, &s.topic); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 30 | let _ = protocol::write_string(buf, &s.topic); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/mqtt/subscribe.rs:31:17 [INFO] [stdout] | [INFO] [stdout] 31 | buf.write_u8(s.qos as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 31 | let _ = buf.write_u8(s.qos as u8); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sake` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b8631c8a0d226d1ee32e7933ebfc004ded966b8f59450e2ad65f34112fe1709e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8631c8a0d226d1ee32e7933ebfc004ded966b8f59450e2ad65f34112fe1709e", kill_on_drop: false }` [INFO] [stdout] b8631c8a0d226d1ee32e7933ebfc004ded966b8f59450e2ad65f34112fe1709e