[INFO] cloning repository https://github.com/codebyred/rust_basic_web_server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/codebyred/rust_basic_web_server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodebyred%2Frust_basic_web_server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodebyred%2Frust_basic_web_server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5bf02086eea159274a20228892002296d5dcc333 [INFO] checking codebyred/rust_basic_web_server/5bf02086eea159274a20228892002296d5dcc333 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodebyred%2Frust_basic_web_server" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/codebyred/rust_basic_web_server on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/codebyred/rust_basic_web_server [INFO] finished tweaking git repo https://github.com/codebyred/rust_basic_web_server [INFO] tweaked toml for git repo https://github.com/codebyred/rust_basic_web_server written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/codebyred/rust_basic_web_server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3d791904d8cb29b79c4f50e1ea75c34d04cde106cce82471000397692edb559f [INFO] running `Command { std: "docker" "start" "-a" "3d791904d8cb29b79c4f50e1ea75c34d04cde106cce82471000397692edb559f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3d791904d8cb29b79c4f50e1ea75c34d04cde106cce82471000397692edb559f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d791904d8cb29b79c4f50e1ea75c34d04cde106cce82471000397692edb559f", kill_on_drop: false }` [INFO] [stdout] 3d791904d8cb29b79c4f50e1ea75c34d04cde106cce82471000397692edb559f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6ec6b364b8eadbec4423ae27d70bd54e0bb35092fcebee25abed8bcb12d170b9 [INFO] running `Command { std: "docker" "start" "-a" "6ec6b364b8eadbec4423ae27d70bd54e0bb35092fcebee25abed8bcb12d170b9", kill_on_drop: false }` [INFO] [stderr] Checking rust_basic_web_server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `id` and `handler` are never read [INFO] [stdout] --> src/threadpool.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 19 | struct Worker { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 20 | id: u32, [INFO] [stdout] | ^^ [INFO] [stdout] 21 | handler: thread::JoinHandle<()> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Worker` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `threads` is never read [INFO] [stdout] --> src/threadpool.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 44 | pub struct ThreadPool{ [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 45 | threads: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ThreadPool` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadpool.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 25 | fn new(id: u32, receiver: Arc>>) -> Worker { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | handler: thread::spawn(move || loop { [INFO] [stdout] | ______________________^ [INFO] [stdout] 29 | | [INFO] [stdout] 30 | | let job = receiver [INFO] [stdout] 31 | | .lock() [INFO] [stdout] ... | [INFO] [stdout] 37 | | [INFO] [stdout] 38 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadpool.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 63 | let mut threads = Vec::with_capacity(size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | [INFO] [stdout] 65 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | let receiver = Arc::new(Mutex::new(rx)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(ThreadPool { threads , sender:tx}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_basic_web_server` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stdout] warning: fields `id` and `handler` are never read [INFO] [stdout] --> src/threadpool.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 19 | struct Worker { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 20 | id: u32, [INFO] [stdout] | ^^ [INFO] [stdout] 21 | handler: thread::JoinHandle<()> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Worker` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `threads` is never read [INFO] [stdout] --> src/threadpool.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 44 | pub struct ThreadPool{ [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 45 | threads: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ThreadPool` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadpool.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 25 | fn new(id: u32, receiver: Arc>>) -> Worker { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | handler: thread::spawn(move || loop { [INFO] [stdout] | ______________________^ [INFO] [stdout] 29 | | [INFO] [stdout] 30 | | let job = receiver [INFO] [stdout] 31 | | .lock() [INFO] [stdout] ... | [INFO] [stdout] 37 | | [INFO] [stdout] 38 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadpool.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 63 | let mut threads = Vec::with_capacity(size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | [INFO] [stdout] 65 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | let receiver = Arc::new(Mutex::new(rx)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(ThreadPool { threads , sender:tx}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_basic_web_server` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6ec6b364b8eadbec4423ae27d70bd54e0bb35092fcebee25abed8bcb12d170b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ec6b364b8eadbec4423ae27d70bd54e0bb35092fcebee25abed8bcb12d170b9", kill_on_drop: false }` [INFO] [stdout] 6ec6b364b8eadbec4423ae27d70bd54e0bb35092fcebee25abed8bcb12d170b9