[INFO] cloning repository https://github.com/code-supply/rusty-git-mob [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/code-supply/rusty-git-mob" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcode-supply%2Frusty-git-mob", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcode-supply%2Frusty-git-mob'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4e80e21b8282f6fef551b5c7bce45c5de6950ef1 [INFO] checking code-supply/rusty-git-mob/4e80e21b8282f6fef551b5c7bce45c5de6950ef1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcode-supply%2Frusty-git-mob" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/code-supply/rusty-git-mob on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/code-supply/rusty-git-mob [INFO] finished tweaking git repo https://github.com/code-supply/rusty-git-mob [INFO] tweaked toml for git repo https://github.com/code-supply/rusty-git-mob written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/code-supply/rusty-git-mob already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aaabc0a9f0d7b9192ff2e21f7a34542cceb33520783ec469fcfa8e4406a14654 [INFO] running `Command { std: "docker" "start" "-a" "aaabc0a9f0d7b9192ff2e21f7a34542cceb33520783ec469fcfa8e4406a14654", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aaabc0a9f0d7b9192ff2e21f7a34542cceb33520783ec469fcfa8e4406a14654", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aaabc0a9f0d7b9192ff2e21f7a34542cceb33520783ec469fcfa8e4406a14654", kill_on_drop: false }` [INFO] [stdout] aaabc0a9f0d7b9192ff2e21f7a34542cceb33520783ec469fcfa8e4406a14654 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 02ccd41afa2848bfc32f9f86fd2f04a34e308be9629aa160369a475e06bfd951 [INFO] running `Command { std: "docker" "start" "-a" "02ccd41afa2848bfc32f9f86fd2f04a34e308be9629aa160369a475e06bfd951", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking zerocopy v0.7.33 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Compiling cc v1.0.96 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking num v0.4.2 [INFO] [stderr] Compiling libz-sys v1.1.16 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Compiling ncurses v5.101.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling darling_core v0.20.8 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Compiling serde_derive v1.0.200 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling darling_macro v0.20.8 [INFO] [stderr] Compiling darling v0.20.8 [INFO] [stderr] Compiling enumset_derive v0.8.1 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking enumset v1.1.3 [INFO] [stderr] Checking cursive_core v0.3.7 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking cursive v0.20.0 [INFO] [stderr] Checking rusty-git-mob v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 76 | let coauthors_file = File::open(coauthors_path).or(Err(EnvError::MissingCoauthorsFile))?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let mob_file = open_read_write(mob_path).expect("mob file error"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let template_file = open_read_write(template_path).expect("template file error"); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let mob: serde_json::Result> = serde_json::from_reader(BufReader::new(&mob_file)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Ok(Env { [INFO] [stdout] | ________^ [INFO] [stdout] 90 | | mob_file, [INFO] [stdout] 91 | | mob: mob_currently_set, [INFO] [stdout] 92 | | template_file, [INFO] [stdout] 93 | | org: coauthors_config.teams, [INFO] [stdout] 94 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 63 | fn head_shorthand(repo: Repository) -> Option { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | / repo.head() [INFO] [stdout] 65 | | .ok() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/picker.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 33 | fn dialog(view: ScrollView, coauthors: Team, write: F) -> Dialog [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | / Dialog::around(view) [INFO] [stdout] 38 | | .title("Mob up with") [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/picker.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 33 | fn dialog(view: ScrollView, coauthors: Team, write: F) -> Dialog [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | .button("OK", move |s| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 40 | | s.with_user_data(|mob: &mut CurrentMobInitials| { [INFO] [stdout] 41 | | let ts = trailers(&coauthors, mob); [INFO] [stdout] 42 | | write(output(&ts, mob)) [INFO] [stdout] 43 | | }); [INFO] [stdout] 44 | | s.quit() [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/picker.rs:53:49 [INFO] [stdout] | [INFO] [stdout] 52 | .fold(ListView::new(), |list_view, (initials, coauthor)| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | list_view.child(&coauthor.name, checkbox(mob, initials.to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-git-mob` (lib) due to 6 previous errors [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 76 | let coauthors_file = File::open(coauthors_path).or(Err(EnvError::MissingCoauthorsFile))?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let mob_file = open_read_write(mob_path).expect("mob file error"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let template_file = open_read_write(template_path).expect("template file error"); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let mob: serde_json::Result> = serde_json::from_reader(BufReader::new(&mob_file)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Ok(Env { [INFO] [stdout] | ________^ [INFO] [stdout] 90 | | mob_file, [INFO] [stdout] 91 | | mob: mob_currently_set, [INFO] [stdout] 92 | | template_file, [INFO] [stdout] 93 | | org: coauthors_config.teams, [INFO] [stdout] 94 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 63 | fn head_shorthand(repo: Repository) -> Option { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | / repo.head() [INFO] [stdout] 65 | | .ok() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/picker.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 33 | fn dialog(view: ScrollView, coauthors: Team, write: F) -> Dialog [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | / Dialog::around(view) [INFO] [stdout] 38 | | .title("Mob up with") [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/picker.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 33 | fn dialog(view: ScrollView, coauthors: Team, write: F) -> Dialog [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | .button("OK", move |s| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 40 | | s.with_user_data(|mob: &mut CurrentMobInitials| { [INFO] [stdout] 41 | | let ts = trailers(&coauthors, mob); [INFO] [stdout] 42 | | write(output(&ts, mob)) [INFO] [stdout] 43 | | }); [INFO] [stdout] 44 | | s.quit() [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/picker.rs:53:49 [INFO] [stdout] | [INFO] [stdout] 52 | .fold(ListView::new(), |list_view, (initials, coauthor)| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | list_view.child(&coauthor.name, checkbox(mob, initials.to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-git-mob` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "02ccd41afa2848bfc32f9f86fd2f04a34e308be9629aa160369a475e06bfd951", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "02ccd41afa2848bfc32f9f86fd2f04a34e308be9629aa160369a475e06bfd951", kill_on_drop: false }` [INFO] [stdout] 02ccd41afa2848bfc32f9f86fd2f04a34e308be9629aa160369a475e06bfd951