[INFO] cloning repository https://github.com/codabrink/aquinas [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/codabrink/aquinas" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodabrink%2Faquinas", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodabrink%2Faquinas'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] aee01ce5f322489e198f19ad530ff840380020c1 [INFO] checking codabrink/aquinas/aee01ce5f322489e198f19ad530ff840380020c1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodabrink%2Faquinas" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/codabrink/aquinas on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/codabrink/aquinas [INFO] finished tweaking git repo https://github.com/codabrink/aquinas [INFO] tweaked toml for git repo https://github.com/codabrink/aquinas written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/codabrink/aquinas already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] abc440a4d83c2052f848ec1e67dbfe2c3e9b83a5f89060d0d8802083c625afac [INFO] running `Command { std: "docker" "start" "-a" "abc440a4d83c2052f848ec1e67dbfe2c3e9b83a5f89060d0d8802083c625afac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "abc440a4d83c2052f848ec1e67dbfe2c3e9b83a5f89060d0d8802083c625afac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "abc440a4d83c2052f848ec1e67dbfe2c3e9b83a5f89060d0d8802083c625afac", kill_on_drop: false }` [INFO] [stdout] abc440a4d83c2052f848ec1e67dbfe2c3e9b83a5f89060d0d8802083c625afac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8eddca335f6b9a543f4d21b2914443d4a6322feaea6832fbec8ef255fc1e8a55 [INFO] running `Command { std: "docker" "start" "-a" "8eddca335f6b9a543f4d21b2914443d4a6322feaea6832fbec8ef255fc1e8a55", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking bytemuck v1.16.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking libloading v0.8.4 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling thiserror v1.0.62 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling libdbus-sys v0.2.5 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking ttf-parser v0.24.0 [INFO] [stderr] Checking tiny-skia-path v0.8.4 [INFO] [stderr] Checking symphonia-core v0.5.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling cpal v0.15.3 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling souvlaki v0.6.1 [INFO] [stderr] Checking extended v0.1.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking rb v0.4.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Compiling winit v0.28.7 [INFO] [stderr] Checking symphonia-metadata v0.5.4 [INFO] [stderr] Checking symphonia-codec-alac v0.5.4 [INFO] [stderr] Checking symphonia-codec-pcm v0.5.4 [INFO] [stderr] Checking tiny-skia v0.8.4 [INFO] [stderr] Checking symphonia-codec-aac v0.5.4 [INFO] [stderr] Checking symphonia-codec-adpcm v0.5.4 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking symphonia-utils-xiph v0.5.4 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Checking symphonia-format-caf v0.5.4 [INFO] [stderr] Checking symphonia-format-riff v0.5.4 [INFO] [stderr] Checking symphonia-format-isomp4 v0.5.4 [INFO] [stderr] Checking symphonia-format-mkv v0.5.4 [INFO] [stderr] Checking symphonia-codec-vorbis v0.5.4 [INFO] [stderr] Checking symphonia-bundle-flac v0.5.4 [INFO] [stderr] Checking symphonia-format-ogg v0.5.4 [INFO] [stderr] Checking owned_ttf_parser v0.24.0 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking ab_glyph v0.2.28 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking dbus v0.9.7 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking alsa v0.9.0 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking symphonia v0.5.4 [INFO] [stderr] Compiling thiserror-impl v1.0.62 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Checking tui v0.19.0 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking dbus-crossroads v0.5.2 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking sctk-adwaita v0.5.4 [INFO] [stderr] Checking aquinas v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `flush` is never used [INFO] [stdout] --> src/backends/symphonia_backend.rs:253:6 [INFO] [stdout] | [INFO] [stdout] 251 | pub trait AudioOutput { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] 252 | fn write(&mut self, decoded: AudioBufferRef<'_>) -> Result<()>; [INFO] [stdout] 253 | fn flush(&mut self); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends/symphonia_backend.rs:312:8 [INFO] [stdout] | [INFO] [stdout] 289 | let sample_buf = SampleBuffer::::new(duration, spec); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | let ring_buf = SpscRb::new(ring_len); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | let (ring_buf_tx, ring_buf_rx) = (ring_buf.producer(), ring_buf.consumer()); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | [INFO] [stdout] 300 | let stream = device.build_output_stream( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | Ok(Box::new(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 313 | | ring_buf_tx, [INFO] [stdout] 314 | | sample_buf, [INFO] [stdout] 315 | | stream, [INFO] [stdout] 316 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:134:15 [INFO] [stdout] | [INFO] [stdout] 125 | let mut stack = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | config: Config::load().unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:280:14 [INFO] [stdout] | [INFO] [stdout] 235 | pub fn new(path: impl AsRef) -> Arc { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let (files, folders) = match path.is_dir() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | true => { [INFO] [stdout] 243 | let mut files = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | if let Ok(paths) = fs::read_dir(&path) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | for entry in paths { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | Arc::new(Self { [INFO] [stdout] | ______________^ [INFO] [stdout] 281 | | path, [INFO] [stdout] 282 | | name_search: searchify(&name), [INFO] [stdout] 283 | | sort_key: name.to_lowercase(), [INFO] [stdout] ... | [INFO] [stdout] 289 | | metadata, [INFO] [stdout] 290 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `flush` is never used [INFO] [stdout] --> src/backends/symphonia_backend.rs:253:6 [INFO] [stdout] | [INFO] [stdout] 251 | pub trait AudioOutput { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] 252 | fn write(&mut self, decoded: AudioBufferRef<'_>) -> Result<()>; [INFO] [stdout] 253 | fn flush(&mut self); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aquinas` (bin "aquinas" test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends/symphonia_backend.rs:312:8 [INFO] [stdout] | [INFO] [stdout] 289 | let sample_buf = SampleBuffer::::new(duration, spec); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | let ring_buf = SpscRb::new(ring_len); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | let (ring_buf_tx, ring_buf_rx) = (ring_buf.producer(), ring_buf.consumer()); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | [INFO] [stdout] 300 | let stream = device.build_output_stream( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | Ok(Box::new(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 313 | | ring_buf_tx, [INFO] [stdout] 314 | | sample_buf, [INFO] [stdout] 315 | | stream, [INFO] [stdout] 316 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:134:15 [INFO] [stdout] | [INFO] [stdout] 125 | let mut stack = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | config: Config::load().unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:280:14 [INFO] [stdout] | [INFO] [stdout] 235 | pub fn new(path: impl AsRef) -> Arc { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let (files, folders) = match path.is_dir() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | true => { [INFO] [stdout] 243 | let mut files = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | if let Ok(paths) = fs::read_dir(&path) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | for entry in paths { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | Arc::new(Self { [INFO] [stdout] | ______________^ [INFO] [stdout] 281 | | path, [INFO] [stdout] 282 | | name_search: searchify(&name), [INFO] [stdout] 283 | | sort_key: name.to_lowercase(), [INFO] [stdout] ... | [INFO] [stdout] 289 | | metadata, [INFO] [stdout] 290 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aquinas` (bin "aquinas") due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "8eddca335f6b9a543f4d21b2914443d4a6322feaea6832fbec8ef255fc1e8a55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8eddca335f6b9a543f4d21b2914443d4a6322feaea6832fbec8ef255fc1e8a55", kill_on_drop: false }` [INFO] [stdout] 8eddca335f6b9a543f4d21b2914443d4a6322feaea6832fbec8ef255fc1e8a55