[INFO] cloning repository https://github.com/cnxfgit/lsm-rust-learn [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cnxfgit/lsm-rust-learn" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcnxfgit%2Flsm-rust-learn", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcnxfgit%2Flsm-rust-learn'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9549294ba304684b8afa6ee9dbc29e0ee19e0dda [INFO] checking cnxfgit/lsm-rust-learn/9549294ba304684b8afa6ee9dbc29e0ee19e0dda against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcnxfgit%2Flsm-rust-learn" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cnxfgit/lsm-rust-learn on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cnxfgit/lsm-rust-learn [INFO] finished tweaking git repo https://github.com/cnxfgit/lsm-rust-learn [INFO] tweaked toml for git repo https://github.com/cnxfgit/lsm-rust-learn written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cnxfgit/lsm-rust-learn already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9bfebd9e98453bfdaf93f6c6e6b8fbd49cf39eccce95022438d49b37d0d7fa64 [INFO] running `Command { std: "docker" "start" "-a" "9bfebd9e98453bfdaf93f6c6e6b8fbd49cf39eccce95022438d49b37d0d7fa64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9bfebd9e98453bfdaf93f6c6e6b8fbd49cf39eccce95022438d49b37d0d7fa64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9bfebd9e98453bfdaf93f6c6e6b8fbd49cf39eccce95022438d49b37d0d7fa64", kill_on_drop: false }` [INFO] [stdout] 9bfebd9e98453bfdaf93f6c6e6b8fbd49cf39eccce95022438d49b37d0d7fa64 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ed0b49e6a0f7519eff0663dbaee9e040bb2dfe03cacad264439250b927dfce7a [INFO] running `Command { std: "docker" "start" "-a" "ed0b49e6a0f7519eff0663dbaee9e040bb2dfe03cacad264439250b927dfce7a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.74 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking raw-cpuid v10.7.0 [INFO] [stderr] Compiling moka v0.9.9 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking aliasable v0.1.3 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking tagptr v0.2.0 [INFO] [stderr] Checking triomphe v0.1.11 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking arc-swap v1.6.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Checking crossbeam-channel v0.5.10 [INFO] [stderr] Compiling syn v2.0.46 [INFO] [stderr] Checking crossbeam-skiplist v0.1.2 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking quanta v0.11.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking uuid v1.6.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling ouroboros_macro v0.15.6 [INFO] [stderr] Checking ouroboros v0.15.6 [INFO] [stderr] Checking lsm-rust-learn v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterators/merge_iterator.rs:72:22 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn create(iters: Vec>) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut heap = BinaryHeap::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let current = heap.pop().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | current: Some(current), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsm_storage.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | inner: Arc::new(RwLock::new(Arc::new(LsmStorageInner::create()))), [INFO] [stdout] 58 | | flush_lock: Mutex::new(()), [INFO] [stdout] 59 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 60 | | block_cache: Arc::new(BlockCache::new(1 << 20)), // 4GB block cache [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsm_storage.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 66 | let snapshot = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let guard = self.inner.read(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let mut iters = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let iter = MergeIterator::create(iters); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsm_storage.rs:224:12 [INFO] [stdout] | [INFO] [stdout] 188 | let snapshot = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let guard = self.inner.read(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let mut memtable_iters = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let memtable_iter = MergeIterator::create(memtable_iters); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | [INFO] [stdout] 201 | let mut table_iters = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | let table_iter = MergeIterator::create(table_iters); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | [INFO] [stdout] 222 | let iter = TwoMergeIterator::create(memtable_iter, table_iter)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | Ok(FusedIterator::new(LsmIterator::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 225 | | iter, [INFO] [stdout] 226 | | map_bound(upper), [INFO] [stdout] 227 | | )?)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:50:43 [INFO] [stdout] | [INFO] [stdout] 47 | let (lower, upper) = (map_bound(lower), map_bound(upper)); [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | iter_builder: |map| map.range((lower, upper)), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:54:79 [INFO] [stdout] | [INFO] [stdout] 54 | let entry = iter.with_iter_mut(|iter| MemTableIterator::entry_to_item(iter.next())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 82 | fn entry_to_item(entry: Option>) -> (Bytes, Bytes) { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | / entry [INFO] [stdout] 84 | | .map(|x| (x.key().clone(), x.value().clone())) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:84:23 [INFO] [stdout] | [INFO] [stdout] 84 | .map(|x| (x.key().clone(), x.value().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:84:40 [INFO] [stdout] | [INFO] [stdout] 84 | .map(|x| (x.key().clone(), x.value().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:85:33 [INFO] [stdout] | [INFO] [stdout] 85 | .unwrap_or_else(|| (Bytes::from_static(&[]), Bytes::from_static(&[]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:85:58 [INFO] [stdout] | [INFO] [stdout] 85 | .unwrap_or_else(|| (Bytes::from_static(&[]), Bytes::from_static(&[]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:103:79 [INFO] [stdout] | [INFO] [stdout] 103 | let entry = self.with_iter_mut(|iter| MemTableIterator::entry_to_item(iter.next())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn open(id: usize, block_cache: Option>, file: FileObject) -> Result { [INFO] [stdout] | ------------------------------------ ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 121 | | file, [INFO] [stdout] 122 | | block_metas: BlockMeta::decode_block_meta(&raw_meta[..]), [INFO] [stdout] 123 | | block_meta_offset: block_meta_offset as usize, [INFO] [stdout] 124 | | id, [INFO] [stdout] 125 | | block_cache, [INFO] [stdout] 126 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 139 | Ok(Arc::new(Block::decode(&block_data[..]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/builder.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 70 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | id: usize, [INFO] [stdout] 72 | block_cache: Option>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let file = FileObject::create(path.as_ref(), buf)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | [INFO] [stdout] 82 | Ok(SsTable { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | file, [INFO] [stdout] 84 | | block_metas: self.meta, [INFO] [stdout] 85 | | block_meta_offset: meta_offset, [INFO] [stdout] 86 | | id, [INFO] [stdout] 87 | | block_cache, [INFO] [stdout] 88 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/iterator.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 44 | let mut block_iter = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok((block_idx, block_iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lsm-rust-learn` (lib) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterators/merge_iterator.rs:72:22 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn create(iters: Vec>) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut heap = BinaryHeap::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let current = heap.pop().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | current: Some(current), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsm_storage.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | inner: Arc::new(RwLock::new(Arc::new(LsmStorageInner::create()))), [INFO] [stdout] 58 | | flush_lock: Mutex::new(()), [INFO] [stdout] 59 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 60 | | block_cache: Arc::new(BlockCache::new(1 << 20)), // 4GB block cache [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsm_storage.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 66 | let snapshot = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let guard = self.inner.read(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let mut iters = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let iter = MergeIterator::create(iters); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsm_storage.rs:224:12 [INFO] [stdout] | [INFO] [stdout] 188 | let snapshot = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let guard = self.inner.read(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let mut memtable_iters = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let memtable_iter = MergeIterator::create(memtable_iters); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | [INFO] [stdout] 201 | let mut table_iters = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | let table_iter = MergeIterator::create(table_iters); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | [INFO] [stdout] 222 | let iter = TwoMergeIterator::create(memtable_iter, table_iter)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | Ok(FusedIterator::new(LsmIterator::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 225 | | iter, [INFO] [stdout] 226 | | map_bound(upper), [INFO] [stdout] 227 | | )?)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:50:43 [INFO] [stdout] | [INFO] [stdout] 47 | let (lower, upper) = (map_bound(lower), map_bound(upper)); [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | iter_builder: |map| map.range((lower, upper)), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:54:79 [INFO] [stdout] | [INFO] [stdout] 54 | let entry = iter.with_iter_mut(|iter| MemTableIterator::entry_to_item(iter.next())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 82 | fn entry_to_item(entry: Option>) -> (Bytes, Bytes) { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | / entry [INFO] [stdout] 84 | | .map(|x| (x.key().clone(), x.value().clone())) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:84:23 [INFO] [stdout] | [INFO] [stdout] 84 | .map(|x| (x.key().clone(), x.value().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:84:40 [INFO] [stdout] | [INFO] [stdout] 84 | .map(|x| (x.key().clone(), x.value().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:85:33 [INFO] [stdout] | [INFO] [stdout] 85 | .unwrap_or_else(|| (Bytes::from_static(&[]), Bytes::from_static(&[]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:85:58 [INFO] [stdout] | [INFO] [stdout] 85 | .unwrap_or_else(|| (Bytes::from_static(&[]), Bytes::from_static(&[]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:103:79 [INFO] [stdout] | [INFO] [stdout] 103 | let entry = self.with_iter_mut(|iter| MemTableIterator::entry_to_item(iter.next())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:111:23 [INFO] [stdout] | [INFO] [stdout] 110 | pub(crate) fn open_for_test(file: FileObject) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Self::open(0, None, file) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn open(id: usize, block_cache: Option>, file: FileObject) -> Result { [INFO] [stdout] | ------------------------------------ ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 121 | | file, [INFO] [stdout] 122 | | block_metas: BlockMeta::decode_block_meta(&raw_meta[..]), [INFO] [stdout] 123 | | block_meta_offset: block_meta_offset as usize, [INFO] [stdout] 124 | | id, [INFO] [stdout] 125 | | block_cache, [INFO] [stdout] 126 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 139 | Ok(Arc::new(Block::decode(&block_data[..]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/builder.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 70 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | id: usize, [INFO] [stdout] 72 | block_cache: Option>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let file = FileObject::create(path.as_ref(), buf)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | [INFO] [stdout] 82 | Ok(SsTable { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | file, [INFO] [stdout] 84 | | block_metas: self.meta, [INFO] [stdout] 85 | | block_meta_offset: meta_offset, [INFO] [stdout] 86 | | id, [INFO] [stdout] 87 | | block_cache, [INFO] [stdout] 88 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/builder.rs:93:23 [INFO] [stdout] | [INFO] [stdout] 92 | pub(crate) fn build_for_test(self, path: impl AsRef) -> Result { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | self.build(0, None, path) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/iterator.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 44 | let mut block_iter = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok((block_idx, block_iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/tests.rs:53:11 [INFO] [stdout] | [INFO] [stdout] 45 | let mut builder = SsTableBuilder::new(128); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let dir = tempdir().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let path = dir.path().join("1.sst"); [INFO] [stdout] 53 | (dir, builder.build_for_test(path).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lsm-rust-learn` (lib test) due to 20 previous errors [INFO] running `Command { std: "docker" "inspect" "ed0b49e6a0f7519eff0663dbaee9e040bb2dfe03cacad264439250b927dfce7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed0b49e6a0f7519eff0663dbaee9e040bb2dfe03cacad264439250b927dfce7a", kill_on_drop: false }` [INFO] [stdout] ed0b49e6a0f7519eff0663dbaee9e040bb2dfe03cacad264439250b927dfce7a