[INFO] cloning repository https://github.com/cmsd2/kvs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cmsd2/kvs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcmsd2%2Fkvs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcmsd2%2Fkvs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0d0b269a626f74db077e6a9b81dc924762c64c28 [INFO] checking cmsd2/kvs/0d0b269a626f74db077e6a9b81dc924762c64c28 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcmsd2%2Fkvs" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cmsd2/kvs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cmsd2/kvs [INFO] finished tweaking git repo https://github.com/cmsd2/kvs [INFO] tweaked toml for git repo https://github.com/cmsd2/kvs written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cmsd2/kvs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dbf06d148477c9fe73936100ed71c2c8bc9c9a1d96a40a18415a6ac795dc6558 [INFO] running `Command { std: "docker" "start" "-a" "dbf06d148477c9fe73936100ed71c2c8bc9c9a1d96a40a18415a6ac795dc6558", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dbf06d148477c9fe73936100ed71c2c8bc9c9a1d96a40a18415a6ac795dc6558", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dbf06d148477c9fe73936100ed71c2c8bc9c9a1d96a40a18415a6ac795dc6558", kill_on_drop: false }` [INFO] [stdout] dbf06d148477c9fe73936100ed71c2c8bc9c9a1d96a40a18415a6ac795dc6558 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8ace67098ff95bcd4cc567089a333ef9efc51cda2d3092cdf0af0aa6c4b15ca7 [INFO] running `Command { std: "docker" "start" "-a" "8ace67098ff95bcd4cc567089a333ef9efc51cda2d3092cdf0af0aa6c4b15ca7", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.4 [INFO] [stderr] Compiling syn v0.15.36 [INFO] [stderr] Compiling libc v0.2.58 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling serde v1.0.92 [INFO] [stderr] Compiling cc v1.0.37 [INFO] [stderr] Compiling ryu v0.2.8 [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Compiling regex v1.1.7 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking rustc-demangle v0.1.15 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking utf8-ranges v1.0.3 [INFO] [stderr] Checking regex-syntax v0.6.7 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Compiling backtrace v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking walkdir v2.2.8 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Checking aho-corasick v0.7.3 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking tempfile v3.0.8 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Compiling serde_derive v1.0.92 [INFO] [stderr] Checking predicates v1.0.1 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking serde_json v1.0.39 [INFO] [stderr] Checking escargot v0.4.0 [INFO] [stderr] Checking kvs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/result.rs:56:32 [INFO] [stdout] | [INFO] [stdout] 56 | fn cause(&self) -> Option<&Fail> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 56 | fn cause(&self) -> Option<&dyn Fail> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:133:40 [INFO] [stdout] | [INFO] [stdout] 133 | |offset| offset.map_or(Ok(None), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 165 | let mut kvdbs = BTreeMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let (id,file) = parts.create()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | let kvdb = KvDb::new(file)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | Ok(KvStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 186 | | parts: parts, [INFO] [stdout] 187 | | current_part: current_id, [INFO] [stdout] 188 | | kvdbs: kvdbs, [INFO] [stdout] ... | [INFO] [stdout] 192 | | [INFO] [stdout] 193 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:289:12 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn copy(&mut self, dest_part: Id, dest: KvDb) -> Result<(OffsetIndex, KvDb)> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | let mut index = Some(self.store.clone()); [INFO] [stdout] 273 | let mut dest = Some(dest); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | Ok((index.unwrap(), dest.unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 44 | fn from(kind: KvsErrorKind) -> KvsError { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | KvsError { inner: Context::new(kind) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kvdb.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(file: File) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Ok(KvDb { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | parser: Parser, [INFO] [stdout] 49 | | logdb: LogDb::new(file)?, [INFO] [stdout] 50 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logdb.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(f: File) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Ok(LogDb { [INFO] [stdout] | ____________^ [INFO] [stdout] 20 | | f: f, [INFO] [stdout] 21 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parts.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 37 | let f = OpenOptions::new() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok((id,f)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8ace67098ff95bcd4cc567089a333ef9efc51cda2d3092cdf0af0aa6c4b15ca7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ace67098ff95bcd4cc567089a333ef9efc51cda2d3092cdf0af0aa6c4b15ca7", kill_on_drop: false }` [INFO] [stdout] 8ace67098ff95bcd4cc567089a333ef9efc51cda2d3092cdf0af0aa6c4b15ca7