[INFO] cloning repository https://github.com/clokken/hpi-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/clokken/hpi-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fclokken%2Fhpi-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fclokken%2Fhpi-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0413bcd6c91461b310eb2ec50e3b8624df78b7ec [INFO] checking clokken/hpi-rs/0413bcd6c91461b310eb2ec50e3b8624df78b7ec against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fclokken%2Fhpi-rs" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/clokken/hpi-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/clokken/hpi-rs [INFO] finished tweaking git repo https://github.com/clokken/hpi-rs [INFO] tweaked toml for git repo https://github.com/clokken/hpi-rs written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/clokken/hpi-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 000b313e182e4f02706328c85be866f6e9f8de9fa8ed4a3a0926625d52e03e99 [INFO] running `Command { std: "docker" "start" "-a" "000b313e182e4f02706328c85be866f6e9f8de9fa8ed4a3a0926625d52e03e99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "000b313e182e4f02706328c85be866f6e9f8de9fa8ed4a3a0926625d52e03e99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "000b313e182e4f02706328c85be866f6e9f8de9fa8ed4a3a0926625d52e03e99", kill_on_drop: false }` [INFO] [stdout] 000b313e182e4f02706328c85be866f6e9f8de9fa8ed4a3a0926625d52e03e99 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 11a11b8e4aaf21ed3ad74a644494a74be18ed6e3f470a6aaf7d6df3220b17aec [INFO] running `Command { std: "docker" "start" "-a" "11a11b8e4aaf21ed3ad74a644494a74be18ed6e3f470a6aaf7d6df3220b17aec", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking glob-match v0.2.1 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking hpi v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `next_size` [INFO] [stdout] --> src/hpi_context.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | let next_size = buffer_utils::decompress_buffer(sqsh_buffer, &chunk_data, &mut result)?; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_next_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next_size` [INFO] [stdout] --> src/hpi_context.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | let next_size = buffer_utils::decompress_buffer(sqsh_buffer, &chunk_data, &mut result)?; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_next_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `directories_buffer` and `names_buffer` are never read [INFO] [stdout] --> src/hpi_context.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct HpiContext<'a> { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 4 | full_data: &'a [u8], [INFO] [stdout] 5 | directories_buffer: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 6 | names_buffer: Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `directories_buffer` and `names_buffer` are never read [INFO] [stdout] --> src/hpi_context.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct HpiContext<'a> { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 4 | full_data: &'a [u8], [INFO] [stdout] 5 | directories_buffer: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 6 | names_buffer: Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `options` [INFO] [stdout] --> src/cli/operations/extract.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn extract(options: &ExtractOptions) -> Result<(), CliError> { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_options` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `options` [INFO] [stdout] --> src/cli/operations/extract.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn extract(options: &ExtractOptions) -> Result<(), CliError> { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_options` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sub_args` [INFO] [stdout] --> src/cli/cli_parsers/parse_extract.rs:3:22 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn parse_extract(sub_args: &[String]) -> Result { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sub_args` [INFO] [stdout] --> src/cli/cli_parsers/parse_extract.rs:3:22 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn parse_extract(sub_args: &[String]) -> Result { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `BadCommand` and `Unknown` are never constructed [INFO] [stdout] --> src/cli/cli_error.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub enum CliError { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] 5 | IoError(String), [INFO] [stdout] 6 | BadCommand(String), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 7 | HpiError(HpiError), [INFO] [stdout] 8 | Unknown(), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CliError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Extract` is never constructed [INFO] [stdout] --> src/cli/cli_operation.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub enum CliOperation { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 4 | List(ListOptions), [INFO] [stdout] 5 | Extract(ExtractOptions), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `input_hpi_path`, `files`, `out_path`, and `force` are never read [INFO] [stdout] --> src/cli/operations/extract.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct ExtractOptions { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 4 | pub input_hpi_path: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 5 | pub files: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 6 | pub out_path: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | pub force: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `write_bytes_to_file` is never used [INFO] [stdout] --> src/cli/file_utils.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn write_bytes_to_file(file_path: &str, data: &[u8]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `BadCommand` and `Unknown` are never constructed [INFO] [stdout] --> src/cli/cli_error.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub enum CliError { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] 5 | IoError(String), [INFO] [stdout] 6 | BadCommand(String), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 7 | HpiError(HpiError), [INFO] [stdout] 8 | Unknown(), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CliError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Extract` is never constructed [INFO] [stdout] --> src/cli/cli_operation.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub enum CliOperation { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 4 | List(ListOptions), [INFO] [stdout] 5 | Extract(ExtractOptions), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `input_hpi_path`, `files`, `out_path`, and `force` are never read [INFO] [stdout] --> src/cli/operations/extract.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct ExtractOptions { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 4 | pub input_hpi_path: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 5 | pub files: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 6 | pub out_path: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | pub force: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `write_bytes_to_file` is never used [INFO] [stdout] --> src/cli/file_utils.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn write_bytes_to_file(file_path: &str, data: &[u8]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/cli_parsers/parse_list.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 13 | let mut match_regex: Option = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let options = ListOptions { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(CliOperation::List(options)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/cli_parsers/parse_list.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 13 | let mut match_regex: Option = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let options = ListOptions { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(CliOperation::List(options)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hpi` (bin "hpi") due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `hpi` (bin "hpi" test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "11a11b8e4aaf21ed3ad74a644494a74be18ed6e3f470a6aaf7d6df3220b17aec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11a11b8e4aaf21ed3ad74a644494a74be18ed6e3f470a6aaf7d6df3220b17aec", kill_on_drop: false }` [INFO] [stdout] 11a11b8e4aaf21ed3ad74a644494a74be18ed6e3f470a6aaf7d6df3220b17aec