[INFO] cloning repository https://github.com/cjwcommuny/toy-paxos-classic [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cjwcommuny/toy-paxos-classic" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcjwcommuny%2Ftoy-paxos-classic", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcjwcommuny%2Ftoy-paxos-classic'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 89425ebb04d8ea6844f3a8eb5b66402d62964e2d [INFO] checking cjwcommuny/toy-paxos-classic/89425ebb04d8ea6844f3a8eb5b66402d62964e2d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcjwcommuny%2Ftoy-paxos-classic" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cjwcommuny/toy-paxos-classic on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cjwcommuny/toy-paxos-classic [INFO] finished tweaking git repo https://github.com/cjwcommuny/toy-paxos-classic [INFO] tweaked toml for git repo https://github.com/cjwcommuny/toy-paxos-classic written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cjwcommuny/toy-paxos-classic already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 122ab6c184e504f768439ef5b1d05aacfb948847de8f70b5045f291ac7c043b9 [INFO] running `Command { std: "docker" "start" "-a" "122ab6c184e504f768439ef5b1d05aacfb948847de8f70b5045f291ac7c043b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "122ab6c184e504f768439ef5b1d05aacfb948847de8f70b5045f291ac7c043b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "122ab6c184e504f768439ef5b1d05aacfb948847de8f70b5045f291ac7c043b9", kill_on_drop: false }` [INFO] [stdout] 122ab6c184e504f768439ef5b1d05aacfb948847de8f70b5045f291ac7c043b9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 92e46236c1123cf6ca64101619a9d0973b94aacf686bc12dc3f32de3d31a06fd [INFO] running `Command { std: "docker" "start" "-a" "92e46236c1123cf6ca64101619a9d0973b94aacf686bc12dc3f32de3d31a06fd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.73 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling thiserror v1.0.53 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling quote v1.0.34 [INFO] [stderr] Compiling syn v2.0.44 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling getset v0.1.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.53 [INFO] [stderr] Compiling derive-new v0.6.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking paxos-classic v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `ReadResponse` is more private than the item `ReadClient::Stream` [INFO] [stdout] --> src/alpha.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 175 | type Stream: Stream, Self::Error>>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated type `ReadClient::Stream` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `ReadResponse` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/alpha.rs:163:1 [INFO] [stdout] | [INFO] [stdout] 163 | struct ReadResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `WriteResponse` is more private than the item `WriteClient::Stream` [INFO] [stdout] --> src/alpha.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | type Stream: Stream>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated type `WriteClient::Stream` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `WriteResponse` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/alpha.rs:168:1 [INFO] [stdout] | [INFO] [stdout] 168 | struct WriteResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Value` is more private than the item `WriteClient::broadcast_write` [INFO] [stdout] --> src/alpha.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | fn broadcast_write(&self, value: Value) -> Self::Stream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `WriteClient::broadcast_write` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `Value` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/alpha.rs:118:1 [INFO] [stdout] | [INFO] [stdout] 118 | struct Value { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `read` and `write` are never used [INFO] [stdout] --> src/alpha.rs:90:8 [INFO] [stdout] | [INFO] [stdout] 14 | / impl Alpha [INFO] [stdout] 15 | | where [INFO] [stdout] 16 | | V: Clone, [INFO] [stdout] | |_____________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 90 | fn read(&mut self, round: Round) -> ReadResponse { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 98 | fn write(&mut self, value: Value) -> WriteResponse { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `last_round_with_write` is never read [INFO] [stdout] --> src/alpha.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 118 | struct Value { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 119 | value: V, [INFO] [stdout] 120 | last_round_with_write: Round, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Value` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `round` is never read [INFO] [stdout] --> src/alpha.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 168 | struct WriteResponse { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 169 | round: Round, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Proposer` is never constructed [INFO] [stdout] --> src/proposer.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | struct Proposer { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `propose` is never used [INFO] [stdout] --> src/proposer.rs:16:14 [INFO] [stdout] | [INFO] [stdout] 10 | / impl Proposer [INFO] [stdout] 11 | | where [INFO] [stdout] 12 | | V: Clone, [INFO] [stdout] 13 | | D: FailureDetector, [INFO] [stdout] 14 | | P: WriteClient + ReadClient + Quorum, [INFO] [stdout] | |_______________________________________________- method in this implementation [INFO] [stdout] 15 | { [INFO] [stdout] 16 | async fn propose(&mut self, value: V) -> V { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `FailureDetector` is never used [INFO] [stdout] --> src/proposer.rs:32:7 [INFO] [stdout] | [INFO] [stdout] 32 | trait FailureDetector { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ReadResponse` is more private than the item `ReadClient::Stream` [INFO] [stdout] --> src/alpha.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 175 | type Stream: Stream, Self::Error>>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated type `ReadClient::Stream` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `ReadResponse` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/alpha.rs:163:1 [INFO] [stdout] | [INFO] [stdout] 163 | struct ReadResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha.rs:36:40 [INFO] [stdout] | [INFO] [stdout] 36 | .filter_map(|result| ready(result.ok())) [INFO] [stdout] | ------ ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `WriteResponse` is more private than the item `WriteClient::Stream` [INFO] [stdout] --> src/alpha.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | type Stream: Stream>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated type `WriteClient::Stream` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `WriteResponse` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/alpha.rs:168:1 [INFO] [stdout] | [INFO] [stdout] 168 | struct WriteResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Value` is more private than the item `WriteClient::broadcast_write` [INFO] [stdout] --> src/alpha.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | fn broadcast_write(&self, value: Value) -> Self::Stream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `WriteClient::broadcast_write` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `Value` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/alpha.rs:118:1 [INFO] [stdout] | [INFO] [stdout] 118 | struct Value { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `read` and `write` are never used [INFO] [stdout] --> src/alpha.rs:90:8 [INFO] [stdout] | [INFO] [stdout] 14 | / impl Alpha [INFO] [stdout] 15 | | where [INFO] [stdout] 16 | | V: Clone, [INFO] [stdout] | |_____________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 90 | fn read(&mut self, round: Round) -> ReadResponse { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 98 | fn write(&mut self, value: Value) -> WriteResponse { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `last_round_with_write` is never read [INFO] [stdout] --> src/alpha.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 118 | struct Value { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 119 | value: V, [INFO] [stdout] 120 | last_round_with_write: Round, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Value` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `round` is never read [INFO] [stdout] --> src/alpha.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 168 | struct WriteResponse { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 169 | round: Round, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Proposer` is never constructed [INFO] [stdout] --> src/proposer.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | struct Proposer { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `propose` is never used [INFO] [stdout] --> src/proposer.rs:16:14 [INFO] [stdout] | [INFO] [stdout] 10 | / impl Proposer [INFO] [stdout] 11 | | where [INFO] [stdout] 12 | | V: Clone, [INFO] [stdout] 13 | | D: FailureDetector, [INFO] [stdout] 14 | | P: WriteClient + ReadClient + Quorum, [INFO] [stdout] | |_______________________________________________- method in this implementation [INFO] [stdout] 15 | { [INFO] [stdout] 16 | async fn propose(&mut self, value: V) -> V { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `FailureDetector` is never used [INFO] [stdout] --> src/proposer.rs:32:7 [INFO] [stdout] | [INFO] [stdout] 32 | trait FailureDetector { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha.rs:36:40 [INFO] [stdout] | [INFO] [stdout] 36 | .filter_map(|result| ready(result.ok())) [INFO] [stdout] | ------ ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `paxos-classic` (lib test) due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `paxos-classic` (lib) due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "92e46236c1123cf6ca64101619a9d0973b94aacf686bc12dc3f32de3d31a06fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92e46236c1123cf6ca64101619a9d0973b94aacf686bc12dc3f32de3d31a06fd", kill_on_drop: false }` [INFO] [stdout] 92e46236c1123cf6ca64101619a9d0973b94aacf686bc12dc3f32de3d31a06fd