[INFO] cloning repository https://github.com/cjkenn/kolga [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cjkenn/kolga" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcjkenn%2Fkolga", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcjkenn%2Fkolga'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7997d30a823e26ac2e79a6b0f5a42ce4388b28ac [INFO] checking cjkenn/kolga/7997d30a823e26ac2e79a6b0f5a42ce4388b28ac against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcjkenn%2Fkolga" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cjkenn/kolga on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cjkenn/kolga [INFO] finished tweaking git repo https://github.com/cjkenn/kolga [INFO] tweaked toml for git repo https://github.com/cjkenn/kolga written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cjkenn/kolga already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b875cc8101a14406a12d94da9cacfc13513130cc397963a026f80d3b2e8a2a13 [INFO] running `Command { std: "docker" "start" "-a" "b875cc8101a14406a12d94da9cacfc13513130cc397963a026f80d3b2e8a2a13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b875cc8101a14406a12d94da9cacfc13513130cc397963a026f80d3b2e8a2a13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b875cc8101a14406a12d94da9cacfc13513130cc397963a026f80d3b2e8a2a13", kill_on_drop: false }` [INFO] [stdout] b875cc8101a14406a12d94da9cacfc13513130cc397963a026f80d3b2e8a2a13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f86e87c845d210e341c86afce39b03136ab7bc6ef3a87134614ce478cb193e7 [INFO] running `Command { std: "docker" "start" "-a" "0f86e87c845d210e341c86afce39b03136ab7bc6ef3a87134614ce478cb193e7", kill_on_drop: false }` [INFO] [stderr] Checking kolgac_errors v0.1.0 (/opt/rustwide/workdir/kolgac_errors) [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling proc-macro2 v1.0.12 [INFO] [stderr] Compiling lazy_static v1.0.2 [INFO] [stderr] Compiling libc v0.2.70 [INFO] [stderr] Compiling syn v1.0.21 [INFO] [stderr] Compiling regex-syntax v0.6.18 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling thread_local v1.0.1 [INFO] [stderr] Checking kolgac v0.1.0 (/opt/rustwide/workdir/kolgac) [INFO] [stderr] Compiling aho-corasick v0.7.13 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> kolgac/src/parser.rs:152:18 [INFO] [stdout] | [INFO] [stdout] 121 | let mut stmts: Vec = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let mut cctx = ClassContext::new(HashMap::new(), Vec::new()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let head = Ast::Prog { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | ast: Some(head), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> kolgac/src/parser.rs:504:12 [INFO] [stdout] | [INFO] [stdout] 478 | let fn_sym = Sym::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 492 | let fn_body = self.block_stmt(pctx)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 493 | let new_sym = Sym::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | Ok(Ast::FnDeclStmt { [INFO] [stdout] | ____________^ [INFO] [stdout] 505 | | meta: MetaAst::new(self.next(), fn_ident_tkn.line, fn_ident_tkn.pos), [INFO] [stdout] 506 | | ident_tkn: fn_ident_tkn, [INFO] [stdout] 507 | | fn_params: params, [INFO] [stdout] ... | [INFO] [stdout] 510 | | sc: self.symtab.finalized_level, [INFO] [stdout] 511 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> kolgac/src/parser.rs:633:12 [INFO] [stdout] | [INFO] [stdout] 617 | let mut stmts = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 633 | Ok(Ast::BlckStmt { [INFO] [stdout] | ____________^ [INFO] [stdout] 634 | | meta: MetaAst::new(self.next(), self.currtkn.line, self.currtkn.pos), [INFO] [stdout] 635 | | stmts: stmts, [INFO] [stdout] 636 | | sc: sc_lvl, [INFO] [stdout] 637 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> kolgac/src/parser.rs:680:12 [INFO] [stdout] | [INFO] [stdout] 647 | let if_cond = self.expr(pctx)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 648 | let if_blck = self.block_stmt(pctx)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 649 | let mut else_blck = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 650 | let mut else_ifs = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 680 | Ok(Ast::IfStmt { [INFO] [stdout] | ____________^ [INFO] [stdout] 681 | | meta: MetaAst::new(self.next(), ast_line, ast_pos), [INFO] [stdout] 682 | | cond_expr: Box::new(if_cond), [INFO] [stdout] 683 | | if_stmts: Box::new(if_blck), [INFO] [stdout] 684 | | elif_exprs: else_ifs, [INFO] [stdout] 685 | | el_stmts: else_blck, [INFO] [stdout] 686 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> kolgac/src/parser.rs:698:12 [INFO] [stdout] | [INFO] [stdout] 695 | let while_cond = self.expr(pctx)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 696 | let while_stmts = self.block_stmt(pctx)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 697 | [INFO] [stdout] 698 | Ok(Ast::WhileStmt { [INFO] [stdout] | ____________^ [INFO] [stdout] 699 | | meta: MetaAst::new(self.next(), ast_line, ast_pos), [INFO] [stdout] 700 | | cond_expr: Box::new(while_cond), [INFO] [stdout] 701 | | stmts: Box::new(while_stmts), [INFO] [stdout] 702 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> kolgac/src/parser.rs:743:12 [INFO] [stdout] | [INFO] [stdout] 710 | let mut for_var_decl = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 711 | let mut for_var_cond = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 712 | let mut for_incr_expr = None; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 741 | let for_stmt = self.block_stmt(pctx)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 742 | [INFO] [stdout] 743 | Ok(Ast::ForStmt { [INFO] [stdout] | ____________^ [INFO] [stdout] 744 | | meta: MetaAst::new(self.next(), ast_line, ast_pos), [INFO] [stdout] 745 | | for_var_decl: Box::new(for_var_decl.unwrap()), [INFO] [stdout] 746 | | for_cond_expr: Box::new(for_var_cond.unwrap()), [INFO] [stdout] 747 | | for_step_expr: Box::new(for_incr_expr.unwrap()), [INFO] [stdout] 748 | | stmts: Box::new(for_stmt), [INFO] [stdout] 749 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> kolgac/src/parser.rs:783:12 [INFO] [stdout] | [INFO] [stdout] 780 | let expr = self.expr(pctx)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 783 | Ok(Ast::ExprStmt { [INFO] [stdout] | ____________^ [INFO] [stdout] 784 | | meta: MetaAst::new(self.next(), ast_line, ast_pos), [INFO] [stdout] 785 | | expr: Box::new(expr), [INFO] [stdout] 786 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> kolgac/src/parser.rs:802:23 [INFO] [stdout] | [INFO] [stdout] 800 | let rhs = self.assign_expr(pctx)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 801 | [INFO] [stdout] 802 | match ast.clone() { [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> kolgac/src/parser.rs:1338:12 [INFO] [stdout] | [INFO] [stdout] 1214 | maybe_class_sym: Option>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1218 | let fn_sym = self.symtab.retrieve(&fn_tkn.clone().unwrap().get_name()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1233 | let class_constr_ast = maybe_class_sym.unwrap().assign_val.clone().unwrap(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1250 | let class_decl_sym = self.symtab.retrieve(&class_name.unwrap()).unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1256 | methods, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1260 | for mtod_ast in methods { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1301 | let mut params: Vec = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1338 | Ok(Ast::FnCallExpr { [INFO] [stdout] | ____________^ [INFO] [stdout] 1339 | | meta: MetaAst::new(self.next(), tkn.line, tkn.pos), [INFO] [stdout] 1340 | | ty_rec: fn_ty_rec.unwrap(), [INFO] [stdout] 1341 | | fn_tkn: fn_tkn.unwrap(), [INFO] [stdout] 1342 | | fn_params: params, [INFO] [stdout] 1343 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> kolgac/src/symtab.rs:103:15 [INFO] [stdout] | [INFO] [stdout] 103 | while curr >= 0 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling cc v1.0.59 [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kolgac` (lib) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0f86e87c845d210e341c86afce39b03136ab7bc6ef3a87134614ce478cb193e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f86e87c845d210e341c86afce39b03136ab7bc6ef3a87134614ce478cb193e7", kill_on_drop: false }` [INFO] [stdout] 0f86e87c845d210e341c86afce39b03136ab7bc6ef3a87134614ce478cb193e7