[INFO] cloning repository https://github.com/christianstaib/faster_paths [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/christianstaib/faster_paths" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristianstaib%2Ffaster_paths", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristianstaib%2Ffaster_paths'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 976674aca515e428ba2eed872a3872031712bcb4 [INFO] checking christianstaib/faster_paths/976674aca515e428ba2eed872a3872031712bcb4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristianstaib%2Ffaster_paths" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/christianstaib/faster_paths on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/christianstaib/faster_paths [INFO] finished tweaking git repo https://github.com/christianstaib/faster_paths [INFO] tweaked toml for git repo https://github.com/christianstaib/faster_paths written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/christianstaib/faster_paths already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eea6aec7b97e2a8d8fc3a5b19bb55bbdfaf8d1fec410a47d52ed210587441a96 [INFO] running `Command { std: "docker" "start" "-a" "eea6aec7b97e2a8d8fc3a5b19bb55bbdfaf8d1fec410a47d52ed210587441a96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eea6aec7b97e2a8d8fc3a5b19bb55bbdfaf8d1fec410a47d52ed210587441a96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eea6aec7b97e2a8d8fc3a5b19bb55bbdfaf8d1fec410a47d52ed210587441a96", kill_on_drop: false }` [INFO] [stdout] eea6aec7b97e2a8d8fc3a5b19bb55bbdfaf8d1fec410a47d52ed210587441a96 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3f9699bb8f8688dd6eae5731155fd00c5c73c9289a6e34fd97981057af37a44a [INFO] running `Command { std: "docker" "start" "-a" "3f9699bb8f8688dd6eae5731155fd00c5c73c9289a6e34fd97981057af37a44a", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking radix-heap v0.4.2 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking keyed_priority_queue v0.4.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking faster_paths v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ProgressIterator` [INFO] [stdout] --> src/ch/contraction_adaptive_simulated.rs:9:56 [INFO] [stdout] | [INFO] [stdout] 9 | use indicatif::{ParallelProgressIterator, ProgressBar, ProgressIterator}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ProgressIterator` [INFO] [stdout] --> src/ch/contraction_adaptive_simulated.rs:9:56 [INFO] [stdout] | [INFO] [stdout] 9 | use indicatif::{ParallelProgressIterator, ProgressBar, ProgressIterator}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `path_finder` [INFO] [stdout] --> src/classical_search/cache_dijkstra.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | path_finder: &dyn PathFinding, [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_path_finder` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `path_finder` [INFO] [stdout] --> src/classical_search/cache_dijkstra.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | path_finder: &dyn PathFinding, [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_path_finder` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `sample_pairs_2` is never used [INFO] [stdout] --> src/ch/contractor/contraction_helper.rs:96:4 [INFO] [stdout] | [INFO] [stdout] 96 | fn sample_pairs_2( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ch/contractor/contraction_helper.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 33 | let heads = graph.out_edges(vertex).map(|edge| edge.head()).collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | / graph [INFO] [stdout] 36 | | .in_edges(vertex) [INFO] [stdout] 37 | | .par_bridge() [INFO] [stdout] 38 | | .flat_map(|in_edge| { [INFO] [stdout] ... | [INFO] [stdout] 64 | | .collect_vec() [INFO] [stdout] 65 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ch/contractor/serial_witness_search_contractor.rs:56:10 [INFO] [stdout] | [INFO] [stdout] 36 | let bar = ProgressBar::new(graph.number_of_vertices() as u64); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | (shortcuts.into_values().collect(), level_to_verticies_map) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphs/graph_functions.rs:110:23 [INFO] [stdout] | [INFO] [stdout] 110 | .map(|vertex| graph.out_edges(vertex).len() as u32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphs/graph_functions.rs:233:23 [INFO] [stdout] | [INFO] [stdout] 233 | .map(|vertex| graph.out_edges(vertex).len() as u32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `sample_pairs_2` is never used [INFO] [stdout] --> src/ch/contractor/contraction_helper.rs:96:4 [INFO] [stdout] | [INFO] [stdout] 96 | fn sample_pairs_2( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ch/contractor/contraction_helper.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 33 | let heads = graph.out_edges(vertex).map(|edge| edge.head()).collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | / graph [INFO] [stdout] 36 | | .in_edges(vertex) [INFO] [stdout] 37 | | .par_bridge() [INFO] [stdout] 38 | | .flat_map(|in_edge| { [INFO] [stdout] ... | [INFO] [stdout] 64 | | .collect_vec() [INFO] [stdout] 65 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ch/contractor/serial_witness_search_contractor.rs:56:10 [INFO] [stdout] | [INFO] [stdout] 36 | let bar = ProgressBar::new(graph.number_of_vertices() as u64); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | (shortcuts.into_values().collect(), level_to_verticies_map) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphs/graph_functions.rs:110:23 [INFO] [stdout] | [INFO] [stdout] 110 | .map(|vertex| graph.out_edges(vertex).len() as u32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphs/graph_functions.rs:233:23 [INFO] [stdout] | [INFO] [stdout] 233 | .map(|vertex| graph.out_edges(vertex).len() as u32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `faster_paths` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `faster_paths` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3f9699bb8f8688dd6eae5731155fd00c5c73c9289a6e34fd97981057af37a44a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f9699bb8f8688dd6eae5731155fd00c5c73c9289a6e34fd97981057af37a44a", kill_on_drop: false }` [INFO] [stdout] 3f9699bb8f8688dd6eae5731155fd00c5c73c9289a6e34fd97981057af37a44a