[INFO] cloning repository https://github.com/christheblog/graph-commands [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/christheblog/graph-commands" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristheblog%2Fgraph-commands", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristheblog%2Fgraph-commands'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8861930c516adaa8c85ca1628309ded80f9d7d79 [INFO] checking christheblog/graph-commands/8861930c516adaa8c85ca1628309ded80f9d7d79 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristheblog%2Fgraph-commands" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/christheblog/graph-commands on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/christheblog/graph-commands [INFO] finished tweaking git repo https://github.com/christheblog/graph-commands [INFO] tweaked toml for git repo https://github.com/christheblog/graph-commands written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/christheblog/graph-commands already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b51fede39cf458429ac420a2376024e3aa87236bd7241603bfb3c2a9ecb45289 [INFO] running `Command { std: "docker" "start" "-a" "b51fede39cf458429ac420a2376024e3aa87236bd7241603bfb3c2a9ecb45289", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b51fede39cf458429ac420a2376024e3aa87236bd7241603bfb3c2a9ecb45289", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b51fede39cf458429ac420a2376024e3aa87236bd7241603bfb3c2a9ecb45289", kill_on_drop: false }` [INFO] [stdout] b51fede39cf458429ac420a2376024e3aa87236bd7241603bfb3c2a9ecb45289 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a21dd16b63ee9287d0831d0046ca064f2eb9879a5406074966103080e122b29 [INFO] running `Command { std: "docker" "start" "-a" "5a21dd16b63ee9287d0831d0046ca064f2eb9879a5406074966103080e122b29", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.5 [INFO] [stderr] Checking gc-core v0.1.0 (/opt/rustwide/workdir/core) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/constraint/checker.rs:97:61 [INFO] [stdout] | [INFO] [stdout] 97 | let contains_cycle = constraints.iter().find(|c| **c == ContainsCycle).is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/constraint/checker.rs:99:26 [INFO] [stdout] | [INFO] [stdout] 99 | .find(|c| **c == ContainsCycle) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/constraint/checker.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 188 | constraints: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | ) -> impl Iterator { [INFO] [stdout] 190 | constraints.into_iter().filter_map(|nc| match nc { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/iter/iter_best.rs:76:18 [INFO] [stdout] | [INFO] [stdout] 70 | fn empty_best_iter(graph: &DirectedGraph, scorefn: F) -> BestFirstIter [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | visited: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/iter/iter_cycle.rs:136:23 [INFO] [stdout] | [INFO] [stdout] 136 | .filter(|vid| graph.inbound_edges(**vid).count() == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/iter/iter_datastructure.rs:103:34 [INFO] [stdout] | [INFO] [stdout] 102 | fn push(&mut self, elt: T) -> () { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | self.priority_queue.push(Reverse(elt)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/search/a_star.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 17 | g: G, // computing current cost of the path so far [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | h: H, // heuristic [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | / iter::iter_best::best_iter_from( [INFO] [stdout] 27 | | graph, [INFO] [stdout] 28 | | |dg, path| g(dg, path) + h(dg, path), // f = g + h [INFO] [stdout] 29 | | start, [INFO] [stdout] 30 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/search/a_star.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 43 | g: G, // Cost of the path so far [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | h: H, // Heuristic - estimated cost to target [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | constraints: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let all_constraints = constraints.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / iter::iter_best_constraint::constrained_best_iter_from( [INFO] [stdout] 55 | | graph, [INFO] [stdout] 56 | | |dg, path| g(dg, path) + h(dg, path), // f = g + h [INFO] [stdout] 57 | | constraints, [INFO] [stdout] 58 | | start, [INFO] [stdout] 59 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gc-core` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/constraint/checker.rs:97:61 [INFO] [stdout] | [INFO] [stdout] 97 | let contains_cycle = constraints.iter().find(|c| **c == ContainsCycle).is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/constraint/checker.rs:99:26 [INFO] [stdout] | [INFO] [stdout] 99 | .find(|c| **c == ContainsCycle) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/constraint/checker.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 188 | constraints: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | ) -> impl Iterator { [INFO] [stdout] 190 | constraints.into_iter().filter_map(|nc| match nc { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/iter/iter_best.rs:76:18 [INFO] [stdout] | [INFO] [stdout] 70 | fn empty_best_iter(graph: &DirectedGraph, scorefn: F) -> BestFirstIter [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | visited: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/iter/iter_cycle.rs:136:23 [INFO] [stdout] | [INFO] [stdout] 136 | .filter(|vid| graph.inbound_edges(**vid).count() == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/iter/iter_datastructure.rs:103:34 [INFO] [stdout] | [INFO] [stdout] 102 | fn push(&mut self, elt: T) -> () { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | self.priority_queue.push(Reverse(elt)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/search/a_star.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 17 | g: G, // computing current cost of the path so far [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | h: H, // heuristic [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | / iter::iter_best::best_iter_from( [INFO] [stdout] 27 | | graph, [INFO] [stdout] 28 | | |dg, path| g(dg, path) + h(dg, path), // f = g + h [INFO] [stdout] 29 | | start, [INFO] [stdout] 30 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/search/a_star.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 43 | g: G, // Cost of the path so far [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | h: H, // Heuristic - estimated cost to target [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | constraints: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let all_constraints = constraints.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / iter::iter_best_constraint::constrained_best_iter_from( [INFO] [stdout] 55 | | graph, [INFO] [stdout] 56 | | |dg, path| g(dg, path) + h(dg, path), // f = g + h [INFO] [stdout] 57 | | constraints, [INFO] [stdout] 58 | | start, [INFO] [stdout] 59 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gc-core` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "5a21dd16b63ee9287d0831d0046ca064f2eb9879a5406074966103080e122b29", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a21dd16b63ee9287d0831d0046ca064f2eb9879a5406074966103080e122b29", kill_on_drop: false }` [INFO] [stdout] 5a21dd16b63ee9287d0831d0046ca064f2eb9879a5406074966103080e122b29