[INFO] cloning repository https://github.com/chrisrhayden/spellhold [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chrisrhayden/spellhold" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchrisrhayden%2Fspellhold", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchrisrhayden%2Fspellhold'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3216fc9cc3e06d34cd82d786d00797fbaf7e7be1 [INFO] checking chrisrhayden/spellhold/3216fc9cc3e06d34cd82d786d00797fbaf7e7be1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchrisrhayden%2Fspellhold" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/chrisrhayden/spellhold on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/chrisrhayden/spellhold [INFO] finished tweaking git repo https://github.com/chrisrhayden/spellhold [INFO] tweaked toml for git repo https://github.com/chrisrhayden/spellhold written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/chrisrhayden/spellhold already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bff33b42d1cbd7f107934ac1ec1083da8bc618c8539feb864d8739509d65ea8a [INFO] running `Command { std: "docker" "start" "-a" "bff33b42d1cbd7f107934ac1ec1083da8bc618c8539feb864d8739509d65ea8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bff33b42d1cbd7f107934ac1ec1083da8bc618c8539feb864d8739509d65ea8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bff33b42d1cbd7f107934ac1ec1083da8bc618c8539feb864d8739509d65ea8a", kill_on_drop: false }` [INFO] [stdout] bff33b42d1cbd7f107934ac1ec1083da8bc618c8539feb864d8739509d65ea8a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6fdd5b2d2870aaa52b350e2b26e0f77a9c630438ec5b94a3c6b03455e13ab652 [INFO] running `Command { std: "docker" "start" "-a" "6fdd5b2d2870aaa52b350e2b26e0f77a9c630438ec5b94a3c6b03455e13ab652", kill_on_drop: false }` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling libc v0.2.45 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking unicode-segmentation v1.2.1 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking rand_xorshift v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling rand_chacha v0.1.0 [INFO] [stderr] Compiling rand v0.6.1 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking tui v0.3.0 [INFO] [stderr] Checking spellhold v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/daemon/unix_socket_handler.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::{self, Arc, Mutex}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/daemon/unix_socket_handler.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::{self, Arc, Mutex}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `input_handle` and `tick_handle` are never read [INFO] [stdout] --> src/events/event.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Events { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 17 | rx: mpsc::Receiver>, [INFO] [stdout] 18 | input_handle: thread::JoinHandle<()>, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 19 | tick_handle: thread::JoinHandle<()>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/unix_socket_handler.rs:53:28 [INFO] [stdout] | [INFO] [stdout] 28 | let (main_sender, main_receiver) = mpsc::channel(); [INFO] [stdout] | ----------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let (client_sender, client_receiver) = mpsc::channel(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | let client_accept = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let client_receiver = Arc::new(Mutex::new(client_receiver)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let main_sender_give = main_sender.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let socket_path_give = socket_path.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let client_accept_give = client_accept.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | client_sender: Some(client_sender), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/unix_socket_handler.rs:54:28 [INFO] [stdout] | [INFO] [stdout] 28 | let (main_sender, main_receiver) = mpsc::channel(); [INFO] [stdout] | ----------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let (client_sender, client_receiver) = mpsc::channel(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | let client_accept = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let client_receiver = Arc::new(Mutex::new(client_receiver)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let main_sender_give = main_sender.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let socket_path_give = socket_path.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let client_accept_give = client_accept.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | client_accept: Some(client_accept), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/unix_socket_handler.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 62 | let abool = self.client_accept.take().ok_or("no client atomic bool")?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | [INFO] [stdout] 64 | let sender = self.client_sender.take().ok_or("no mpsc::Sender")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | Ok((abool, sender)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `input_handle` and `tick_handle` are never read [INFO] [stdout] --> src/events/event.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Events { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 17 | rx: mpsc::Receiver>, [INFO] [stdout] 18 | input_handle: thread::JoinHandle<()>, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 19 | tick_handle: thread::JoinHandle<()>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/unix_socket_handler.rs:53:28 [INFO] [stdout] | [INFO] [stdout] 28 | let (main_sender, main_receiver) = mpsc::channel(); [INFO] [stdout] | ----------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let (client_sender, client_receiver) = mpsc::channel(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | let client_accept = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let client_receiver = Arc::new(Mutex::new(client_receiver)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let main_sender_give = main_sender.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let socket_path_give = socket_path.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let client_accept_give = client_accept.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | client_sender: Some(client_sender), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/unix_socket_handler.rs:54:28 [INFO] [stdout] | [INFO] [stdout] 28 | let (main_sender, main_receiver) = mpsc::channel(); [INFO] [stdout] | ----------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let (client_sender, client_receiver) = mpsc::channel(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | let client_accept = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let client_receiver = Arc::new(Mutex::new(client_receiver)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let main_sender_give = main_sender.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let socket_path_give = socket_path.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let client_accept_give = client_accept.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | client_accept: Some(client_accept), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/unix_socket_handler.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 62 | let abool = self.client_accept.take().ok_or("no client atomic bool")?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | [INFO] [stdout] 64 | let sender = self.client_sender.take().ok_or("no mpsc::Sender")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | Ok((abool, sender)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spellhold` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spellhold` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6fdd5b2d2870aaa52b350e2b26e0f77a9c630438ec5b94a3c6b03455e13ab652", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6fdd5b2d2870aaa52b350e2b26e0f77a9c630438ec5b94a3c6b03455e13ab652", kill_on_drop: false }` [INFO] [stdout] 6fdd5b2d2870aaa52b350e2b26e0f77a9c630438ec5b94a3c6b03455e13ab652