[INFO] cloning repository https://github.com/chrisbouchard/klondike-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chrisbouchard/klondike-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchrisbouchard%2Fklondike-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchrisbouchard%2Fklondike-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b017ed3cc4645df7e48f137e0197252feef44b09 [INFO] checking chrisbouchard/klondike-rs/b017ed3cc4645df7e48f137e0197252feef44b09 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchrisbouchard%2Fklondike-rs" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/chrisbouchard/klondike-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/chrisbouchard/klondike-rs [INFO] finished tweaking git repo https://github.com/chrisbouchard/klondike-rs [INFO] tweaked toml for git repo https://github.com/chrisbouchard/klondike-rs written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/chrisbouchard/klondike-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9763bb56ab1cdfbafa579ec27a2c3af74ce75430941bec48b929d45621a76a18 [INFO] running `Command { std: "docker" "start" "-a" "9763bb56ab1cdfbafa579ec27a2c3af74ce75430941bec48b929d45621a76a18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9763bb56ab1cdfbafa579ec27a2c3af74ce75430941bec48b929d45621a76a18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9763bb56ab1cdfbafa579ec27a2c3af74ce75430941bec48b929d45621a76a18", kill_on_drop: false }` [INFO] [stdout] 9763bb56ab1cdfbafa579ec27a2c3af74ce75430941bec48b929d45621a76a18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 145c25ca747e488b3db10470a41fd127068d3ced3e3512147a1a8d5fb48bf15f [INFO] running `Command { std: "docker" "start" "-a" "145c25ca747e488b3db10470a41fd127068d3ced3e3512147a1a8d5fb48bf15f", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.8 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Checking serde v0.8.23 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling doc-comment v0.3.1 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking yaml-rust v0.4.3 [INFO] [stderr] Checking rust-ini v0.13.0 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking itertools v0.8.1 [INFO] [stderr] Checking log-panics v2.0.0 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Compiling num-traits v0.2.9 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking termion v1.5.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking directories v2.0.2 [INFO] [stderr] Checking term v0.6.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking serde_test v0.8.23 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking euclid v0.20.3 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking linked-hash-map v0.3.0 [INFO] [stderr] Checking chrono v0.4.9 [INFO] [stderr] Checking serde-hjson v0.8.2 [INFO] [stderr] Checking simplelog v0.7.4 [INFO] [stderr] Compiling derivative v1.0.3 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Compiling snafu-derive v0.6.0 [INFO] [stderr] Compiling derive_more v0.99.1 [INFO] [stderr] Checking snafu v0.6.0 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Compiling toml v0.5.5 [INFO] [stderr] Checking config v0.9.3 [INFO] [stderr] Compiling proc-macro-crate v0.1.4 [INFO] [stderr] Compiling num_enum_derive v0.4.2 [INFO] [stderr] Checking num_enum v0.4.2 [INFO] [stderr] Checking klondike-rs v1.1.1-alpha.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/display/help.rs:152:71 [INFO] [stdout] | [INFO] [stdout] 152 | Self::List(keys) => keys.iter().map(|key| key.char_len()).intersperse(3).sum(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `itertools::Itertools::intersperse(...)` to keep using the current method [INFO] [stdout] = note: `#[warn(unstable_name_collisions)]` on by default [INFO] [stdout] help: add `#![feature(iter_intersperse)]` to the crate attributes to enable `std::iter::Iterator::intersperse` [INFO] [stdout] --> src/lib.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 + #![feature(iter_intersperse)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/display/help.rs:168:22 [INFO] [stdout] | [INFO] [stdout] 168 | .intersperse( [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `itertools::Itertools::intersperse(...)` to keep using the current method [INFO] [stdout] help: add `#![feature(iter_intersperse)]` to the crate attributes to enable `std::iter::Iterator::intersperse` [INFO] [stdout] --> src/lib.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 + #![feature(iter_intersperse)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/display/help.rs:152:71 [INFO] [stdout] | [INFO] [stdout] 152 | Self::List(keys) => keys.iter().map(|key| key.char_len()).intersperse(3).sum(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `itertools::Itertools::intersperse(...)` to keep using the current method [INFO] [stdout] = note: `#[warn(unstable_name_collisions)]` on by default [INFO] [stdout] help: add `#![feature(iter_intersperse)]` to the crate attributes to enable `std::iter::Iterator::intersperse` [INFO] [stdout] --> src/lib.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 + #![feature(iter_intersperse)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/display/help.rs:168:22 [INFO] [stdout] | [INFO] [stdout] 168 | .intersperse( [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `itertools::Itertools::intersperse(...)` to keep using the current method [INFO] [stdout] help: add `#![feature(iter_intersperse)]` to the crate attributes to enable `std::iter::Iterator::intersperse` [INFO] [stdout] --> src/lib.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 + #![feature(iter_intersperse)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `shuffle` is never read [INFO] [stdout] --> src/model/dealer.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 55 | struct StandardDealer [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 59 | shuffle: S, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StandardDealer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display/help.rs:167:69 [INFO] [stdout] | [INFO] [stdout] 167 | .map(|key| FormattedString::new_with_formatting(key_style()).push_content(key)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:172:28 [INFO] [stdout] | [INFO] [stdout] 168 | pub fn builder(settings: &'a GameSettings, input: I, output: O) -> Self { [INFO] [stdout] | -------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | input_mappers: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:190:12 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn start(self) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let dealer = create_dealer(self.settings.dealer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | Ok(GameEngine { [INFO] [stdout] | ____________^ [INFO] [stdout] 191 | | settings: self.settings, [INFO] [stdout] 192 | | dealer, [INFO] [stdout] 193 | | game: None, [INFO] [stdout] ... | [INFO] [stdout] 198 | | game_widget_state, [INFO] [stdout] 199 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/area/mod.rs:68:36 [INFO] [stdout] | [INFO] [stdout] 67 | fn fail_move(self, value: U) -> MoveResult { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | MoveResult::Unmoved(value, self.into_error(snafu::NoneError)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/area/stock.rs:188:27 [INFO] [stdout] | [INFO] [stdout] 187 | fn select(self: Box) -> MoveResult, Box> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | MoveResult::Moved(Box::new(self.with_selection(Selection))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/area/stock.rs:198:20 [INFO] [stdout] | [INFO] [stdout] 192 | self: Box, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | .fail_move((self, held)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/area_list.rs:278:15 [INFO] [stdout] | [INFO] [stdout] 270 | let (target_area, areas_to_move) = target_vec.split_off_around(relative_index); [INFO] [stdout] | ----------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | let target_area = target_area.unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | [INFO] [stdout] 273 | let selected_area = self [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | match move_selection(selected_area, target_area) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/dealer.rs:123:30 [INFO] [stdout] | [INFO] [stdout] 123 | .flat_map(|suit| Rank::values().map(move |rank| Card { rank, suit })) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/game.rs:48:15 [INFO] [stdout] | [INFO] [stdout] 48 | action.borrow().apply(self) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `model::game::Action` does not implement `Borrow`, so calling `borrow` on `&model::game::Action` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 48 - action.borrow().apply(self) [INFO] [stdout] 48 + action.apply(self) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `model::game::Action`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 53 + #[derive(Clone)] [INFO] [stdout] 54 | pub enum Action { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/settings.rs:61:30 [INFO] [stdout] | [INFO] [stdout] 61 | #[derive(Debug, Clone, Copy, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | let tty = termion::get_tty().context(TtyError)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Ok(TtyInput { tty }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 58 | let mut tty = AlternateScreen::from( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(TtyOutput { tty }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/format_str.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 95 | fn from_iter(iter: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | iter.into_iter().fold(Self::default(), |acc, s| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `shuffle` is never read [INFO] [stdout] --> src/model/dealer.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 55 | struct StandardDealer [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 59 | shuffle: S, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StandardDealer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display/help.rs:167:69 [INFO] [stdout] | [INFO] [stdout] 167 | .map(|key| FormattedString::new_with_formatting(key_style()).push_content(key)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:172:28 [INFO] [stdout] | [INFO] [stdout] 168 | pub fn builder(settings: &'a GameSettings, input: I, output: O) -> Self { [INFO] [stdout] | -------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | input_mappers: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:190:12 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn start(self) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let dealer = create_dealer(self.settings.dealer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | Ok(GameEngine { [INFO] [stdout] | ____________^ [INFO] [stdout] 191 | | settings: self.settings, [INFO] [stdout] 192 | | dealer, [INFO] [stdout] 193 | | game: None, [INFO] [stdout] ... | [INFO] [stdout] 198 | | game_widget_state, [INFO] [stdout] 199 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/area/mod.rs:68:36 [INFO] [stdout] | [INFO] [stdout] 67 | fn fail_move(self, value: U) -> MoveResult { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | MoveResult::Unmoved(value, self.into_error(snafu::NoneError)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/area/stock.rs:188:27 [INFO] [stdout] | [INFO] [stdout] 187 | fn select(self: Box) -> MoveResult, Box> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | MoveResult::Moved(Box::new(self.with_selection(Selection))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/area/stock.rs:198:20 [INFO] [stdout] | [INFO] [stdout] 192 | self: Box, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | .fail_move((self, held)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/area_list.rs:278:15 [INFO] [stdout] | [INFO] [stdout] 270 | let (target_area, areas_to_move) = target_vec.split_off_around(relative_index); [INFO] [stdout] | ----------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | let target_area = target_area.unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | [INFO] [stdout] 273 | let selected_area = self [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | match move_selection(selected_area, target_area) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/dealer.rs:123:30 [INFO] [stdout] | [INFO] [stdout] 123 | .flat_map(|suit| Rank::values().map(move |rank| Card { rank, suit })) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/game.rs:48:15 [INFO] [stdout] | [INFO] [stdout] 48 | action.borrow().apply(self) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `model::game::Action` does not implement `Borrow`, so calling `borrow` on `&model::game::Action` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 48 - action.borrow().apply(self) [INFO] [stdout] 48 + action.apply(self) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `model::game::Action`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 53 + #[derive(Clone)] [INFO] [stdout] 54 | pub enum Action { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/settings.rs:61:30 [INFO] [stdout] | [INFO] [stdout] 61 | #[derive(Debug, Clone, Copy, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | let tty = termion::get_tty().context(TtyError)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Ok(TtyInput { tty }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 58 | let mut tty = AlternateScreen::from( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(TtyOutput { tty }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/format_str.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 95 | fn from_iter(iter: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | iter.into_iter().fold(Self::default(), |acc, s| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `klondike-rs` (lib test) due to 13 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 12 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `klondike-rs` (lib) due to 13 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "145c25ca747e488b3db10470a41fd127068d3ced3e3512147a1a8d5fb48bf15f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "145c25ca747e488b3db10470a41fd127068d3ced3e3512147a1a8d5fb48bf15f", kill_on_drop: false }` [INFO] [stdout] 145c25ca747e488b3db10470a41fd127068d3ced3e3512147a1a8d5fb48bf15f