[INFO] cloning repository https://github.com/chirprush/rust-mathl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chirprush/rust-mathl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchirprush%2Frust-mathl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchirprush%2Frust-mathl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5b293d4e6f736bc714163fcf9aea1feba4bc7a00 [INFO] checking chirprush/rust-mathl/5b293d4e6f736bc714163fcf9aea1feba4bc7a00 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchirprush%2Frust-mathl" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/chirprush/rust-mathl on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/chirprush/rust-mathl [INFO] finished tweaking git repo https://github.com/chirprush/rust-mathl [INFO] tweaked toml for git repo https://github.com/chirprush/rust-mathl written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/chirprush/rust-mathl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26b9195823d55bbe1d6e7657d8db17a844f91d51e8cfe51d978ab8aa19455dcc [INFO] running `Command { std: "docker" "start" "-a" "26b9195823d55bbe1d6e7657d8db17a844f91d51e8cfe51d978ab8aa19455dcc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26b9195823d55bbe1d6e7657d8db17a844f91d51e8cfe51d978ab8aa19455dcc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26b9195823d55bbe1d6e7657d8db17a844f91d51e8cfe51d978ab8aa19455dcc", kill_on_drop: false }` [INFO] [stdout] 26b9195823d55bbe1d6e7657d8db17a844f91d51e8cfe51d978ab8aa19455dcc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e3725cef209832ee771507181d35ff137a3593dd1703a42a5ff9e4b52f7afa90 [INFO] running `Command { std: "docker" "start" "-a" "e3725cef209832ee771507181d35ff137a3593dd1703a42a5ff9e4b52f7afa90", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.85 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking nix v0.19.1 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking rustyline v7.1.0 [INFO] [stderr] Checking mathl v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:175:12 [INFO] [stdout] | [INFO] [stdout] 168 | let expr = match self.parse_factor() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | Ok(expr) => expr, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | error => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | Ok(Node::UnaryOp(op.to_string(), Box::new(expr))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:222:12 [INFO] [stdout] | [INFO] [stdout] 185 | let case = match self.parse_expr() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | Ok(expr) => expr, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | error => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let left = match self.parse_expr() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | Ok(expr) => expr, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | error => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | let right = match self.parse_expr() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | Ok(expr) => expr, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | error => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | Ok(Node::If(Box::new(case), Box::new(left), Box::new(right))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:256:12 [INFO] [stdout] | [INFO] [stdout] 248 | let expr = match self.parse_expr() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | Ok(expr) => expr, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | error => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | Ok(Node::Let(ident.to_string(), Box::new(expr))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/parser/node.rs:44:33 [INFO] [stdout] | [INFO] [stdout] 44 | _ => panic!(format!("Binary operator '{}' not yet implemented", op)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 44 - _ => panic!(format!("Binary operator '{}' not yet implemented", op)) [INFO] [stdout] 44 + _ => panic!("Binary operator '{}' not yet implemented", op) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/parser/node.rs:51:50 [INFO] [stdout] | [INFO] [stdout] 51 | _ => panic!("Unary operator '{}' not yet implemented") [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 51 | _ => panic!("Unary operator '{}' not yet implemented", ...) [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 51 | _ => panic!("{}", "Unary operator '{}' not yet implemented") [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/parser/node.rs:175:25 [INFO] [stdout] | [INFO] [stdout] 175 | _ => panic!(format!("Cannot display node of type {}", self.type_name())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 175 - _ => panic!(format!("Cannot display node of type {}", self.type_name())), [INFO] [stdout] 175 + _ => panic!("Cannot display node of type {}", self.type_name()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mathl` (bin "mathl" test) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:175:12 [INFO] [stdout] | [INFO] [stdout] 168 | let expr = match self.parse_factor() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | Ok(expr) => expr, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | error => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | Ok(Node::UnaryOp(op.to_string(), Box::new(expr))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:222:12 [INFO] [stdout] | [INFO] [stdout] 185 | let case = match self.parse_expr() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | Ok(expr) => expr, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | error => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let left = match self.parse_expr() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | Ok(expr) => expr, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | error => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | let right = match self.parse_expr() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | Ok(expr) => expr, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | error => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | Ok(Node::If(Box::new(case), Box::new(left), Box::new(right))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:256:12 [INFO] [stdout] | [INFO] [stdout] 248 | let expr = match self.parse_expr() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | Ok(expr) => expr, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | error => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | Ok(Node::Let(ident.to_string(), Box::new(expr))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/parser/node.rs:44:33 [INFO] [stdout] | [INFO] [stdout] 44 | _ => panic!(format!("Binary operator '{}' not yet implemented", op)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 44 - _ => panic!(format!("Binary operator '{}' not yet implemented", op)) [INFO] [stdout] 44 + _ => panic!("Binary operator '{}' not yet implemented", op) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/parser/node.rs:51:50 [INFO] [stdout] | [INFO] [stdout] 51 | _ => panic!("Unary operator '{}' not yet implemented") [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 51 | _ => panic!("Unary operator '{}' not yet implemented", ...) [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 51 | _ => panic!("{}", "Unary operator '{}' not yet implemented") [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/parser/node.rs:175:25 [INFO] [stdout] | [INFO] [stdout] 175 | _ => panic!(format!("Cannot display node of type {}", self.type_name())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 175 - _ => panic!(format!("Cannot display node of type {}", self.type_name())), [INFO] [stdout] 175 + _ => panic!("Cannot display node of type {}", self.type_name()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mathl` (bin "mathl") due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e3725cef209832ee771507181d35ff137a3593dd1703a42a5ff9e4b52f7afa90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3725cef209832ee771507181d35ff137a3593dd1703a42a5ff9e4b52f7afa90", kill_on_drop: false }` [INFO] [stdout] e3725cef209832ee771507181d35ff137a3593dd1703a42a5ff9e4b52f7afa90