[INFO] cloning repository https://github.com/chip2n/dragonroll [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chip2n/dragonroll" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchip2n%2Fdragonroll", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchip2n%2Fdragonroll'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e369d5f6be8b0c4773c73fef1b6e3548644c92e3 [INFO] checking chip2n/dragonroll/e369d5f6be8b0c4773c73fef1b6e3548644c92e3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchip2n%2Fdragonroll" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/chip2n/dragonroll on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/chip2n/dragonroll [INFO] finished tweaking git repo https://github.com/chip2n/dragonroll [INFO] tweaked toml for git repo https://github.com/chip2n/dragonroll written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/chip2n/dragonroll already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2e1f6a96d32d65ae2d5fc1653bbce3910ca3f93e0c4ed076462058ada8ce706 [INFO] running `Command { std: "docker" "start" "-a" "a2e1f6a96d32d65ae2d5fc1653bbce3910ca3f93e0c4ed076462058ada8ce706", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2e1f6a96d32d65ae2d5fc1653bbce3910ca3f93e0c4ed076462058ada8ce706", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2e1f6a96d32d65ae2d5fc1653bbce3910ca3f93e0c4ed076462058ada8ce706", kill_on_drop: false }` [INFO] [stdout] a2e1f6a96d32d65ae2d5fc1653bbce3910ca3f93e0c4ed076462058ada8ce706 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 905f4a458aba16eb040bd0eef43ae2f220084c7c1f121f6739a8fa771f6fb5fa [INFO] running `Command { std: "docker" "start" "-a" "905f4a458aba16eb040bd0eef43ae2f220084c7c1f121f6739a8fa771f6fb5fa", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.73 [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling syn v1.0.35 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling proc-macro-hack v0.5.16 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Compiling cc v1.0.58 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Compiling num-rational v0.3.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling pkg-config v0.3.18 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Compiling const-random-macro v0.1.8 [INFO] [stderr] Checking num-complex v0.3.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking const-random v0.1.8 [INFO] [stderr] Compiling ncurses v5.99.0 [INFO] [stderr] Checking array-macro v1.0.5 [INFO] [stderr] Checking ahash v0.4.4 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking crossbeam-channel v0.4.3 [INFO] [stderr] Checking chrono v0.4.13 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking signal-hook v0.1.16 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking xi-unicode v0.2.1 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Checking num v0.3.0 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling enum-map-derive v0.4.3 [INFO] [stderr] Checking enum-map v0.6.2 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling enumset_derive v0.5.0 [INFO] [stderr] Checking enumset v1.0.0 [INFO] [stderr] Checking cursive_core v0.1.1 [INFO] [stderr] Checking cursive v0.15.0 [INFO] [stderr] Checking cursive-test v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `msg` is never read [INFO] [stdout] --> src/dice/eval.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | struct EvalError { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 16 | msg: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EvalError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `log_messages` is never read [INFO] [stdout] --> src/state.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct State { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 5 | pub log_messages: Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 97 | let encounter_list = LinearLayout::vertical().child(TextView::new("> Goblin ambush")); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let encounter_panel = [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let player_list = SelectView::::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let player_panel = Panel::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let panel1 = LinearLayout::vertical() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let log_list = ListView::new().with_name("log").scrollable(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | [INFO] [stdout] 117 | let panel2 = Panel::new(log_list.with_name("log_scroll")) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | LinearLayout::horizontal().child(panel1).child(panel2) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 135 | title: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | message: Option, [INFO] [stdout] 137 | on_submit: F, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let on_submit_clone = on_submit.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | [INFO] [stdout] 144 | let input_field = EditView::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let mut content = LinearLayout::vertical().child(input_field); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | / Dialog::new() [INFO] [stdout] 160 | | .title(title.into()) [INFO] [stdout] 161 | | .padding(Margins::lrtb(1, 1, 1, 0)) [INFO] [stdout] 162 | | .content(content) [INFO] [stdout] ... | [INFO] [stdout] 168 | | on_submit(cursive, &input); [INFO] [stdout] 169 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:145:42 [INFO] [stdout] | [INFO] [stdout] 142 | let on_submit_clone = on_submit.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | .on_submit(move |cursive, input| on_submit_clone.clone()(cursive, input)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cursive-test` (bin "cursive-test") due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `msg` is never read [INFO] [stdout] --> src/dice/eval.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | struct EvalError { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 16 | msg: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EvalError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `log_messages` is never read [INFO] [stdout] --> src/state.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct State { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 5 | pub log_messages: Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 97 | let encounter_list = LinearLayout::vertical().child(TextView::new("> Goblin ambush")); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let encounter_panel = [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let player_list = SelectView::::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let player_panel = Panel::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let panel1 = LinearLayout::vertical() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let log_list = ListView::new().with_name("log").scrollable(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | [INFO] [stdout] 117 | let panel2 = Panel::new(log_list.with_name("log_scroll")) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | LinearLayout::horizontal().child(panel1).child(panel2) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 135 | title: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | message: Option, [INFO] [stdout] 137 | on_submit: F, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let on_submit_clone = on_submit.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | [INFO] [stdout] 144 | let input_field = EditView::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let mut content = LinearLayout::vertical().child(input_field); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | / Dialog::new() [INFO] [stdout] 160 | | .title(title.into()) [INFO] [stdout] 161 | | .padding(Margins::lrtb(1, 1, 1, 0)) [INFO] [stdout] 162 | | .content(content) [INFO] [stdout] ... | [INFO] [stdout] 168 | | on_submit(cursive, &input); [INFO] [stdout] 169 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:145:42 [INFO] [stdout] | [INFO] [stdout] 142 | let on_submit_clone = on_submit.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | .on_submit(move |cursive, input| on_submit_clone.clone()(cursive, input)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cursive-test` (bin "cursive-test" test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "905f4a458aba16eb040bd0eef43ae2f220084c7c1f121f6739a8fa771f6fb5fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "905f4a458aba16eb040bd0eef43ae2f220084c7c1f121f6739a8fa771f6fb5fa", kill_on_drop: false }` [INFO] [stdout] 905f4a458aba16eb040bd0eef43ae2f220084c7c1f121f6739a8fa771f6fb5fa