[INFO] cloning repository https://github.com/chikaku/simple_calculator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chikaku/simple_calculator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchikaku%2Fsimple_calculator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchikaku%2Fsimple_calculator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 521cd4a36a55aa0b91cab080091c82c009784097 [INFO] checking chikaku/simple_calculator/521cd4a36a55aa0b91cab080091c82c009784097 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchikaku%2Fsimple_calculator" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/chikaku/simple_calculator on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/chikaku/simple_calculator [INFO] finished tweaking git repo https://github.com/chikaku/simple_calculator [INFO] tweaked toml for git repo https://github.com/chikaku/simple_calculator written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/chikaku/simple_calculator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f8d47c1e7d37045572198e38eb9020f160fd20176509ab845f8657de9b9a42b3 [INFO] running `Command { std: "docker" "start" "-a" "f8d47c1e7d37045572198e38eb9020f160fd20176509ab845f8657de9b9a42b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f8d47c1e7d37045572198e38eb9020f160fd20176509ab845f8657de9b9a42b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8d47c1e7d37045572198e38eb9020f160fd20176509ab845f8657de9b9a42b3", kill_on_drop: false }` [INFO] [stdout] f8d47c1e7d37045572198e38eb9020f160fd20176509ab845f8657de9b9a42b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a016c07d2a04cb5c2df56d3573a6c73c31c2a6249623760bde0c248dd601a4a9 [INFO] running `Command { std: "docker" "start" "-a" "a016c07d2a04cb5c2df56d3573a6c73c31c2a6249623760bde0c248dd601a4a9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Checking quote v1.0.9 [INFO] [stderr] Checking simple_calculator_deliver v0.1.1 (/opt/rustwide/workdir/deliver) [INFO] [stderr] Checking simple_calculator_cmd v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `exclusive_range_pattern` has been stable since 1.80.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(exclusive_range_pattern)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `bool_to_option` has been stable since 1.62.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(bool_to_option)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `exclusive_range_pattern` has been stable since 1.80.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(exclusive_range_pattern)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `bool_to_option` has been stable since 1.62.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(bool_to_option)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 70 | let left = self.test_term()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let rights = &self.test_test_expression_prime()?; [INFO] [stdout] 72 | Ok(rights.iter().fold( [INFO] [stdout] | ____________^ [INFO] [stdout] 73 | | Expression { [INFO] [stdout] 74 | | right: Rc::new(left), [INFO] [stdout] 75 | | left: None, [INFO] [stdout] ... | [INFO] [stdout] 84 | | }, [INFO] [stdout] 85 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:80:28 [INFO] [stdout] | [INFO] [stdout] 78 | |acc, (op, term)| -> Expression { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Expression { [INFO] [stdout] 80 | right: term.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:81:27 [INFO] [stdout] | [INFO] [stdout] 78 | |acc, (op, term)| -> Expression { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | left: Some((*op, Box::new(acc))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 101 | let left = self.test_factor()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let right = &self.test_term_prime()?; [INFO] [stdout] 103 | Ok(right.iter().fold( [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | Term { [INFO] [stdout] 105 | | left: None, [INFO] [stdout] 106 | | right: Rc::new(left), [INFO] [stdout] ... | [INFO] [stdout] 113 | | }, [INFO] [stdout] 114 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:110:27 [INFO] [stdout] | [INFO] [stdout] 108 | |acc, (op, factor)| -> Term { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Term { [INFO] [stdout] 110 | left: Some((*op, Box::new(acc))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:111:28 [INFO] [stdout] | [INFO] [stdout] 108 | |acc, (op, factor)| -> Term { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | right: factor.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 131 | let left = match self.next_word() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | Some(Token::Bracket(Bracket::Left)) => { [INFO] [stdout] 133 | let expr = self.test_expression()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | Ok(match self.test_factor_prime()? { [INFO] [stdout] | ____________^ [INFO] [stdout] 144 | | Some(right) => Factor::Power(Box::new(left), Box::new(right)), [INFO] [stdout] 145 | | None => left, [INFO] [stdout] 146 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 70 | let left = self.test_term()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let rights = &self.test_test_expression_prime()?; [INFO] [stdout] 72 | Ok(rights.iter().fold( [INFO] [stdout] | ____________^ [INFO] [stdout] 73 | | Expression { [INFO] [stdout] 74 | | right: Rc::new(left), [INFO] [stdout] 75 | | left: None, [INFO] [stdout] ... | [INFO] [stdout] 84 | | }, [INFO] [stdout] 85 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:80:28 [INFO] [stdout] | [INFO] [stdout] 78 | |acc, (op, term)| -> Expression { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Expression { [INFO] [stdout] 80 | right: term.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:81:27 [INFO] [stdout] | [INFO] [stdout] 78 | |acc, (op, term)| -> Expression { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | left: Some((*op, Box::new(acc))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 101 | let left = self.test_factor()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let right = &self.test_term_prime()?; [INFO] [stdout] 103 | Ok(right.iter().fold( [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | Term { [INFO] [stdout] 105 | | left: None, [INFO] [stdout] 106 | | right: Rc::new(left), [INFO] [stdout] ... | [INFO] [stdout] 113 | | }, [INFO] [stdout] 114 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:110:27 [INFO] [stdout] | [INFO] [stdout] 108 | |acc, (op, factor)| -> Term { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Term { [INFO] [stdout] 110 | left: Some((*op, Box::new(acc))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:111:28 [INFO] [stdout] | [INFO] [stdout] 108 | |acc, (op, factor)| -> Term { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | right: factor.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 131 | let left = match self.next_word() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | Some(Token::Bracket(Bracket::Left)) => { [INFO] [stdout] 133 | let expr = self.test_expression()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | Ok(match self.test_factor_prime()? { [INFO] [stdout] | ____________^ [INFO] [stdout] 144 | | Some(right) => Factor::Power(Box::new(left), Box::new(right)), [INFO] [stdout] 145 | | None => left, [INFO] [stdout] 146 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple_calculator_cmd` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `simple_calculator_cmd` (lib) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a016c07d2a04cb5c2df56d3573a6c73c31c2a6249623760bde0c248dd601a4a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a016c07d2a04cb5c2df56d3573a6c73c31c2a6249623760bde0c248dd601a4a9", kill_on_drop: false }` [INFO] [stdout] a016c07d2a04cb5c2df56d3573a6c73c31c2a6249623760bde0c248dd601a4a9