[INFO] updating cached repository https://github.com/chiefnoah/MehDB [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 121459396341b98f16d4a44cd7748c7ccd451151 [INFO] checking chiefnoah/MehDB/121459396341b98f16d4a44cd7748c7ccd451151 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchiefnoah%2FMehDB" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/chiefnoah/MehDB on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/chiefnoah/MehDB [INFO] finished tweaking git repo https://github.com/chiefnoah/MehDB [INFO] tweaked toml for git repo https://github.com/chiefnoah/MehDB written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/chiefnoah/MehDB already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 36d8456ba2f13d46e2894b8ef6093950eb9cb0274b4d3a8023f98563be02d712 [INFO] running `Command { std: "docker" "start" "-a" "36d8456ba2f13d46e2894b8ef6093950eb9cb0274b4d3a8023f98563be02d712", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "36d8456ba2f13d46e2894b8ef6093950eb9cb0274b4d3a8023f98563be02d712", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36d8456ba2f13d46e2894b8ef6093950eb9cb0274b4d3a8023f98563be02d712", kill_on_drop: false }` [INFO] [stdout] 36d8456ba2f13d46e2894b8ef6093950eb9cb0274b4d3a8023f98563be02d712 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ca99dd354512d3c96c9a9503d766e627ba936e5b0b4abe04458e4be25877faa0 [INFO] running `Command { std: "docker" "start" "-a" "ca99dd354512d3c96c9a9503d766e627ba936e5b0b4abe04458e4be25877faa0", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking once_cell v1.15.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling crossbeam-queue v0.3.6 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Compiling anyhow v1.0.64 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking wyz v0.5.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking highway v0.8.0 [INFO] [stderr] Checking cache-padded v1.2.0 [INFO] [stderr] Checking simple-error v0.2.3 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.10 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Checking crossbeam v0.8.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking mehdb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/directory.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 38 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let map = unsafe { MmapMut::map_mut(&file).context("Initializing mmap")? }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | // If the mmap is empty or new, make it writeable, populate the global_ [INFO] [stdout] 53 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | map: ShardedLock::new(map), [INFO] [stdout] 55 | | config, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/meh.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | drop(segment_locker); [INFO] [stdout] | ^^^^^--------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&parking_lot::lock_api::RwLock` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 46 - drop(segment_locker); [INFO] [stdout] 46 + let _ = segment_locker; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meh.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 85 | let mut segment_node = segment_locker.upgradable_read(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let bucket_lock = segment_node [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | / self.segmenter [INFO] [stdout] 152 | | .write_bucket(&bucket) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/meh.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | drop(segment_locker); [INFO] [stdout] | ^^^^^--------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&parking_lot::lock_api::RwLock` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 99 - drop(segment_locker); [INFO] [stdout] 99 + let _ = segment_locker; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/meh.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | drop(segment_locker); [INFO] [stdout] | ^^^^^--------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&parking_lot::lock_api::RwLock` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 137 - drop(segment_locker); [INFO] [stdout] 137 + let _ = segment_locker; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/segment.rs:116:19 [INFO] [stdout] | [INFO] [stdout] 107 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | file: RefCell::new(file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/segment.rs:117:32 [INFO] [stdout] | [INFO] [stdout] 107 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | segment_file_lock: self.segment_file_lock.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mehdb` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/directory.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 38 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let map = unsafe { MmapMut::map_mut(&file).context("Initializing mmap")? }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | // If the mmap is empty or new, make it writeable, populate the global_ [INFO] [stdout] 53 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | map: ShardedLock::new(map), [INFO] [stdout] 55 | | config, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/meh.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | drop(segment_locker); [INFO] [stdout] | ^^^^^--------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&parking_lot::lock_api::RwLock` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 46 - drop(segment_locker); [INFO] [stdout] 46 + let _ = segment_locker; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meh.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 85 | let mut segment_node = segment_locker.upgradable_read(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let bucket_lock = segment_node [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | / self.segmenter [INFO] [stdout] 152 | | .write_bucket(&bucket) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/meh.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | drop(segment_locker); [INFO] [stdout] | ^^^^^--------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&parking_lot::lock_api::RwLock` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 99 - drop(segment_locker); [INFO] [stdout] 99 + let _ = segment_locker; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/meh.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | drop(segment_locker); [INFO] [stdout] | ^^^^^--------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&parking_lot::lock_api::RwLock` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 137 - drop(segment_locker); [INFO] [stdout] 137 + let _ = segment_locker; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/segment.rs:116:19 [INFO] [stdout] | [INFO] [stdout] 107 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | file: RefCell::new(file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/segment.rs:117:32 [INFO] [stdout] | [INFO] [stdout] 107 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | segment_file_lock: self.segment_file_lock.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mehdb` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ca99dd354512d3c96c9a9503d766e627ba936e5b0b4abe04458e4be25877faa0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca99dd354512d3c96c9a9503d766e627ba936e5b0b4abe04458e4be25877faa0", kill_on_drop: false }` [INFO] [stdout] ca99dd354512d3c96c9a9503d766e627ba936e5b0b4abe04458e4be25877faa0