[INFO] cloning repository https://github.com/chenquan/r-cache [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chenquan/r-cache" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchenquan%2Fr-cache", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchenquan%2Fr-cache'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7fbc5e4e08869e6f678c776f46e4baa27ae6193e [INFO] checking chenquan/r-cache/7fbc5e4e08869e6f678c776f46e4baa27ae6193e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchenquan%2Fr-cache" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/chenquan/r-cache on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/chenquan/r-cache [INFO] finished tweaking git repo https://github.com/chenquan/r-cache [INFO] tweaked toml for git repo https://github.com/chenquan/r-cache written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/chenquan/r-cache already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2cb859c838cf0172cd2aa2743d43bc5e3af089ca93894630f0ab2290ca3edf31 [INFO] running `Command { std: "docker" "start" "-a" "2cb859c838cf0172cd2aa2743d43bc5e3af089ca93894630f0ab2290ca3edf31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2cb859c838cf0172cd2aa2743d43bc5e3af089ca93894630f0ab2290ca3edf31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cb859c838cf0172cd2aa2743d43bc5e3af089ca93894630f0ab2290ca3edf31", kill_on_drop: false }` [INFO] [stdout] 2cb859c838cf0172cd2aa2743d43bc5e3af089ca93894630f0ab2290ca3edf31 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c9fc3e0bb648f838d0f45f597fbf05b90b455e6dfb2b131d656f2de559b348b [INFO] running `Command { std: "docker" "start" "-a" "8c9fc3e0bb648f838d0f45f597fbf05b90b455e6dfb2b131d656f2de559b348b", kill_on_drop: false }` [INFO] [stderr] Checking r-cache v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/group/group.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | struct Group { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 7 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `delete` and `name` are never used [INFO] [stdout] --> src/group/group.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 18 | impl Group { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 38 | fn delete(&mut self) {} [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 39 | [INFO] [stdout] 40 | fn name(self) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/cache.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 36 | fn set(&mut self, key: String, value: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | self.data_map.insert(key, value).map_or(true, |_| false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/single_flight/wait_group.rs:35:23 [INFO] [stdout] | [INFO] [stdout] 32 | let mut count = self.inner.count.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Self { inner: self.inner.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `r-cache` (bin "r-cache" test) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: methods `get`, `set`, and `delete` are never used [INFO] [stdout] --> src/cache/cache.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub trait Cache { [INFO] [stdout] | ----- methods in this trait [INFO] [stdout] 4 | fn get(&mut self, key: &str) -> Option; [INFO] [stdout] | ^^^ [INFO] [stdout] 5 | fn set(&mut self, key: String, value: T) -> bool; [INFO] [stdout] | ^^^ [INFO] [stdout] 6 | fn delete(&mut self, key: &str) -> bool; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/cache/cache.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl LRUCache where T: Clone, { [INFO] [stdout] | ----------------------------------- associated function in this implementation [INFO] [stdout] 17 | pub fn new(cap: i64) -> LRUCache { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `wg` and `result` are never read [INFO] [stdout] --> src/single_flight/single_flight.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | struct Call where T: Clone + Debug { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 9 | wg: WaitGroup, [INFO] [stdout] | ^^ [INFO] [stdout] 10 | result: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Call` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/single_flight/single_flight.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 14 | impl Call where T: Clone + Debug { [INFO] [stdout] | -------------------------------------- associated function in this implementation [INFO] [stdout] 15 | fn new() -> Call { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `m` is never read [INFO] [stdout] --> src/single_flight/single_flight.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Group where T: Clone + Debug { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 24 | m: Mutex>>>, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `do_fn` are never used [INFO] [stdout] --> src/single_flight/single_flight.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl Group where T: Clone + Debug { [INFO] [stdout] | --------------------------------------- associated items in this implementation [INFO] [stdout] 35 | pub fn new() -> Group { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn do_fn(&self, key: &str, func: F) -> Option [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `wait` are never used [INFO] [stdout] --> src/single_flight/wait_group.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 46 | impl WaitGroup { [INFO] [stdout] | -------------- associated items in this implementation [INFO] [stdout] 47 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn wait(self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Group` is never constructed [INFO] [stdout] --> src/group/group.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | struct Group { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/group/group.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl Group { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 13 | pub fn new(name: String) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `put`, `get`, `delete`, `name`, and `get_local` are never used [INFO] [stdout] --> src/group/group.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 18 | impl Group { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] 19 | fn put(&mut self, key: String, value: Vec) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | fn get(&mut self, key: &str) -> Option> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | fn delete(&mut self) {} [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 39 | [INFO] [stdout] 40 | fn name(self) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | fn get_local(&self, _: &str) -> Option> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/cache.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 36 | fn set(&mut self, key: String, value: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | self.data_map.insert(key, value).map_or(true, |_| false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/single_flight/wait_group.rs:35:23 [INFO] [stdout] | [INFO] [stdout] 32 | let mut count = self.inner.count.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Self { inner: self.inner.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `r-cache` (bin "r-cache") due to 3 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8c9fc3e0bb648f838d0f45f597fbf05b90b455e6dfb2b131d656f2de559b348b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c9fc3e0bb648f838d0f45f597fbf05b90b455e6dfb2b131d656f2de559b348b", kill_on_drop: false }` [INFO] [stdout] 8c9fc3e0bb648f838d0f45f597fbf05b90b455e6dfb2b131d656f2de559b348b