[INFO] cloning repository https://github.com/charliethomson/rycst-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/charliethomson/rycst-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcharliethomson%2Frycst-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcharliethomson%2Frycst-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 06ca961c8ec519ece1967f0aea783adb08727ca9 [INFO] checking charliethomson/rycst-rs/06ca961c8ec519ece1967f0aea783adb08727ca9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcharliethomson%2Frycst-rs" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/charliethomson/rycst-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/charliethomson/rycst-rs [INFO] finished tweaking git repo https://github.com/charliethomson/rycst-rs [INFO] tweaked toml for git repo https://github.com/charliethomson/rycst-rs written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 32 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding num-traits v0.1.43 (latest: v0.2.19) [INFO] [stderr] Adding sdl2 v0.34.5 (latest: v0.37.0) [INFO] [stderr] Adding sdl2-sys v0.34.5 (latest: v0.37.0) [INFO] [stderr] Adding version-compare v0.0.10 (latest: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7f07f0b6a002cb199a8a965ab8fd3680d560c95cdc514c8283a436fbc76abb1c [INFO] running `Command { std: "docker" "start" "-a" "7f07f0b6a002cb199a8a965ab8fd3680d560c95cdc514c8283a436fbc76abb1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7f07f0b6a002cb199a8a965ab8fd3680d560c95cdc514c8283a436fbc76abb1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f07f0b6a002cb199a8a965ab8fd3680d560c95cdc514c8283a436fbc76abb1c", kill_on_drop: false }` [INFO] [stdout] 7f07f0b6a002cb199a8a965ab8fd3680d560c95cdc514c8283a436fbc76abb1c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91ab027446963a68ae1124c13a2a2962757e0b2bcca1486e9618d0f802262391 [INFO] running `Command { std: "docker" "start" "-a" "91ab027446963a68ae1124c13a2a2962757e0b2bcca1486e9618d0f802262391", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling version-compare v0.0.10 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling sdl2 v0.34.5 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking factor v0.4.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling sdl2-sys v0.34.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking raycast v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `factor::factor::factor` [INFO] [stdout] --> src/app.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use factor::factor::factor; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lazy_static::lazy_static` [INFO] [stdout] --> src/app.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use lazy_static::lazy_static; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `remap` [INFO] [stdout] --> src/math/vector.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::state::{remap, remap_minz}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/state.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/state.rs:185:30 [INFO] [stdout] | [INFO] [stdout] 185 | let minimap_offset = (dims.0.max(dims.1) / 4.); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 185 - let minimap_offset = (dims.0.max(dims.1) / 4.); [INFO] [stdout] 185 + let minimap_offset = dims.0.max(dims.1) / 4.; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `factor::factor::factor` [INFO] [stdout] --> src/app.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use factor::factor::factor; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lazy_static::lazy_static` [INFO] [stdout] --> src/app.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use lazy_static::lazy_static; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `remap` [INFO] [stdout] --> src/math/vector.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::state::{remap, remap_minz}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/state.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/state.rs:185:30 [INFO] [stdout] | [INFO] [stdout] 185 | let minimap_offset = (dims.0.max(dims.1) / 4.); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 185 - let minimap_offset = (dims.0.max(dims.1) / 4.); [INFO] [stdout] 185 + let minimap_offset = dims.0.max(dims.1) / 4.; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end_angle` [INFO] [stdout] --> src/state.rs:112:13 [INFO] [stdout] | [INFO] [stdout] 112 | let end_angle = current_angle + (self.radian_per_column * self.resolution as f64); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_end_angle` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end_angle` [INFO] [stdout] --> src/state.rs:112:13 [INFO] [stdout] | [INFO] [stdout] 112 | let end_angle = current_angle + (self.radian_per_column * self.resolution as f64); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_end_angle` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/map.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | Io(std::io::Error), [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MapError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 8 | Io(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/map.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | Io(std::io::Error), [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MapError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 8 | Io(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/map.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | Json(serde_json::Error), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MapError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 9 | Json(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/map.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | Json(serde_json::Error), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MapError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 9 | Json(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 72 | let sdl_context = sdl2::init()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let video_subsystem = sdl_context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let event_pump = sdl_context.event_pump()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let window = video_subsystem [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let mut canvas = window.into_canvas().build().map_err(|e| e.to_string())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 95 | | canvas, [INFO] [stdout] 96 | | event_pump, [INFO] [stdout] 97 | | state, [INFO] [stdout] 98 | | cfg: AppConfig::default().set_max_fps(144), // .show_fps_counter(false), [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 72 | let sdl_context = sdl2::init()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let video_subsystem = sdl_context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let event_pump = sdl_context.event_pump()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let window = video_subsystem [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let mut canvas = window.into_canvas().build().map_err(|e| e.to_string())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 95 | | canvas, [INFO] [stdout] 96 | | event_pump, [INFO] [stdout] 97 | | state, [INFO] [stdout] 98 | | cfg: AppConfig::default().set_max_fps(144), // .show_fps_counter(false), [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Origin` should have an upper case name [INFO] [stdout] --> src/math/vector.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | pub const Origin: Self = Self { [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `ORIGIN` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Origin` should have an upper case name [INFO] [stdout] --> src/math/vector.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | pub const Origin: Self = Self { [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `ORIGIN` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raycast` (bin "raycast" test) due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `raycast` (bin "raycast") due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "91ab027446963a68ae1124c13a2a2962757e0b2bcca1486e9618d0f802262391", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91ab027446963a68ae1124c13a2a2962757e0b2bcca1486e9618d0f802262391", kill_on_drop: false }` [INFO] [stdout] 91ab027446963a68ae1124c13a2a2962757e0b2bcca1486e9618d0f802262391