[INFO] cloning repository https://github.com/charlielu05/nand2tetris-assembler-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/charlielu05/nand2tetris-assembler-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcharlielu05%2Fnand2tetris-assembler-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcharlielu05%2Fnand2tetris-assembler-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 06a27afd5e3edaff3d314dfe0b5fb9d059592a1b [INFO] checking charlielu05/nand2tetris-assembler-rust/06a27afd5e3edaff3d314dfe0b5fb9d059592a1b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcharlielu05%2Fnand2tetris-assembler-rust" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/charlielu05/nand2tetris-assembler-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/charlielu05/nand2tetris-assembler-rust [INFO] finished tweaking git repo https://github.com/charlielu05/nand2tetris-assembler-rust [INFO] tweaked toml for git repo https://github.com/charlielu05/nand2tetris-assembler-rust written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/charlielu05/nand2tetris-assembler-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9ac87630a09bf743c970d599383ac8bbe8b530c7ce8af6aacc83ce3bd43e4cf [INFO] running `Command { std: "docker" "start" "-a" "e9ac87630a09bf743c970d599383ac8bbe8b530c7ce8af6aacc83ce3bd43e4cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9ac87630a09bf743c970d599383ac8bbe8b530c7ce8af6aacc83ce3bd43e4cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9ac87630a09bf743c970d599383ac8bbe8b530c7ce8af6aacc83ce3bd43e4cf", kill_on_drop: false }` [INFO] [stdout] e9ac87630a09bf743c970d599383ac8bbe8b530c7ce8af6aacc83ce3bd43e4cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae4f4d6259a8b4b4eb1557382d70ffe2512a11b2e4206f15bc8a1d80de237db6 [INFO] running `Command { std: "docker" "start" "-a" "ae4f4d6259a8b4b4eb1557382d70ffe2512a11b2e4206f15bc8a1d80de237db6", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking hack_assembler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/assembler.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::{read_to_string, File}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Code` and `SymbolTable` [INFO] [stdout] --> src/lib.rs:5:56 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::assembler::{parse_filename, read_lines, Code, Parser, SymbolTable}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/assembler.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::{read_to_string, File}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `contains` is never used [INFO] [stdout] --> src/assembler.rs:216:8 [INFO] [stdout] | [INFO] [stdout] 180 | impl SymbolTable { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 216 | fn contains(&self, key: &str) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `currentLine` should have a snake case name [INFO] [stdout] --> src/assembler.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | currentLine: usize, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `current_line` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `currentInstruction` should have a snake case name [INFO] [stdout] --> src/assembler.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | currentInstruction: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `current_instruction` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `hasMoreLines` should have a snake case name [INFO] [stdout] --> src/assembler.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn hasMoreLines(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `has_more_lines` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `instructionType` should have a snake case name [INFO] [stdout] --> src/assembler.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn instructionType(&self) -> Option<&str> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `instruction_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assembler.rs:78:15 [INFO] [stdout] | [INFO] [stdout] 76 | let re = Regex::new(r"^(?P[^=]*?)\s*=").unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | // dbg!(re.captures(&self.currentInstruction)); [INFO] [stdout] 78 | match re.captures(&self.currentInstruction) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assembler.rs:90:15 [INFO] [stdout] | [INFO] [stdout] 85 | let re = Regex::new( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | match re.captures(&self.currentInstruction) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assembler.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 97 | let re = Regex::new(r"(?:.*;\s*)(?P\S*)").unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | // dbg!(re.captures(&self.currentInstruction)); [INFO] [stdout] 99 | match re.captures(&self.currentInstruction) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `addEntry` should have a snake case name [INFO] [stdout] --> src/assembler.rs:212:8 [INFO] [stdout] | [INFO] [stdout] 212 | fn addEntry(&mut self, key: &str, val: &usize) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `add_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `getAddress` should have a snake case name [INFO] [stdout] --> src/assembler.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 220 | fn getAddress(&self, key: &str) -> Option<&usize> { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `get_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hack_assembler` (lib test) due to 4 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `contains` is never used [INFO] [stdout] --> src/assembler.rs:216:8 [INFO] [stdout] | [INFO] [stdout] 180 | impl SymbolTable { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 216 | fn contains(&self, key: &str) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `currentLine` should have a snake case name [INFO] [stdout] --> src/assembler.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | currentLine: usize, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `current_line` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `currentInstruction` should have a snake case name [INFO] [stdout] --> src/assembler.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | currentInstruction: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `current_instruction` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `hasMoreLines` should have a snake case name [INFO] [stdout] --> src/assembler.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn hasMoreLines(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `has_more_lines` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `instructionType` should have a snake case name [INFO] [stdout] --> src/assembler.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn instructionType(&self) -> Option<&str> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `instruction_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assembler.rs:78:15 [INFO] [stdout] | [INFO] [stdout] 76 | let re = Regex::new(r"^(?P[^=]*?)\s*=").unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | // dbg!(re.captures(&self.currentInstruction)); [INFO] [stdout] 78 | match re.captures(&self.currentInstruction) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assembler.rs:90:15 [INFO] [stdout] | [INFO] [stdout] 85 | let re = Regex::new( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | match re.captures(&self.currentInstruction) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assembler.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 97 | let re = Regex::new(r"(?:.*;\s*)(?P\S*)").unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | // dbg!(re.captures(&self.currentInstruction)); [INFO] [stdout] 99 | match re.captures(&self.currentInstruction) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `addEntry` should have a snake case name [INFO] [stdout] --> src/assembler.rs:212:8 [INFO] [stdout] | [INFO] [stdout] 212 | fn addEntry(&mut self, key: &str, val: &usize) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `add_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `getAddress` should have a snake case name [INFO] [stdout] --> src/assembler.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 220 | fn getAddress(&self, key: &str) -> Option<&usize> { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `get_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hack_assembler` (lib) due to 4 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ae4f4d6259a8b4b4eb1557382d70ffe2512a11b2e4206f15bc8a1d80de237db6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae4f4d6259a8b4b4eb1557382d70ffe2512a11b2e4206f15bc8a1d80de237db6", kill_on_drop: false }` [INFO] [stdout] ae4f4d6259a8b4b4eb1557382d70ffe2512a11b2e4206f15bc8a1d80de237db6