[INFO] cloning repository https://github.com/charlesbthomas/the-legend-of-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/charlesbthomas/the-legend-of-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcharlesbthomas%2Fthe-legend-of-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcharlesbthomas%2Fthe-legend-of-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1be001d2dc267b632c69143f737008afa2103c5f [INFO] checking charlesbthomas/the-legend-of-rust/1be001d2dc267b632c69143f737008afa2103c5f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcharlesbthomas%2Fthe-legend-of-rust" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/charlesbthomas/the-legend-of-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/charlesbthomas/the-legend-of-rust [INFO] finished tweaking git repo https://github.com/charlesbthomas/the-legend-of-rust [INFO] tweaked toml for git repo https://github.com/charlesbthomas/the-legend-of-rust written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/charlesbthomas/the-legend-of-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d0ee409e531ed64d644370e8899cf7f47e4c3cbf34c91d7ce3c8c02d99a3e4a [INFO] running `Command { std: "docker" "start" "-a" "9d0ee409e531ed64d644370e8899cf7f47e4c3cbf34c91d7ce3c8c02d99a3e4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d0ee409e531ed64d644370e8899cf7f47e4c3cbf34c91d7ce3c8c02d99a3e4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d0ee409e531ed64d644370e8899cf7f47e4c3cbf34c91d7ce3c8c02d99a3e4a", kill_on_drop: false }` [INFO] [stdout] 9d0ee409e531ed64d644370e8899cf7f47e4c3cbf34c91d7ce3c8c02d99a3e4a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 029b5b68de8d237cd1a05a8e595bd5afd1121e9f1e1051a49791a352d2ac63ae [INFO] running `Command { std: "docker" "start" "-a" "029b5b68de8d237cd1a05a8e595bd5afd1121e9f1e1051a49791a352d2ac63ae", kill_on_drop: false }` [INFO] [stderr] Compiling xml-rs v0.8.4 [INFO] [stderr] Checking smallvec v1.8.1 [INFO] [stderr] Compiling wayland-sys v0.28.6 [INFO] [stderr] Checking libloading v0.7.3 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking bytemuck v1.9.1 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking dlib v0.5.0 [INFO] [stderr] Compiling x11-dl v2.19.1 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.5 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking xdg v2.4.1 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking safe_arch v0.5.2 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking wide v0.6.5 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking raw-window-handle v0.3.4 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Compiling wayland-scanner v0.28.6 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Compiling erased-serde v0.3.21 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Checking object-pool v0.5.4 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Checking bracket-color v0.8.2 [INFO] [stderr] Checking glow v0.10.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking andrew v0.3.1 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking bit-set v0.5.2 [INFO] [stderr] Compiling glutin_glx_sys v0.1.7 [INFO] [stderr] Compiling glutin_egl_sys v0.1.5 [INFO] [stderr] Compiling paste v1.0.7 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Checking ultraviolet v0.8.1 [INFO] [stderr] Checking bracket-random v0.8.2 [INFO] [stderr] Compiling wayland-client v0.28.6 [INFO] [stderr] Compiling wayland-protocols v0.28.6 [INFO] [stderr] Checking bracket-noise v0.8.2 [INFO] [stderr] Checking calloop v0.6.5 [INFO] [stderr] Checking bracket-geometry v0.8.3 [INFO] [stderr] Checking wayland-commons v0.28.6 [INFO] [stderr] Checking bracket-algorithm-traits v0.8.2 [INFO] [stderr] Checking bracket-pathfinding v0.8.4 [INFO] [stderr] Checking wayland-cursor v0.28.6 [INFO] [stderr] Checking wayland-egl v0.28.6 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling thiserror v1.0.31 [INFO] [stderr] Compiling legion_codegen v0.3.0 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking legion v0.3.1 [INFO] [stderr] Checking smithay-client-toolkit v0.12.3 [INFO] [stderr] Checking winit v0.24.0 [INFO] [stderr] Checking glutin v0.26.0 [INFO] [stderr] Checking bracket-terminal v0.8.5 [INFO] [stderr] Checking bracket-lib v0.8.1 [INFO] [stderr] Checking the-legend-of-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/systems/player_input.rs:62:23 [INFO] [stdout] | [INFO] [stdout] 62 | if let Ok(mut health) = ecs [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/systems/player_input.rs:62:23 [INFO] [stdout] | [INFO] [stdout] 62 | if let Ok(mut health) = ecs [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/systems/combat.rs:16:19 [INFO] [stdout] | [INFO] [stdout] 16 | if let Ok(mut health) = ecs [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/systems/fov.rs:11:26 [INFO] [stdout] | [INFO] [stdout] 11 | .for_each(|(pos, mut fov)| { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/systems/combat.rs:16:19 [INFO] [stdout] | [INFO] [stdout] 16 | if let Ok(mut health) = ecs [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 43 | let mut ecs = World::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let mut resources = Resources::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | input_systems: build_input_scheduler(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 43 | let mut ecs = World::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let mut resources = Resources::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | player_systems: build_player_scheduler(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:62:30 [INFO] [stdout] | [INFO] [stdout] 43 | let mut ecs = World::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let mut resources = Resources::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | monster_systems: build_monster_scheduler(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:190:24 [INFO] [stdout] | [INFO] [stdout] 190 | main_loop(context, State::new()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/systems/fov.rs:11:26 [INFO] [stdout] | [INFO] [stdout] 11 | .for_each(|(pos, mut fov)| { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `the-legend-of-rust` (bin "the-legend-of-rust" test) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 43 | let mut ecs = World::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let mut resources = Resources::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | input_systems: build_input_scheduler(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 43 | let mut ecs = World::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let mut resources = Resources::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | player_systems: build_player_scheduler(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:62:30 [INFO] [stdout] | [INFO] [stdout] 43 | let mut ecs = World::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let mut resources = Resources::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | monster_systems: build_monster_scheduler(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:190:24 [INFO] [stdout] | [INFO] [stdout] 190 | main_loop(context, State::new()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `the-legend-of-rust` (bin "the-legend-of-rust") due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "029b5b68de8d237cd1a05a8e595bd5afd1121e9f1e1051a49791a352d2ac63ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "029b5b68de8d237cd1a05a8e595bd5afd1121e9f1e1051a49791a352d2ac63ae", kill_on_drop: false }` [INFO] [stdout] 029b5b68de8d237cd1a05a8e595bd5afd1121e9f1e1051a49791a352d2ac63ae