[INFO] cloning repository https://github.com/chanzuckerberg/idseq-dedup [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chanzuckerberg/idseq-dedup" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchanzuckerberg%2Fidseq-dedup", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchanzuckerberg%2Fidseq-dedup'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 65f04c4cce9518e6f93837a700bd843f6745fb55 [INFO] checking chanzuckerberg/idseq-dedup/65f04c4cce9518e6f93837a700bd843f6745fb55 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchanzuckerberg%2Fidseq-dedup" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/chanzuckerberg/idseq-dedup on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/chanzuckerberg/idseq-dedup [INFO] finished tweaking git repo https://github.com/chanzuckerberg/idseq-dedup [INFO] tweaked toml for git repo https://github.com/chanzuckerberg/idseq-dedup written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/chanzuckerberg/idseq-dedup already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 14dc09b7018173cbc106e5d945fff1f93e791189f1604f2272bea13daf224b0e [INFO] running `Command { std: "docker" "start" "-a" "14dc09b7018173cbc106e5d945fff1f93e791189f1604f2272bea13daf224b0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "14dc09b7018173cbc106e5d945fff1f93e791189f1604f2272bea13daf224b0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14dc09b7018173cbc106e5d945fff1f93e791189f1604f2272bea13daf224b0e", kill_on_drop: false }` [INFO] [stdout] 14dc09b7018173cbc106e5d945fff1f93e791189f1604f2272bea13daf224b0e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6ee49f961f6501ecfd6771ce6d770fdd2cd8f7f7ad38895130e0e9275ef0f7e1 [INFO] running `Command { std: "docker" "start" "-a" "6ee49f961f6501ecfd6771ce6d770fdd2cd8f7f7ad38895130e0e9275ef0f7e1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling syn v1.0.42 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.78 [INFO] [stderr] Compiling serde_derive v1.0.116 [INFO] [stderr] Compiling serde v1.0.116 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Checking ppv-lite86 v0.2.9 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling feature-probe v0.1.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling ndarray v0.13.1 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling bv v0.11.1 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling indexmap v1.6.0 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking array-macro v1.0.5 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling bio v0.32.0 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking fixedbitset v0.2.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling newtype_derive v0.1.6 [INFO] [stderr] Checking bit-vec v0.6.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking triple_accel v0.3.4 [INFO] [stderr] Checking strum v0.18.0 [INFO] [stderr] Checking bytecount v0.6.0 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking simple-error v0.2.2 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking bit-set v0.5.2 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking petgraph v0.5.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking itertools-num v0.1.3 [INFO] [stderr] Checking ordered-float v1.1.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking statrs v0.12.0 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Compiling derive-new v0.5.8 [INFO] [stderr] Compiling snafu-derive v0.6.9 [INFO] [stderr] Compiling enum-map-derive v0.4.3 [INFO] [stderr] Compiling getset v0.0.9 [INFO] [stderr] Compiling strum_macros v0.18.0 [INFO] [stderr] Checking enum-map v0.6.3 [INFO] [stderr] Checking snafu v0.6.9 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking multimap v0.8.2 [INFO] [stderr] Checking bio-types v0.7.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking czid-dedup v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/clusters.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | Some(mut cluster) => { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clusters.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 107 | cluster_output_opt: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let cluster_csv_writer_opt = cluster_output_opt.map(csv::Writer::from_writer); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let cluster_csv_writer = cluster_csv_writer_opt [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(Clusters { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | cluster_map, [INFO] [stdout] 123 | | cluster_order, [INFO] [stdout] 124 | | cluster_csv_writer, [INFO] [stdout] 125 | | total_records: 0, [INFO] [stdout] 126 | | prefix_length_opt, [INFO] [stdout] 127 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clusters.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 115 | .map(|mut cluster_csv_writer| { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | / cluster_csv_writer [INFO] [stdout] 117 | | .write_record(vec!["representative read id", "read id"]) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clusters.rs:118:26 [INFO] [stdout] | [INFO] [stdout] 115 | .map(|mut cluster_csv_writer| { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | .map(|_| Some(cluster_csv_writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clusters.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 133 | cluster_output_path_opt: Option

, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / cluster_output_path_opt [INFO] [stdout] 138 | | .map(|cluster_output_path| { [INFO] [stdout] 139 | | File::create(cluster_output_path).map(|cluster_output| Some(cluster_output)) [INFO] [stdout] 140 | | }) [INFO] [stdout] 141 | | .unwrap_or(Ok(None)) [INFO] [stdout] 142 | | .map_err(csv::Error::from) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clusters.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 138 | .map(|cluster_output_path| { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | File::create(cluster_output_path).map(|cluster_output| Some(cluster_output)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `czid-dedup` (bin "czid-dedup") due to 6 previous errors; 1 warning emitted [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/clusters.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | Some(mut cluster) => { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clusters.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 107 | cluster_output_opt: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let cluster_csv_writer_opt = cluster_output_opt.map(csv::Writer::from_writer); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let cluster_csv_writer = cluster_csv_writer_opt [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(Clusters { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | cluster_map, [INFO] [stdout] 123 | | cluster_order, [INFO] [stdout] 124 | | cluster_csv_writer, [INFO] [stdout] 125 | | total_records: 0, [INFO] [stdout] 126 | | prefix_length_opt, [INFO] [stdout] 127 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clusters.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 115 | .map(|mut cluster_csv_writer| { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | / cluster_csv_writer [INFO] [stdout] 117 | | .write_record(vec!["representative read id", "read id"]) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clusters.rs:118:26 [INFO] [stdout] | [INFO] [stdout] 115 | .map(|mut cluster_csv_writer| { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | .map(|_| Some(cluster_csv_writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clusters.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 133 | cluster_output_path_opt: Option

, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / cluster_output_path_opt [INFO] [stdout] 138 | | .map(|cluster_output_path| { [INFO] [stdout] 139 | | File::create(cluster_output_path).map(|cluster_output| Some(cluster_output)) [INFO] [stdout] 140 | | }) [INFO] [stdout] 141 | | .unwrap_or(Ok(None)) [INFO] [stdout] 142 | | .map_err(csv::Error::from) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clusters.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 138 | .map(|cluster_output_path| { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | File::create(cluster_output_path).map(|cluster_output| Some(cluster_output)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `czid-dedup` (bin "czid-dedup" test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "6ee49f961f6501ecfd6771ce6d770fdd2cd8f7f7ad38895130e0e9275ef0f7e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ee49f961f6501ecfd6771ce6d770fdd2cd8f7f7ad38895130e0e9275ef0f7e1", kill_on_drop: false }` [INFO] [stdout] 6ee49f961f6501ecfd6771ce6d770fdd2cd8f7f7ad38895130e0e9275ef0f7e1