[INFO] cloning repository https://github.com/chanq-io/vultan [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chanq-io/vultan" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchanq-io%2Fvultan", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchanq-io%2Fvultan'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b71df5e451d7ce83e1eed326a042202bc11e66d4 [INFO] checking chanq-io/vultan/b71df5e451d7ce83e1eed326a042202bc11e66d4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchanq-io%2Fvultan" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/chanq-io/vultan on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/chanq-io/vultan [INFO] finished tweaking git repo https://github.com/chanq-io/vultan [INFO] tweaked toml for git repo https://github.com/chanq-io/vultan written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/chanq-io/vultan already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff15ad271c356c6328c113fb1234b0c87a4b1000ad2749b924d0ebbc4f40d894 [INFO] running `Command { std: "docker" "start" "-a" "ff15ad271c356c6328c113fb1234b0c87a4b1000ad2749b924d0ebbc4f40d894", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff15ad271c356c6328c113fb1234b0c87a4b1000ad2749b924d0ebbc4f40d894", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff15ad271c356c6328c113fb1234b0c87a4b1000ad2749b924d0ebbc4f40d894", kill_on_drop: false }` [INFO] [stdout] ff15ad271c356c6328c113fb1234b0c87a4b1000ad2749b924d0ebbc4f40d894 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 95896ebd261f4d6bc9532ac72a0d0699d70738093bf069a52502f37b59d4b415 [INFO] running `Command { std: "docker" "start" "-a" "95896ebd261f4d6bc9532ac72a0d0699d70738093bf069a52502f37b59d4b415", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling serde_derive v1.0.145 [INFO] [stderr] Compiling futures-core v0.3.25 [INFO] [stderr] Compiling semver v1.0.14 [INFO] [stderr] Compiling futures-channel v0.3.25 [INFO] [stderr] Compiling futures-task v0.3.25 [INFO] [stderr] Compiling serde v1.0.145 [INFO] [stderr] Compiling futures-util v0.3.25 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking predicates-core v1.0.3 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking futures-sink v0.3.25 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking termtree v0.2.4 [INFO] [stderr] Checking futures-io v0.3.25 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking iana-time-zone v0.1.48 [INFO] [stderr] Checking fragile v1.2.1 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking predicates-tree v1.0.5 [INFO] [stderr] Checking futures-timer v3.0.2 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking len-trait v0.6.1 [INFO] [stderr] Compiling rstest_macros v0.14.0 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking predicates v2.1.1 [INFO] [stderr] Compiling futures-macro v0.3.25 [INFO] [stderr] Compiling snafu-derive v0.7.2 [INFO] [stderr] Compiling mockall_derive v0.11.2 [INFO] [stderr] Compiling mockall_double v0.3.0 [INFO] [stderr] Checking snafu v0.7.2 [INFO] [stderr] Checking mockall v0.11.2 [INFO] [stderr] Checking futures-executor v0.3.25 [INFO] [stderr] Checking futures v0.3.25 [INFO] [stderr] Checking rstest v0.15.0 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking ron v0.8.0 [INFO] [stderr] Checking vultan v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | / file_handle [INFO] [stdout] 55 | | .write(content) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 125 | fn uid_value_pairs(items: Vec) -> Vec<(String, T)> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | / items [INFO] [stdout] 127 | | .into_iter() [INFO] [stdout] 128 | | .map(|i| (i.uid().to_string(), i)) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/card/parser.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(Clone, Debug, Deserialize, PartialEq, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vultan` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn write(&self, file_handle: FileHandle) -> Result<(), Whatever> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | / file_handle [INFO] [stdout] 55 | | .write(content) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 125 | fn uid_value_pairs(items: Vec) -> Vec<(String, T)> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | / items [INFO] [stdout] 127 | | .into_iter() [INFO] [stdout] 128 | | .map(|i| (i.uid().to_string(), i)) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/card/parser.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(Clone, Debug, Deserialize, PartialEq, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/state/card.rs:183:43 [INFO] [stdout] | [INFO] [stdout] 183 | .with(eq(expected_filepath_arg.clone())) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/card.rs:206:36 [INFO] [stdout] | [INFO] [stdout] 206 | .returning(move || Err(std::io::Error::from(std::io::ErrorKind::NotFound))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:478:36 [INFO] [stdout] | [INFO] [stdout] 478 | .returning(move || Err(std::io::Error::from(std::io::ErrorKind::NotFound))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:544:37 [INFO] [stdout] | [INFO] [stdout] 544 | .returning(move |_| Err(std::io::Error::from(std::io::ErrorKind::NotFound))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vultan` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "95896ebd261f4d6bc9532ac72a0d0699d70738093bf069a52502f37b59d4b415", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95896ebd261f4d6bc9532ac72a0d0699d70738093bf069a52502f37b59d4b415", kill_on_drop: false }` [INFO] [stdout] 95896ebd261f4d6bc9532ac72a0d0699d70738093bf069a52502f37b59d4b415