[INFO] cloning repository https://github.com/chaixiang2002/atomic [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chaixiang2002/atomic" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchaixiang2002%2Fatomic", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchaixiang2002%2Fatomic'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9069d4e36d380dc07696e02c43e65cf5fd0cb882 [INFO] checking chaixiang2002/atomic/9069d4e36d380dc07696e02c43e65cf5fd0cb882 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchaixiang2002%2Fatomic" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/chaixiang2002/atomic on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/chaixiang2002/atomic [INFO] finished tweaking git repo https://github.com/chaixiang2002/atomic [INFO] tweaked toml for git repo https://github.com/chaixiang2002/atomic written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/chaixiang2002/atomic already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e5cbb58ed58711aa3ae47364559f35d130da92e2a47c18edfbca78cbdb252d2c [INFO] running `Command { std: "docker" "start" "-a" "e5cbb58ed58711aa3ae47364559f35d130da92e2a47c18edfbca78cbdb252d2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e5cbb58ed58711aa3ae47364559f35d130da92e2a47c18edfbca78cbdb252d2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5cbb58ed58711aa3ae47364559f35d130da92e2a47c18edfbca78cbdb252d2c", kill_on_drop: false }` [INFO] [stdout] e5cbb58ed58711aa3ae47364559f35d130da92e2a47c18edfbca78cbdb252d2c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7c3eed31cf9baff37e9670e7148ee0dcb2b5ebd4f5290b0d7465642f81fbc074 [INFO] running `Command { std: "docker" "start" "-a" "7c3eed31cf9baff37e9670e7148ee0dcb2b5ebd4f5290b0d7465642f81fbc074", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_edit v0.22.15 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking atomic v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutex.rs:16:19 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | data: UnsafeCell::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutex.rs:67:27 [INFO] [stdout] | [INFO] [stdout] 66 | let mutex = std::sync::Arc::clone(&mutex); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 68 | | for _ in 0..1000 { [INFO] [stdout] 69 | | let mut guard = mutex.lock(); [INFO] [stdout] 70 | | *guard += 1; [INFO] [stdout] 71 | | } [INFO] [stdout] 72 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/semaphore.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 46 | let semaphore = Arc::clone(&semaphore_arc); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 48 | | semaphore.acquire(); [INFO] [stdout] 49 | | println!("Thread acquired semaphore"); [INFO] [stdout] 50 | | thread::sleep(std::time::Duration::from_secs(1)); [INFO] [stdout] 51 | | semaphore.release(); [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadpool.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 18 | let (sender_,receiver)=mpsc::channel(); [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | let receiver =Arc::new(Mutex::new(receiver)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | let mut workers=Vec::with_capacity(size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | sender:Some(sender_) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadpool.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 73 | fn new(id:usize,receiver:Arc>>)->Worker{ [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let thread_=thread::spawn(move|| loop { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | thread:Some(thread_) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atomic` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutex.rs:16:19 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | data: UnsafeCell::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutex.rs:67:27 [INFO] [stdout] | [INFO] [stdout] 66 | let mutex = std::sync::Arc::clone(&mutex); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 68 | | for _ in 0..1000 { [INFO] [stdout] 69 | | let mut guard = mutex.lock(); [INFO] [stdout] 70 | | *guard += 1; [INFO] [stdout] 71 | | } [INFO] [stdout] 72 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/semaphore.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 46 | let semaphore = Arc::clone(&semaphore_arc); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 48 | | semaphore.acquire(); [INFO] [stdout] 49 | | println!("Thread acquired semaphore"); [INFO] [stdout] 50 | | thread::sleep(std::time::Duration::from_secs(1)); [INFO] [stdout] 51 | | semaphore.release(); [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadpool.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 18 | let (sender_,receiver)=mpsc::channel(); [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | let receiver =Arc::new(Mutex::new(receiver)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | let mut workers=Vec::with_capacity(size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | sender:Some(sender_) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadpool.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 73 | fn new(id:usize,receiver:Arc>>)->Worker{ [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let thread_=thread::spawn(move|| loop { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | thread:Some(thread_) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atomic` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "7c3eed31cf9baff37e9670e7148ee0dcb2b5ebd4f5290b0d7465642f81fbc074", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c3eed31cf9baff37e9670e7148ee0dcb2b5ebd4f5290b0d7465642f81fbc074", kill_on_drop: false }` [INFO] [stdout] 7c3eed31cf9baff37e9670e7148ee0dcb2b5ebd4f5290b0d7465642f81fbc074