[INFO] cloning repository https://github.com/cestef/raytracing-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cestef/raytracing-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcestef%2Fraytracing-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcestef%2Fraytracing-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 57798a4ebc3d5a10191c558bbbb195c1f6e11562 [INFO] checking cestef/raytracing-rust/57798a4ebc3d5a10191c558bbbb195c1f6e11562 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcestef%2Fraytracing-rust" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cestef/raytracing-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cestef/raytracing-rust [INFO] finished tweaking git repo https://github.com/cestef/raytracing-rust [INFO] tweaked toml for git repo https://github.com/cestef/raytracing-rust written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cestef/raytracing-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 90fa2d022398ba4414685e4b7fee11e8ca15ef8b9537f67275e51bba03d85138 [INFO] running `Command { std: "docker" "start" "-a" "90fa2d022398ba4414685e4b7fee11e8ca15ef8b9537f67275e51bba03d85138", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "90fa2d022398ba4414685e4b7fee11e8ca15ef8b9537f67275e51bba03d85138", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90fa2d022398ba4414685e4b7fee11e8ca15ef8b9537f67275e51bba03d85138", kill_on_drop: false }` [INFO] [stdout] 90fa2d022398ba4414685e4b7fee11e8ca15ef8b9537f67275e51bba03d85138 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c21456d7be6d798e0a287c651bc318e1621866a367a6e176cba3a0f6273d7b0 [INFO] running `Command { std: "docker" "start" "-a" "5c21456d7be6d798e0a287c651bc318e1621866a367a6e176cba3a0f6273d7b0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking simd-adler32 v0.3.5 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling portable-atomic v1.3.3 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking fdeflate v0.3.0 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking half v2.3.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking flate2 v1.0.26 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking dyn-clone v1.0.11 [INFO] [stderr] Checking jpeg-encoder v0.5.1 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking png v0.17.9 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking open v4.2.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_xorshift v0.2.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking indicatif v0.17.5 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking noise v0.8.2 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.5 [INFO] [stderr] Checking jpeg-decoder v0.3.0 [INFO] [stderr] Compiling pin-project-internal v1.1.0 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Compiling dyn-clonable-impl v0.9.0 [INFO] [stderr] Checking tiff v0.8.1 [INFO] [stderr] Checking dyn-clonable v0.9.0 [INFO] [stderr] Checking pin-project v1.1.0 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking exr v1.6.4 [INFO] [stderr] Checking clap v4.3.5 [INFO] [stderr] Checking image v0.24.6 [INFO] [stderr] Checking ray-tracing-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Point3`, `image::ImageTexture`, `materials::lambertian::Lambertian`, `plane::Plane`, `solid::SolidColor`, and `sphere::Sphere` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | materials::lambertian::Lambertian, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | shapes::{bvh::BvhNode, list::HittableList, plane::Plane, sphere::Sphere}, [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] 13 | textures::{image::ImageTexture, solid::SolidColor}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | vec::{Color, Point3, Vec3}, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Point3`, `image::ImageTexture`, `materials::lambertian::Lambertian`, `plane::Plane`, `solid::SolidColor`, and `sphere::Sphere` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | materials::lambertian::Lambertian, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | shapes::{bvh::BvhNode, list::HittableList, plane::Plane, sphere::Sphere}, [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] 13 | textures::{image::ImageTexture, solid::SolidColor}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | vec::{Color, Point3, Vec3}, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/materials/mod.rs:49:30 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn with_texture($($field: $type),*, texture: Box) -> Self { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | texture: Some(texture) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/materials/dielectric.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | material!(Dielectric { n: f32 }); [INFO] [stdout] | -------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `material` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/materials/mod.rs:49:30 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn with_texture($($field: $type),*, texture: Box) -> Self { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | texture: Some(texture) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/materials/lambertian.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | material!(Lambertian { albedo: Color }); [INFO] [stdout] | --------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `material` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/materials/mod.rs:49:30 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn with_texture($($field: $type),*, texture: Box) -> Self { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | texture: Some(texture) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/materials/metal.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | / material!(Metal { [INFO] [stdout] 9 | | albedo: Color, [INFO] [stdout] 10 | | fuzz: f32 [INFO] [stdout] 11 | | }); [INFO] [stdout] | |__- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `material` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shapes/aabb.rs:61:31 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn surrounding_box(box0: AxisAlignedBoundingBox, box1: AxisAlignedBoundingBox) -> Self { [INFO] [stdout] | ---------------------------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Self::new(small, big, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shapes/animated/sphere.rs:53:14 [INFO] [stdout] | [INFO] [stdout] 43 | let box0 = AxisAlignedBoundingBox::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let box1 = AxisAlignedBoundingBox::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Some(AxisAlignedBoundingBox::surrounding_box(box0, box1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shapes/bvh.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 27 | let hit_left = self.left.hit(ray, t_min, t_max); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let hit_right = self.right.hit(ray, t_min, t_max); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | match (hit_left, hit_right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shapes/bvh.rs:110:23 [INFO] [stdout] | [INFO] [stdout] 53 | objects: Vec>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let mut objects = objects; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let (left, right) = match object_span { [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | 1 => { [INFO] [stdout] 70 | let left = objects.remove(0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let left_objects = objects.drain(..mid).collect::>(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let right_objects = objects.drain(..).collect::>(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let left_box = left.bounding_box(time0, time1).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let right_box = right.bounding_box(time0, time1).unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let bounding_box = AxisAlignedBoundingBox::surrounding_box(left_box, right_box); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | material: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/helpers.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 222 | let material = if random_float() < 0.7 { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | / Box::new(Sphere::new( [INFO] [stdout] 228 | | Point3::new( [INFO] [stdout] 229 | | random_float_range(-7.0, 7.0), [INFO] [stdout] 230 | | // random_float_range(-5.0, 5.0), [INFO] [stdout] ... | [INFO] [stdout] 235 | | Some(material), [INFO] [stdout] 236 | | )) as Box [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/job.rs:33:19 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(f: F, req: Req) -> Self [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | task: Box::new(f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/job.rs:35:26 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(f: F, req: Req) -> Self [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | result_sink: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/job.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn with_result_sink(f: F, req: Req) -> (Self, Receiver) [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let (tx, rx) = channel::(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | / Job { [INFO] [stdout] 49 | | task: Box::new(f), [INFO] [stdout] 50 | | req, [INFO] [stdout] 51 | | result_sink: Some(tx), [INFO] [stdout] 52 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/materials/mod.rs:49:30 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn with_texture($($field: $type),*, texture: Box) -> Self { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | texture: Some(texture) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/materials/dielectric.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | material!(Dielectric { n: f32 }); [INFO] [stdout] | -------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `material` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/materials/mod.rs:49:30 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn with_texture($($field: $type),*, texture: Box) -> Self { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | texture: Some(texture) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/materials/lambertian.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | material!(Lambertian { albedo: Color }); [INFO] [stdout] | --------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `material` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/pool.rs:157:19 [INFO] [stdout] | [INFO] [stdout] 151 | let (worker_vec, (done_tx, done_rx)) = Self::new_workers(workers); [INFO] [stdout] | ---------- ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let worker_pool = Arc::new(Mutex::new(BinaryMaxHeap::from_vec(worker_vec))); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let balancer = Self::balancer_thread(done_rx, Arc::clone(&worker_pool)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | pool: Some(worker_pool), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/pool.rs:159:23 [INFO] [stdout] | [INFO] [stdout] 151 | let (worker_vec, (done_tx, done_rx)) = Self::new_workers(workers); [INFO] [stdout] | ---------- ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let worker_pool = Arc::new(Mutex::new(BinaryMaxHeap::from_vec(worker_vec))); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let balancer = Self::balancer_thread(done_rx, Arc::clone(&worker_pool)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | balancer: Some(balancer), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/materials/mod.rs:49:30 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn with_texture($($field: $type),*, texture: Box) -> Self { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | texture: Some(texture) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/materials/metal.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | / material!(Metal { [INFO] [stdout] 9 | | albedo: Color, [INFO] [stdout] 10 | | fuzz: f32 [INFO] [stdout] 11 | | }); [INFO] [stdout] | |__- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `material` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/pool.rs:178:23 [INFO] [stdout] | [INFO] [stdout] 175 | done_channel: Receiver>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | worker_heap: Arc>>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | ) -> JoinHandle> { [INFO] [stdout] 178 | thread::spawn(move || -> Result<(), ThreadPoolError> { [INFO] [stdout] | _______________________^ [INFO] [stdout] 179 | | while let Ok(Some(uid)) = done_channel.recv() { [INFO] [stdout] 180 | | restore_worker_pool_order( [INFO] [stdout] 181 | | worker_heap [INFO] [stdout] ... | [INFO] [stdout] 189 | | Ok(()) [INFO] [stdout] 190 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/pool.rs:221:22 [INFO] [stdout] | [INFO] [stdout] 208 | let (done_tx, done_rx) = channel::>(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | let mut worker_vec = Vec::>::with_capacity(workers); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | (worker_vec, (done_tx, done_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shapes/aabb.rs:61:31 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn surrounding_box(box0: AxisAlignedBoundingBox, box1: AxisAlignedBoundingBox) -> Self { [INFO] [stdout] | ---------------------------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Self::new(small, big, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shapes/animated/sphere.rs:53:14 [INFO] [stdout] | [INFO] [stdout] 43 | let box0 = AxisAlignedBoundingBox::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let box1 = AxisAlignedBoundingBox::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Some(AxisAlignedBoundingBox::surrounding_box(box0, box1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/worker.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 118 | job_source: Receiver>, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | disp_q: Sender>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | done: Sender>, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | worker: Some(Self::worker_thread(job_source, done, uid)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/worker.rs:149:23 [INFO] [stdout] | [INFO] [stdout] 145 | jobs: Receiver>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | done: Sender>, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | thread::spawn(move || -> Result<(), WorkerError> { [INFO] [stdout] | _______________________^ [INFO] [stdout] 150 | | while let Ok(Message::Request(job)) = jobs.recv() { [INFO] [stdout] 151 | | job.resp_with_result() [INFO] [stdout] 152 | | .or(Err(WorkerError::ResultResponseFailed))?; [INFO] [stdout] ... | [INFO] [stdout] 158 | | Ok(()) [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shapes/bvh.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 27 | let hit_left = self.left.hit(ray, t_min, t_max); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let hit_right = self.right.hit(ray, t_min, t_max); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | match (hit_left, hit_right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/worker.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn dispatch(&self, job: Job) -> Result<(), WorkerError> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | / self.disp_q [INFO] [stdout] 166 | | .send(Message::Request(job)) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shapes/bvh.rs:110:23 [INFO] [stdout] | [INFO] [stdout] 53 | objects: Vec>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let mut objects = objects; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let (left, right) = match object_span { [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | 1 => { [INFO] [stdout] 70 | let left = objects.remove(0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let left_objects = objects.drain(..mid).collect::>(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let right_objects = objects.drain(..).collect::>(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let left_box = left.bounding_box(time0, time1).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let right_box = right.bounding_box(time0, time1).unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let bounding_box = AxisAlignedBoundingBox::surrounding_box(left_box, right_box); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | material: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/helpers.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 222 | let material = if random_float() < 0.7 { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | / Box::new(Sphere::new( [INFO] [stdout] 228 | | Point3::new( [INFO] [stdout] 229 | | random_float_range(-7.0, 7.0), [INFO] [stdout] 230 | | // random_float_range(-5.0, 5.0), [INFO] [stdout] ... | [INFO] [stdout] 235 | | Some(material), [INFO] [stdout] 236 | | )) as Box [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/job.rs:33:19 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(f: F, req: Req) -> Self [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | task: Box::new(f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/job.rs:35:26 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(f: F, req: Req) -> Self [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | result_sink: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/job.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn with_result_sink(f: F, req: Req) -> (Self, Receiver) [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let (tx, rx) = channel::(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | / Job { [INFO] [stdout] 49 | | task: Box::new(f), [INFO] [stdout] 50 | | req, [INFO] [stdout] 51 | | result_sink: Some(tx), [INFO] [stdout] 52 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/pool.rs:157:19 [INFO] [stdout] | [INFO] [stdout] 151 | let (worker_vec, (done_tx, done_rx)) = Self::new_workers(workers); [INFO] [stdout] | ---------- ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let worker_pool = Arc::new(Mutex::new(BinaryMaxHeap::from_vec(worker_vec))); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let balancer = Self::balancer_thread(done_rx, Arc::clone(&worker_pool)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | pool: Some(worker_pool), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/pool.rs:159:23 [INFO] [stdout] | [INFO] [stdout] 151 | let (worker_vec, (done_tx, done_rx)) = Self::new_workers(workers); [INFO] [stdout] | ---------- ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let worker_pool = Arc::new(Mutex::new(BinaryMaxHeap::from_vec(worker_vec))); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let balancer = Self::balancer_thread(done_rx, Arc::clone(&worker_pool)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | balancer: Some(balancer), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/pool.rs:178:23 [INFO] [stdout] | [INFO] [stdout] 175 | done_channel: Receiver>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | worker_heap: Arc>>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | ) -> JoinHandle> { [INFO] [stdout] 178 | thread::spawn(move || -> Result<(), ThreadPoolError> { [INFO] [stdout] | _______________________^ [INFO] [stdout] 179 | | while let Ok(Some(uid)) = done_channel.recv() { [INFO] [stdout] 180 | | restore_worker_pool_order( [INFO] [stdout] 181 | | worker_heap [INFO] [stdout] ... | [INFO] [stdout] 189 | | Ok(()) [INFO] [stdout] 190 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/pool.rs:221:22 [INFO] [stdout] | [INFO] [stdout] 208 | let (done_tx, done_rx) = channel::>(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | let mut worker_vec = Vec::>::with_capacity(workers); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | (worker_vec, (done_tx, done_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/worker.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 118 | job_source: Receiver>, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | disp_q: Sender>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | done: Sender>, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | worker: Some(Self::worker_thread(job_source, done, uid)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/worker.rs:149:23 [INFO] [stdout] | [INFO] [stdout] 145 | jobs: Receiver>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | done: Sender>, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | thread::spawn(move || -> Result<(), WorkerError> { [INFO] [stdout] | _______________________^ [INFO] [stdout] 150 | | while let Ok(Message::Request(job)) = jobs.recv() { [INFO] [stdout] 151 | | job.resp_with_result() [INFO] [stdout] 152 | | .or(Err(WorkerError::ResultResponseFailed))?; [INFO] [stdout] ... | [INFO] [stdout] 158 | | Ok(()) [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads/worker.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn dispatch(&self, job: Job) -> Result<(), WorkerError> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | / self.disp_q [INFO] [stdout] 166 | | .send(Message::Request(job)) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ray-tracing-rust` (bin "ray-tracing-rust") due to 19 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ray-tracing-rust` (bin "ray-tracing-rust" test) due to 19 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "5c21456d7be6d798e0a287c651bc318e1621866a367a6e176cba3a0f6273d7b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c21456d7be6d798e0a287c651bc318e1621866a367a6e176cba3a0f6273d7b0", kill_on_drop: false }` [INFO] [stdout] 5c21456d7be6d798e0a287c651bc318e1621866a367a6e176cba3a0f6273d7b0