[INFO] cloning repository https://github.com/celsworth/apachetop.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/celsworth/apachetop.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcelsworth%2Fapachetop.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcelsworth%2Fapachetop.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e937ba65ae3b0e894a30dafbbdb58aefbbee3122 [INFO] checking celsworth/apachetop.rs/e937ba65ae3b0e894a30dafbbdb58aefbbee3122 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcelsworth%2Fapachetop.rs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/celsworth/apachetop.rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/celsworth/apachetop.rs [INFO] finished tweaking git repo https://github.com/celsworth/apachetop.rs [INFO] tweaked toml for git repo https://github.com/celsworth/apachetop.rs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/celsworth/apachetop.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 16aa35a58bd83eeb3ccd3550ad64c4ef38ee69aceeb20f1aa1507bf8793dca17 [INFO] running `Command { std: "docker" "start" "-a" "16aa35a58bd83eeb3ccd3550ad64c4ef38ee69aceeb20f1aa1507bf8793dca17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "16aa35a58bd83eeb3ccd3550ad64c4ef38ee69aceeb20f1aa1507bf8793dca17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16aa35a58bd83eeb3ccd3550ad64c4ef38ee69aceeb20f1aa1507bf8793dca17", kill_on_drop: false }` [INFO] [stdout] 16aa35a58bd83eeb3ccd3550ad64c4ef38ee69aceeb20f1aa1507bf8793dca17 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b332766e608a124a61fba0e8ef79238526d8db5c24145e235400f24699e23d4b [INFO] running `Command { std: "docker" "start" "-a" "b332766e608a124a61fba0e8ef79238526d8db5c24145e235400f24699e23d4b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling syn v1.0.33 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.3 [INFO] [stderr] Compiling proc-macro-error v1.0.3 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking smallvec v1.4.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking mio v0.7.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling anyhow v1.0.31 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking signal-hook v0.1.16 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Checking crossterm v0.17.7 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking chrono v0.4.13 [INFO] [stderr] Checking log-panics v2.0.0 [INFO] [stderr] Checking strum v0.18.0 [INFO] [stderr] Checking lazysort v0.2.1 [INFO] [stderr] Checking fern v0.5.9 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling strum_macros v0.18.0 [INFO] [stderr] Compiling structopt-derive v0.4.8 [INFO] [stderr] Checking structopt v0.3.15 [INFO] [stderr] Checking apachetop v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `trace` and `warn` [INFO] [stdout] --> src/prelude.rs:3:35 [INFO] [stdout] | [INFO] [stdout] 3 | pub use log::{debug, error, info, trace, warn}; [INFO] [stdout] | ^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `trace` and `warn` [INFO] [stdout] --> src/prelude.rs:3:35 [INFO] [stdout] | [INFO] [stdout] 3 | pub use log::{debug, error, info, trace, warn}; [INFO] [stdout] | ^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `options` and `logfiles` are never read [INFO] [stdout] --> src/app.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct App { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 9 | options: Arc>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 12 | logfiles: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/logfile.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Logfile { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 10 | pub path: std::path::PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 25 | let (request_tx, request_rx): (Sender, Receiver) = unbounded(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let options = Arc::new(Mutex::new(options)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let alltime_stats = Arc::new(Mutex::new(Stats::new())); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let ring_buffer = Arc::new(Mutex::new(RingBuffer::new(Arc::clone(&options), true)?)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let window = Window::new(Arc::clone(&options), alltime_stats, ring_buffer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | Ok(App { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | options, [INFO] [stdout] 47 | | logfiles, [INFO] [stdout] 48 | | window, [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `options` and `logfiles` are never read [INFO] [stdout] --> src/app.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct App { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 9 | options: Arc>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 12 | logfiles: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/logfile.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Logfile { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 10 | pub path: std::path::PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 25 | let (request_tx, request_rx): (Sender, Receiver) = unbounded(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let options = Arc::new(Mutex::new(options)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let alltime_stats = Arc::new(Mutex::new(Stats::new())); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let ring_buffer = Arc::new(Mutex::new(RingBuffer::new(Arc::clone(&options), true)?)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let window = Window::new(Arc::clone(&options), alltime_stats, ring_buffer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | Ok(App { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | options, [INFO] [stdout] 47 | | logfiles, [INFO] [stdout] 48 | | window, [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:30:44 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|file| Logfile::new(file, request_tx.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 77 | request_rx: Receiver, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | alltime_stats: Arc>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | ring_buffer: Arc>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | ) -> Result>, Error> { [INFO] [stdout] 81 | let c = move || { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(thread::Builder::new() [INFO] [stdout] | ____________^ [INFO] [stdout] 100 | | .name("request_rx".to_string()) [INFO] [stdout] 101 | | .spawn(c)?) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:30:44 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|file| Logfile::new(file, request_tx.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 77 | request_rx: Receiver, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | alltime_stats: Arc>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | ring_buffer: Arc>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | ) -> Result>, Error> { [INFO] [stdout] 81 | let c = move || { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(thread::Builder::new() [INFO] [stdout] | ____________^ [INFO] [stdout] 100 | | .name("request_rx".to_string()) [INFO] [stdout] 101 | | .spawn(c)?) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logfile.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 21 | request_tx: Sender, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let mut fh = std::fs::File::open(&path) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let mut br = std::io::BufReader::new(fh); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | let c = move || -> Result<_, _> { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(thread::Builder::new().name(thread_name).spawn(c)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / /// Main table sort order column [INFO] [stdout] 13 | | /// [INFO] [stdout] 14 | | /// Can be either requests or size. [INFO] [stdout] 15 | | #[structopt(short, long, default_value = "requests")] [INFO] [stdout] 16 | | pub order: Order, // see bottom of file [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / /// Group requests [INFO] [stdout] 19 | | /// [INFO] [stdout] 20 | | /// Determines how to aggregate statistics. By default the request URI [INFO] [stdout] 21 | | /// is used. [INFO] [stdout] ... | [INFO] [stdout] 25 | | #[structopt(short, long, default_value = "uri")] [INFO] [stdout] 26 | | pub group: GroupBy, [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ring_buffer.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(options: Arc>, with_grouped: bool) -> Result { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let grouped = if with_grouped { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | stats: Stats::new(), [INFO] [stdout] 34 | | options, [INFO] [stdout] 35 | | buffer: VecDeque::>::with_capacity(size as usize), [INFO] [stdout] 36 | | grouped, [INFO] [stdout] 37 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logfile.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 21 | request_tx: Sender, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let mut fh = std::fs::File::open(&path) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let mut br = std::io::BufReader::new(fh); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | let c = move || -> Result<_, _> { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(thread::Builder::new().name(thread_name).spawn(c)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / /// Main table sort order column [INFO] [stdout] 13 | | /// [INFO] [stdout] 14 | | /// Can be either requests or size. [INFO] [stdout] 15 | | #[structopt(short, long, default_value = "requests")] [INFO] [stdout] 16 | | pub order: Order, // see bottom of file [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / /// Group requests [INFO] [stdout] 19 | | /// [INFO] [stdout] 20 | | /// Determines how to aggregate statistics. By default the request URI [INFO] [stdout] 21 | | /// is used. [INFO] [stdout] ... | [INFO] [stdout] 25 | | #[structopt(short, long, default_value = "uri")] [INFO] [stdout] 26 | | pub group: GroupBy, [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ring_buffer.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(options: Arc>, with_grouped: bool) -> Result { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let grouped = if with_grouped { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | stats: Stats::new(), [INFO] [stdout] 34 | | options, [INFO] [stdout] 35 | | buffer: VecDeque::>::with_capacity(size as usize), [INFO] [stdout] 36 | | grouped, [INFO] [stdout] 37 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `apachetop` (bin "apachetop") due to 8 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `apachetop` (bin "apachetop" test) due to 8 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b332766e608a124a61fba0e8ef79238526d8db5c24145e235400f24699e23d4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b332766e608a124a61fba0e8ef79238526d8db5c24145e235400f24699e23d4b", kill_on_drop: false }` [INFO] [stdout] b332766e608a124a61fba0e8ef79238526d8db5c24145e235400f24699e23d4b