[INFO] cloning repository https://github.com/celaltas/crabcache [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/celaltas/crabcache" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcelaltas%2Fcrabcache", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcelaltas%2Fcrabcache'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ace061b76a67061c67310eb6a08e9f0f90b8b181 [INFO] checking celaltas/crabcache/ace061b76a67061c67310eb6a08e9f0f90b8b181 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcelaltas%2Fcrabcache" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/celaltas/crabcache on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/celaltas/crabcache [INFO] finished tweaking git repo https://github.com/celaltas/crabcache [INFO] tweaked toml for git repo https://github.com/celaltas/crabcache written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/celaltas/crabcache already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 91745b7c90ce56a557b35f1730cc3a7dc835c3efb075c45015c9350079d4cc8f [INFO] running `Command { std: "docker" "start" "-a" "91745b7c90ce56a557b35f1730cc3a7dc835c3efb075c45015c9350079d4cc8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "91745b7c90ce56a557b35f1730cc3a7dc835c3efb075c45015c9350079d4cc8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91745b7c90ce56a557b35f1730cc3a7dc835c3efb075c45015c9350079d4cc8f", kill_on_drop: false }` [INFO] [stdout] 91745b7c90ce56a557b35f1730cc3a7dc835c3efb075c45015c9350079d4cc8f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6a4c34de6fa74d26f5af18b8b7649a81a476f718cf1fdf74173d02d892e769ed [INFO] running `Command { std: "docker" "start" "-a" "6a4c34de6fa74d26f5af18b8b7649a81a476f718cf1fdf74173d02d892e769ed", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking mio v1.0.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking container_of v0.5.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling quickcheck_macros v0.8.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking quickcheck v0.8.5 [INFO] [stderr] Checking crabcache v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/serialization.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arbitrary` and `Gen` [INFO] [stdout] --> src/avl_tree/set.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use quickcheck::{Arbitrary, Gen}; [INFO] [stdout] | ^^^^^^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/serialization.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ByteOrder` [INFO] [stdout] --> src/serialization.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use byteorder::{ByteOrder, LittleEndian, WriteBytesExt}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Data` is never constructed [INFO] [stdout] --> src/entry.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | struct Data { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/entry.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 38 | impl Data { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 39 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `delete`, `rebalance_path`, `iter`, and `node_iter` are never used [INFO] [stdout] --> src/avl_tree/set.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 27 | impl<'a, T: 'a + Ord + Debug> AvlTreeSet { [INFO] [stdout] | ------------------------------------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn delete(&mut self, value: &T) -> Result<(), DeleteError> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 118 | fn rebalance_path(path: &[*mut AvlNode]) -> Result<(), DeleteError> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 156 | pub fn iter(&'a self) -> impl Iterator + 'a { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 160 | fn node_iter(&'a self) -> impl Iterator> + 'a { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AvlTreeSetIter` is never constructed [INFO] [stdout] --> src/avl_tree/set.rs:190:8 [INFO] [stdout] | [INFO] [stdout] 190 | struct AvlTreeSetIter<'a, T: Ord> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ByteOrder` [INFO] [stdout] --> src/serialization.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use byteorder::{ByteOrder, LittleEndian, WriteBytesExt}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/commands/del.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | drop(entry); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&entry::Entry` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 23 - drop(entry); [INFO] [stdout] 23 + let _ = entry; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashtable.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 60 | let mut table = Vec::with_capacity(n); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Self { table, size, mask }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashtable.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn drain(&mut self, range: R) -> impl Iterator> + '_ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | self.table.drain(range).filter_map(|node| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crabcache` (bin "crabcache") due to 3 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `Data` is never constructed [INFO] [stdout] --> src/entry.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | struct Data { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/entry.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 38 | impl Data { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 39 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/commands/del.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | drop(entry); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&entry::Entry` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 23 - drop(entry); [INFO] [stdout] 23 + let _ = entry; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashtable.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 60 | let mut table = Vec::with_capacity(n); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Self { table, size, mask }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashtable.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn drain(&mut self, range: R) -> impl Iterator> + '_ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | self.table.drain(range).filter_map(|node| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avl_tree/set.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 171 | let vec: Vec = Arbitrary::arbitrary(g); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | vec.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avl_tree/set.rs:176:18 [INFO] [stdout] | [INFO] [stdout] 175 | let vec: Vec = self.iter().cloned().collect(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Box::new(vec.shrink().map(|v| v.into_iter().collect::())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avl_tree/set.rs:176:39 [INFO] [stdout] | [INFO] [stdout] 176 | Box::new(vec.shrink().map(|v| v.into_iter().collect::())) [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avl_tree/set.rs:245:13 [INFO] [stdout] | [INFO] [stdout] 244 | fn test_node_height(set: AvlTreeSet) -> bool { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | all(set.node_iter(), |node| { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avl_tree/set.rs:253:37 [INFO] [stdout] | [INFO] [stdout] 252 | let set = btree.iter().cloned().collect::>(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | TestResult::from_bool(equal(set.iter(), btree.iter())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avl_tree/set.rs:258:13 [INFO] [stdout] | [INFO] [stdout] 257 | fn balanced_nodes(set: AvlTreeSet) -> bool { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | all(set.node_iter(), |node| node.balance_factor().abs() < 2) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crabcache` (bin "crabcache" test) due to 9 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6a4c34de6fa74d26f5af18b8b7649a81a476f718cf1fdf74173d02d892e769ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a4c34de6fa74d26f5af18b8b7649a81a476f718cf1fdf74173d02d892e769ed", kill_on_drop: false }` [INFO] [stdout] 6a4c34de6fa74d26f5af18b8b7649a81a476f718cf1fdf74173d02d892e769ed