[INFO] cloning repository https://github.com/cecton/cargo-git [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cecton/cargo-git" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcecton%2Fcargo-git", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcecton%2Fcargo-git'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c4ddc3706aed1d33f623e2d29a283506cda89bca [INFO] checking cecton/cargo-git/c4ddc3706aed1d33f623e2d29a283506cda89bca against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcecton%2Fcargo-git" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cecton/cargo-git on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cecton/cargo-git [INFO] finished tweaking git repo https://github.com/cecton/cargo-git [INFO] tweaked toml for git repo https://github.com/cecton/cargo-git written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cecton/cargo-git already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4f7061d5f32c6e8c93591c5d775143a7dedb36ec55a8e5d2d5a7cd518c836360 [INFO] running `Command { std: "docker" "start" "-a" "4f7061d5f32c6e8c93591c5d775143a7dedb36ec55a8e5d2d5a7cd518c836360", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4f7061d5f32c6e8c93591c5d775143a7dedb36ec55a8e5d2d5a7cd518c836360", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f7061d5f32c6e8c93591c5d775143a7dedb36ec55a8e5d2d5a7cd518c836360", kill_on_drop: false }` [INFO] [stdout] 4f7061d5f32c6e8c93591c5d775143a7dedb36ec55a8e5d2d5a7cd518c836360 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 14d2bbf2e53e05c812e42bae492442fc59f69a63c0238f4893c0634d34c034d3 [INFO] running `Command { std: "docker" "start" "-a" "14d2bbf2e53e05c812e42bae492442fc59f69a63c0238f4893c0634d34c034d3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling pkg-config v0.3.29 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling unicode-segmentation v1.10.1 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling jobserver v0.1.27 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking bstr v1.9.0 [INFO] [stderr] Checking tempfile v3.10.0 [INFO] [stderr] Checking radium v0.3.0 [INFO] [stderr] Checking dialoguer v0.10.4 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking dirs v3.0.2 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking bitvec v0.17.4 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Compiling openssl-sys v0.9.99 [INFO] [stderr] Compiling libz-sys v1.1.15 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.16.1+1.7.1 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling pest v2.7.7 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Compiling pest_meta v2.7.7 [INFO] [stderr] Compiling pest_generator v2.7.7 [INFO] [stderr] Compiling pest_derive v2.7.7 [INFO] [stderr] Checking git2 v0.18.1 [INFO] [stderr] Checking git2_credentials v0.13.0 [INFO] [stderr] Checking git-tools v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `PushOptions` [INFO] [stdout] --> src/common.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | MergeOptions, PushOptions, RemoteCallbacks, Sort, StatusOptions, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/git-delete.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PushOptions` [INFO] [stdout] --> src/common.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | MergeOptions, PushOptions, RemoteCallbacks, Sort, StatusOptions, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PushOptions` [INFO] [stdout] --> src/common.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | MergeOptions, PushOptions, RemoteCallbacks, Sort, StatusOptions, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PushOptions` [INFO] [stdout] --> src/common.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | MergeOptions, PushOptions, RemoteCallbacks, Sort, StatusOptions, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/git-delete.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PushOptions` [INFO] [stdout] --> src/common.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | MergeOptions, PushOptions, RemoteCallbacks, Sort, StatusOptions, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PushOptions` [INFO] [stdout] --> src/common.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | MergeOptions, PushOptions, RemoteCallbacks, Sort, StatusOptions, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PushOptions` [INFO] [stdout] --> src/common.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | MergeOptions, PushOptions, RemoteCallbacks, Sort, StatusOptions, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PushOptions` [INFO] [stdout] --> src/common.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | MergeOptions, PushOptions, RemoteCallbacks, Sort, StatusOptions, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 28 | let repo = Repository::open(".")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let config = repo.config()?.snapshot()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | Ok(Git { [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | repo, [INFO] [stdout] 62 | | head_message, [INFO] [stdout] 63 | | head_hash, [INFO] [stdout] ... | [INFO] [stdout] 66 | | config, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 168 | let tree = self.repo.head()?.peel_to_tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | [INFO] [stdout] 170 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | .repo [INFO] [stdout] 172 | | .diff_tree_to_workdir_with_index(Some(&tree), None)? [INFO] [stdout] 173 | | .stats()? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 273 | let mut revwalk = self.repo.revwalk()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | let from_object = self.repo.revparse_single(from)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let to_object = self.repo.revparse_single(to)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | / revwalk [INFO] [stdout] 286 | | .map(|x| x.map(|x| format!("{}", x))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 275 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 315 | let object = self.repo.revparse_single(rev)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let commit = object.peel_to_commit()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | [INFO] [stdout] 318 | Ok(Ancestors { [INFO] [stdout] | ____________^ [INFO] [stdout] 319 | | current: Some(commit), [INFO] [stdout] 320 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-tools` (bin "git-fork") due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git-push2.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 43 | let git = Git::open()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | Err(match (git.branch_name.as_ref(), git.upstream.as_ref()) { [INFO] [stdout] | _________^ [INFO] [stdout] 46 | | (Some(name), None) => Command::new("git") [INFO] [stdout] 47 | | .arg("push") [INFO] [stdout] 48 | | .args(&["--set-upstream", "origin", name]) [INFO] [stdout] ... | [INFO] [stdout] 56 | | .into(), [INFO] [stdout] 57 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 28 | let repo = Repository::open(".")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let config = repo.config()?.snapshot()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | Ok(Git { [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | repo, [INFO] [stdout] 62 | | head_message, [INFO] [stdout] 63 | | head_hash, [INFO] [stdout] ... | [INFO] [stdout] 66 | | config, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 168 | let tree = self.repo.head()?.peel_to_tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | [INFO] [stdout] 170 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | .repo [INFO] [stdout] 172 | | .diff_tree_to_workdir_with_index(Some(&tree), None)? [INFO] [stdout] 173 | | .stats()? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 28 | let repo = Repository::open(".")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let config = repo.config()?.snapshot()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | Ok(Git { [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | repo, [INFO] [stdout] 62 | | head_message, [INFO] [stdout] 63 | | head_hash, [INFO] [stdout] ... | [INFO] [stdout] 66 | | config, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 168 | let tree = self.repo.head()?.peel_to_tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | [INFO] [stdout] 170 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | .repo [INFO] [stdout] 172 | | .diff_tree_to_workdir_with_index(Some(&tree), None)? [INFO] [stdout] 173 | | .stats()? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 273 | let mut revwalk = self.repo.revwalk()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | let from_object = self.repo.revparse_single(from)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let to_object = self.repo.revparse_single(to)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | / revwalk [INFO] [stdout] 286 | | .map(|x| x.map(|x| format!("{}", x))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 273 | let mut revwalk = self.repo.revwalk()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | let from_object = self.repo.revparse_single(from)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let to_object = self.repo.revparse_single(to)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | / revwalk [INFO] [stdout] 286 | | .map(|x| x.map(|x| format!("{}", x))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 275 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 315 | let object = self.repo.revparse_single(rev)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let commit = object.peel_to_commit()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | [INFO] [stdout] 318 | Ok(Ancestors { [INFO] [stdout] | ____________^ [INFO] [stdout] 319 | | current: Some(commit), [INFO] [stdout] 320 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 275 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 315 | let object = self.repo.revparse_single(rev)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let commit = object.peel_to_commit()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | [INFO] [stdout] 318 | Ok(Ancestors { [INFO] [stdout] | ____________^ [INFO] [stdout] 319 | | current: Some(commit), [INFO] [stdout] 320 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `branch_name` [INFO] [stdout] --> src/git-delete.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let branch_name = params.branch_name.as_str(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_branch_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-tools` (bin "git-fork" test) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] error: could not compile `git-tools` (bin "git-push2") due to 6 previous errors; 3 warnings emitted [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/git-delete.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | branch.delete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 103 | let _ = branch.delete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 28 | let repo = Repository::open(".")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let config = repo.config()?.snapshot()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | Ok(Git { [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | repo, [INFO] [stdout] 62 | | head_message, [INFO] [stdout] 63 | | head_hash, [INFO] [stdout] ... | [INFO] [stdout] 66 | | config, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 168 | let tree = self.repo.head()?.peel_to_tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | [INFO] [stdout] 170 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | .repo [INFO] [stdout] 172 | | .diff_tree_to_workdir_with_index(Some(&tree), None)? [INFO] [stdout] 173 | | .stats()? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git-push2.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 43 | let git = Git::open()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | Err(match (git.branch_name.as_ref(), git.upstream.as_ref()) { [INFO] [stdout] | _________^ [INFO] [stdout] 46 | | (Some(name), None) => Command::new("git") [INFO] [stdout] 47 | | .arg("push") [INFO] [stdout] 48 | | .args(&["--set-upstream", "origin", name]) [INFO] [stdout] ... | [INFO] [stdout] 56 | | .into(), [INFO] [stdout] 57 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 28 | let repo = Repository::open(".")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let config = repo.config()?.snapshot()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | Ok(Git { [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | repo, [INFO] [stdout] 62 | | head_message, [INFO] [stdout] 63 | | head_hash, [INFO] [stdout] ... | [INFO] [stdout] 66 | | config, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 168 | let tree = self.repo.head()?.peel_to_tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | [INFO] [stdout] 170 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | .repo [INFO] [stdout] 172 | | .diff_tree_to_workdir_with_index(Some(&tree), None)? [INFO] [stdout] 173 | | .stats()? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 273 | let mut revwalk = self.repo.revwalk()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | let from_object = self.repo.revparse_single(from)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let to_object = self.repo.revparse_single(to)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | / revwalk [INFO] [stdout] 286 | | .map(|x| x.map(|x| format!("{}", x))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 273 | let mut revwalk = self.repo.revwalk()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | let from_object = self.repo.revparse_single(from)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let to_object = self.repo.revparse_single(to)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | / revwalk [INFO] [stdout] 286 | | .map(|x| x.map(|x| format!("{}", x))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 275 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 315 | let object = self.repo.revparse_single(rev)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let commit = object.peel_to_commit()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | [INFO] [stdout] 318 | Ok(Ancestors { [INFO] [stdout] | ____________^ [INFO] [stdout] 319 | | current: Some(commit), [INFO] [stdout] 320 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 275 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 315 | let object = self.repo.revparse_single(rev)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let commit = object.peel_to_commit()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | [INFO] [stdout] 318 | Ok(Ancestors { [INFO] [stdout] | ____________^ [INFO] [stdout] 319 | | current: Some(commit), [INFO] [stdout] 320 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-tools` (bin "git-delete") due to 5 previous errors; 6 warnings emitted [INFO] [stderr] error: could not compile `git-tools` (bin "git-push2" test) due to 6 previous errors; 3 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 28 | let repo = Repository::open(".")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let config = repo.config()?.snapshot()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | Ok(Git { [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | repo, [INFO] [stdout] 62 | | head_message, [INFO] [stdout] 63 | | head_hash, [INFO] [stdout] ... | [INFO] [stdout] 66 | | config, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 168 | let tree = self.repo.head()?.peel_to_tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | [INFO] [stdout] 170 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | .repo [INFO] [stdout] 172 | | .diff_tree_to_workdir_with_index(Some(&tree), None)? [INFO] [stdout] 173 | | .stats()? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 273 | let mut revwalk = self.repo.revwalk()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | let from_object = self.repo.revparse_single(from)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let to_object = self.repo.revparse_single(to)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | / revwalk [INFO] [stdout] 286 | | .map(|x| x.map(|x| format!("{}", x))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `branch_name` [INFO] [stdout] --> src/git-delete.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let branch_name = params.branch_name.as_str(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_branch_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 275 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 315 | let object = self.repo.revparse_single(rev)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let commit = object.peel_to_commit()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | [INFO] [stdout] 318 | Ok(Ancestors { [INFO] [stdout] | ____________^ [INFO] [stdout] 319 | | current: Some(commit), [INFO] [stdout] 320 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-tools` (bin "git-try-merge") due to 5 previous errors; 3 warnings emitted [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/git-delete.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | branch.delete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 103 | let _ = branch.delete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 28 | let repo = Repository::open(".")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let config = repo.config()?.snapshot()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | Ok(Git { [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | repo, [INFO] [stdout] 62 | | head_message, [INFO] [stdout] 63 | | head_hash, [INFO] [stdout] ... | [INFO] [stdout] 66 | | config, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 28 | let repo = Repository::open(".")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let config = repo.config()?.snapshot()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | Ok(Git { [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | repo, [INFO] [stdout] 62 | | head_message, [INFO] [stdout] 63 | | head_hash, [INFO] [stdout] ... | [INFO] [stdout] 66 | | config, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 168 | let tree = self.repo.head()?.peel_to_tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | [INFO] [stdout] 170 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | .repo [INFO] [stdout] 172 | | .diff_tree_to_workdir_with_index(Some(&tree), None)? [INFO] [stdout] 173 | | .stats()? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 168 | let tree = self.repo.head()?.peel_to_tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | [INFO] [stdout] 170 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | .repo [INFO] [stdout] 172 | | .diff_tree_to_workdir_with_index(Some(&tree), None)? [INFO] [stdout] 173 | | .stats()? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 273 | let mut revwalk = self.repo.revwalk()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | let from_object = self.repo.revparse_single(from)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let to_object = self.repo.revparse_single(to)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | / revwalk [INFO] [stdout] 286 | | .map(|x| x.map(|x| format!("{}", x))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 275 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 315 | let object = self.repo.revparse_single(rev)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let commit = object.peel_to_commit()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | [INFO] [stdout] 318 | Ok(Ancestors { [INFO] [stdout] | ____________^ [INFO] [stdout] 319 | | current: Some(commit), [INFO] [stdout] 320 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 273 | let mut revwalk = self.repo.revwalk()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | let from_object = self.repo.revparse_single(from)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let to_object = self.repo.revparse_single(to)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | / revwalk [INFO] [stdout] 286 | | .map(|x| x.map(|x| format!("{}", x))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 275 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL | Sort::REVERSE); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/common.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = revwalk.set_sorting(Sort::TOPOLOGICAL); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 315 | let object = self.repo.revparse_single(rev)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let commit = object.peel_to_commit()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | [INFO] [stdout] 318 | Ok(Ancestors { [INFO] [stdout] | ____________^ [INFO] [stdout] 319 | | current: Some(commit), [INFO] [stdout] 320 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-tools` (bin "git-try-merge" test) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] error: could not compile `git-tools` (bin "git-delete" test) due to 5 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "14d2bbf2e53e05c812e42bae492442fc59f69a63c0238f4893c0634d34c034d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14d2bbf2e53e05c812e42bae492442fc59f69a63c0238f4893c0634d34c034d3", kill_on_drop: false }` [INFO] [stdout] 14d2bbf2e53e05c812e42bae492442fc59f69a63c0238f4893c0634d34c034d3