[INFO] cloning repository https://github.com/cdown/mack [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cdown/mack" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcdown%2Fmack", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcdown%2Fmack'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 12af2f7d7c6567ee7b927238e698111b1fd42518 [INFO] checking cdown/mack/12af2f7d7c6567ee7b927238e698111b1fd42518 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcdown%2Fmack" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cdown/mack on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cdown/mack [INFO] finished tweaking git repo https://github.com/cdown/mack [INFO] tweaked toml for git repo https://github.com/cdown/mack written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cdown/mack already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 86c374daa729c76b6457433f2dbd6a0a622554cb9a5651edfc7e896df923169e [INFO] running `Command { std: "docker" "start" "-a" "86c374daa729c76b6457433f2dbd6a0a622554cb9a5651edfc7e896df923169e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "86c374daa729c76b6457433f2dbd6a0a622554cb9a5651edfc7e896df923169e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86c374daa729c76b6457433f2dbd6a0a622554cb9a5651edfc7e896df923169e", kill_on_drop: false }` [INFO] [stdout] 86c374daa729c76b6457433f2dbd6a0a622554cb9a5651edfc7e896df923169e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cd382253b22da1812a6b9f20d77e0db2fa8b520f8499ae95b3a336d61a6cd99f [INFO] running `Command { std: "docker" "start" "-a" "cd382253b22da1812a6b9f20d77e0db2fa8b520f8499ae95b3a336d61a6cd99f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking cow-utils v0.1.3 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking id3 v1.13.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking jwalk v0.8.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking funcfmt v0.3.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking mack v1.4.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 80 | let formatters: FormatMap = fm!( [INFO] [stdout] | _________----------____________________________- [INFO] [stdout] | |_________|_____________________________________| [INFO] [stdout] | |_________|_____________________________________| [INFO] [stdout] | |_________|_____________________________________| [INFO] [stdout] | |_________|_____________________________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | | "artist" => |t: &types::Track| Some(clean_part( [INFO] [stdout] 82 | | t.tag.artist().unwrap_or("Unknown Artist") [INFO] [stdout] 83 | | )), [INFO] [stdout] ... | [INFO] [stdout] 93 | | )), [INFO] [stdout] 94 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | [INFO] [stdout] 96 | | Ok(formatters.to_format_pieces(tmpl)?) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:136:32 [INFO] [stdout] | [INFO] [stdout] 136 | .for_each(|path| match track::get_track(path.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extract.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 15 | Lazy::new(|| Regex::new(r#", (?:and |& )?"#).expect("BUG: Invalid regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fixers.rs:9:48 [INFO] [stdout] | [INFO] [stdout] 9 | static MULTI_WS_RE: Lazy = Lazy::new(|| Regex::new(r"[ \t]+").expect("BUG: Invalid regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mtime.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn mtime_def_now>(path: T) -> SystemTime { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | get_mtime(path.as_ref()).unwrap_or_else(|_| SystemTime::now()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rename.rs:42:49 [INFO] [stdout] | [INFO] [stdout] 42 | static MULTI_DOT_RE: Lazy = Lazy::new(|| Regex::new(r"\.\.+").expect("BUG: Invalid regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mack` (bin "mack") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 80 | let formatters: FormatMap = fm!( [INFO] [stdout] | _________----------____________________________- [INFO] [stdout] | |_________|_____________________________________| [INFO] [stdout] | |_________|_____________________________________| [INFO] [stdout] | |_________|_____________________________________| [INFO] [stdout] | |_________|_____________________________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | | "artist" => |t: &types::Track| Some(clean_part( [INFO] [stdout] 82 | | t.tag.artist().unwrap_or("Unknown Artist") [INFO] [stdout] 83 | | )), [INFO] [stdout] ... | [INFO] [stdout] 93 | | )), [INFO] [stdout] 94 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | [INFO] [stdout] 96 | | Ok(formatters.to_format_pieces(tmpl)?) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:136:32 [INFO] [stdout] | [INFO] [stdout] 136 | .for_each(|path| match track::get_track(path.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extract.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 15 | Lazy::new(|| Regex::new(r#", (?:and |& )?"#).expect("BUG: Invalid regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fixers.rs:9:48 [INFO] [stdout] | [INFO] [stdout] 9 | static MULTI_WS_RE: Lazy = Lazy::new(|| Regex::new(r"[ \t]+").expect("BUG: Invalid regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mtime.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn mtime_def_now>(path: T) -> SystemTime { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | get_mtime(path.as_ref()).unwrap_or_else(|_| SystemTime::now()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rename.rs:42:49 [INFO] [stdout] | [INFO] [stdout] 42 | static MULTI_DOT_RE: Lazy = Lazy::new(|| Regex::new(r"\.\.+").expect("BUG: Invalid regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mack` (bin "mack" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "cd382253b22da1812a6b9f20d77e0db2fa8b520f8499ae95b3a336d61a6cd99f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd382253b22da1812a6b9f20d77e0db2fa8b520f8499ae95b3a336d61a6cd99f", kill_on_drop: false }` [INFO] [stdout] cd382253b22da1812a6b9f20d77e0db2fa8b520f8499ae95b3a336d61a6cd99f