[INFO] cloning repository https://github.com/cdbfoster/brutal [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cdbfoster/brutal" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcdbfoster%2Fbrutal", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcdbfoster%2Fbrutal'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a7fd0dc53059bec286835bf2ce6d7453b8a90005 [INFO] checking cdbfoster/brutal/a7fd0dc53059bec286835bf2ce6d7453b8a90005 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcdbfoster%2Fbrutal" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cdbfoster/brutal on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cdbfoster/brutal [INFO] finished tweaking git repo https://github.com/cdbfoster/brutal [INFO] tweaked toml for git repo https://github.com/cdbfoster/brutal written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cdbfoster/brutal already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] baf3881800b898d6e0af7e14d784cee0a0e2c2870c66a27bc0dcea41320b0cd5 [INFO] running `Command { std: "docker" "start" "-a" "baf3881800b898d6e0af7e14d784cee0a0e2c2870c66a27bc0dcea41320b0cd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "baf3881800b898d6e0af7e14d784cee0a0e2c2870c66a27bc0dcea41320b0cd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "baf3881800b898d6e0af7e14d784cee0a0e2c2870c66a27bc0dcea41320b0cd5", kill_on_drop: false }` [INFO] [stdout] baf3881800b898d6e0af7e14d784cee0a0e2c2870c66a27bc0dcea41320b0cd5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 35820b7b8676e09174d77cf3d9732ef68425e985ab99416d2aed961063b57a1e [INFO] running `Command { std: "docker" "start" "-a" "35820b7b8676e09174d77cf3d9732ef68425e985ab99416d2aed961063b57a1e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking console v0.15.0 [INFO] [stderr] Checking indicatif v0.16.2 [INFO] [stderr] Compiling clap_derive v3.1.2 [INFO] [stderr] Checking clap v3.1.3 [INFO] [stderr] Checking brutal v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 41 | fn read_lines(filename: impl AsRef) -> Vec { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let file = File::open(filename).expect("no such file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let buf = BufReader::new(file); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | / buf.lines() [INFO] [stdout] 45 | | .map(|l| l.expect("could not parse line")) [INFO] [stdout] 46 | | .map(|s| Word::from_str(&s).expect("could not parse word")) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:271:27 [INFO] [stdout] | [INFO] [stdout] 261 | let answer_words = answer_words.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let guess_words = guess_words.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | let search_queue = search_queue.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | [INFO] [stdout] 265 | let progress = progress_bars.add(ProgressBar::new(answer_words.len() as u64)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | let completed = completed.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | [INFO] [stdout] 271 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 272 | | // So we don't slap the shit out of the heap with our search. [INFO] [stdout] 273 | | let mut constraint_buffers = vec![Vec::with_capacity(WORD_LENGTH); GUESS_LIMIT]; [INFO] [stdout] 274 | | let mut word_buffers = vec![Vec::with_capacity(guess_words.len()); GUESS_LIMIT]; [INFO] [stdout] ... | [INFO] [stdout] 320 | | progress.finish_with_message("done"); [INFO] [stdout] 321 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:331:49 [INFO] [stdout] | [INFO] [stdout] 251 | let progress_bars = MultiProgress::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | let progress_thread = thread::spawn(move || progress_bars.join().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:367:45 [INFO] [stdout] | [INFO] [stdout] 367 | worker_threads.into_iter().for_each(|t| t.join().unwrap()); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `brutal` (bin "brutal" test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 41 | fn read_lines(filename: impl AsRef) -> Vec { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let file = File::open(filename).expect("no such file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let buf = BufReader::new(file); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | / buf.lines() [INFO] [stdout] 45 | | .map(|l| l.expect("could not parse line")) [INFO] [stdout] 46 | | .map(|s| Word::from_str(&s).expect("could not parse word")) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:271:27 [INFO] [stdout] | [INFO] [stdout] 261 | let answer_words = answer_words.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let guess_words = guess_words.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | let search_queue = search_queue.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | [INFO] [stdout] 265 | let progress = progress_bars.add(ProgressBar::new(answer_words.len() as u64)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | let completed = completed.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | [INFO] [stdout] 271 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 272 | | // So we don't slap the shit out of the heap with our search. [INFO] [stdout] 273 | | let mut constraint_buffers = vec![Vec::with_capacity(WORD_LENGTH); GUESS_LIMIT]; [INFO] [stdout] 274 | | let mut word_buffers = vec![Vec::with_capacity(guess_words.len()); GUESS_LIMIT]; [INFO] [stdout] ... | [INFO] [stdout] 320 | | progress.finish_with_message("done"); [INFO] [stdout] 321 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:331:49 [INFO] [stdout] | [INFO] [stdout] 251 | let progress_bars = MultiProgress::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | let progress_thread = thread::spawn(move || progress_bars.join().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:367:45 [INFO] [stdout] | [INFO] [stdout] 367 | worker_threads.into_iter().for_each(|t| t.join().unwrap()); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `brutal` (bin "brutal") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "35820b7b8676e09174d77cf3d9732ef68425e985ab99416d2aed961063b57a1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35820b7b8676e09174d77cf3d9732ef68425e985ab99416d2aed961063b57a1e", kill_on_drop: false }` [INFO] [stdout] 35820b7b8676e09174d77cf3d9732ef68425e985ab99416d2aed961063b57a1e