[INFO] cloning repository https://github.com/cbs228/sameold [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cbs228/sameold" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcbs228%2Fsameold", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcbs228%2Fsameold'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b183a04d08d4b52b9ebaca1eb1af47a33c932e0a [INFO] checking cbs228/sameold/b183a04d08d4b52b9ebaca1eb1af47a33c932e0a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcbs228%2Fsameold" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cbs228/sameold on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cbs228/sameold [INFO] finished tweaking git repo https://github.com/cbs228/sameold [INFO] tweaked toml for git repo https://github.com/cbs228/sameold written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cbs228/sameold already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 66f03f7e76e2f105df24b82443eafcff0e9b3072156751c5bc1b44ed7d3929fe [INFO] running `Command { std: "docker" "start" "-a" "66f03f7e76e2f105df24b82443eafcff0e9b3072156751c5bc1b44ed7d3929fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "66f03f7e76e2f105df24b82443eafcff0e9b3072156751c5bc1b44ed7d3929fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66f03f7e76e2f105df24b82443eafcff0e9b3072156751c5bc1b44ed7d3929fe", kill_on_drop: false }` [INFO] [stdout] 66f03f7e76e2f105df24b82443eafcff0e9b3072156751c5bc1b44ed7d3929fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 92358bec810e2c65d7b7b6b34904f0a3ed0f6a743668b955a6f5a5531850f1e8 [INFO] running `Command { std: "docker" "start" "-a" "92358bec810e2c65d7b7b6b34904f0a3ed0f6a743668b955a6f5a5531850f1e8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling arraydeque v0.4.5 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking safe_arch v0.7.1 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking strum v0.26.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking wide v0.7.15 [INFO] [stderr] Checking assert_approx_eq v1.1.0 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking slice-ring-buffer v0.3.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking chrono v0.4.34 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Compiling nalgebra-macros v0.2.1 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling strum_macros v0.26.1 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking nalgebra v0.32.4 [INFO] [stderr] Checking sameold v0.4.0 (/opt/rustwide/workdir/crates/sameold) [INFO] [stdout] warning: method `push` is never used [INFO] [stdout] --> crates/sameold/src/receiver/demod.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 40 | pub trait Demod: Clone + std::fmt::Debug + Sized { [INFO] [stdout] | ----- method in this trait [INFO] [stdout] ... [INFO] [stdout] 58 | fn push(&mut self, input: S) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/sameold/src/receiver.rs:128:21 [INFO] [stdout] | [INFO] [stdout] 121 | input: I, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | source: input.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/sameold/src/receiver.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn iter_messages<'rx, I>(&'rx mut self, input: I) -> impl Iterator + 'rx [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | self.iter_events(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/sameold/src/receiver.rs:547:24 [INFO] [stdout] | [INFO] [stdout] 509 | let dc_block = DCBlocker::new((cfg.dc_blocker_length() * sps) as usize); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | let demod = FskDemod::new_from_same(cfg.input_rate()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 516 | let symsync = TimingLoop::new(sps, timing_bandwidth_unlocked, cfg.timing_max_deviation()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 517 | let code_squelch = CodeAndPowerSquelch::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 528 | let equalizer = Equalizer::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | assembler: Assembler::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sameold` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/sameold/src/receiver.rs:128:21 [INFO] [stdout] | [INFO] [stdout] 121 | input: I, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | source: input.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/sameold/src/receiver.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn iter_messages<'rx, I>(&'rx mut self, input: I) -> impl Iterator + 'rx [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | self.iter_events(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/sameold/src/receiver.rs:547:24 [INFO] [stdout] | [INFO] [stdout] 509 | let dc_block = DCBlocker::new((cfg.dc_blocker_length() * sps) as usize); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | let demod = FskDemod::new_from_same(cfg.input_rate()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 516 | let symsync = TimingLoop::new(sps, timing_bandwidth_unlocked, cfg.timing_max_deviation()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 517 | let code_squelch = CodeAndPowerSquelch::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 528 | let equalizer = Equalizer::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | assembler: Assembler::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/sameold/src/receiver/assembler.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 402 | src: I, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 407 | / src.into_iter() [INFO] [stdout] 408 | | .map(move |(delay, data)| { [INFO] [stdout] 409 | | *time = *time + 8 * data.len() as u64 + delay; [INFO] [stdout] 410 | | if !data.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 413 | | (*time, *data) [INFO] [stdout] 414 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sameold` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "92358bec810e2c65d7b7b6b34904f0a3ed0f6a743668b955a6f5a5531850f1e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92358bec810e2c65d7b7b6b34904f0a3ed0f6a743668b955a6f5a5531850f1e8", kill_on_drop: false }` [INFO] [stdout] 92358bec810e2c65d7b7b6b34904f0a3ed0f6a743668b955a6f5a5531850f1e8