[INFO] cloning repository https://github.com/carlossless/sinowealth-kb-tool [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/carlossless/sinowealth-kb-tool" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcarlossless%2Fsinowealth-kb-tool", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcarlossless%2Fsinowealth-kb-tool'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] deb107dbff23dbb794dd5df043f83b7e906f12e9 [INFO] checking carlossless/sinowealth-kb-tool/deb107dbff23dbb794dd5df043f83b7e906f12e9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcarlossless%2Fsinowealth-kb-tool" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/carlossless/sinowealth-kb-tool on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/carlossless/sinowealth-kb-tool [INFO] finished tweaking git repo https://github.com/carlossless/sinowealth-kb-tool [INFO] tweaked toml for git repo https://github.com/carlossless/sinowealth-kb-tool written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/carlossless/sinowealth-kb-tool already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4c813bce8159c1c5830e618074109f0f8b433ab9c9bd2bc23020c1169861e0db [INFO] running `Command { std: "docker" "start" "-a" "4c813bce8159c1c5830e618074109f0f8b433ab9c9bd2bc23020c1169861e0db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4c813bce8159c1c5830e618074109f0f8b433ab9c9bd2bc23020c1169861e0db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c813bce8159c1c5830e618074109f0f8b433ab9c9bd2bc23020c1169861e0db", kill_on_drop: false }` [INFO] [stdout] 4c813bce8159c1c5830e618074109f0f8b433ab9c9bd2bc23020c1169861e0db [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3b7f471fd7549539109778d494528bde1edfd72e994e234fefae9810195fcb91 [INFO] running `Command { std: "docker" "start" "-a" "3b7f471fd7549539109778d494528bde1edfd72e994e234fefae9810195fcb91", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.20 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling thiserror v1.0.47 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking ihex v3.0.0 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Checking clap_builder v4.3.23 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking simple_logger v4.3.3 [INFO] [stderr] Checking clap-num v1.0.2 [INFO] [stderr] Compiling hidapi v2.4.1 [INFO] [stderr] Checking clap v4.3.23 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling thiserror-impl v1.0.47 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking sinowealth-kb-tool v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:232:9 [INFO] [stdout] | [INFO] [stdout] 231 | fn part_args(self) -> Command { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | / self.arg( [INFO] [stdout] 233 | | arg!(-p --part ) [INFO] [stdout] 234 | | .value_parser(Part::available_parts()) [INFO] [stdout] 235 | | .required_unless_present_all(["firmware_size", "vendor_id", "product_id"]), [INFO] [stdout] ... | [INFO] [stdout] 256 | | .arg(arg!(--isp_usage ).value_parser(maybe_hex::)) [INFO] [stdout] 257 | | .arg(arg!(--isp_index ).value_parser(maybe_hex::)) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:258:14 [INFO] [stdout] | [INFO] [stdout] 231 | fn part_args(self) -> Command { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | .arg(arg!(--reboot ).value_parser(value_parser!(bool))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/isp.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 84 | let devices = Self::find_isp_device(part)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | request_device: devices.request, [INFO] [stdout] 87 | | #[cfg(target_os = "windows")] [INFO] [stdout] 88 | | data_device: devices.data, [INFO] [stdout] 89 | | part, [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sinowealth-kb-tool` (bin "sinowealth-kb-tool") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:232:9 [INFO] [stdout] | [INFO] [stdout] 231 | fn part_args(self) -> Command { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | / self.arg( [INFO] [stdout] 233 | | arg!(-p --part ) [INFO] [stdout] 234 | | .value_parser(Part::available_parts()) [INFO] [stdout] 235 | | .required_unless_present_all(["firmware_size", "vendor_id", "product_id"]), [INFO] [stdout] ... | [INFO] [stdout] 256 | | .arg(arg!(--isp_usage ).value_parser(maybe_hex::)) [INFO] [stdout] 257 | | .arg(arg!(--isp_index ).value_parser(maybe_hex::)) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:258:14 [INFO] [stdout] | [INFO] [stdout] 231 | fn part_args(self) -> Command { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | .arg(arg!(--reboot ).value_parser(value_parser!(bool))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/isp.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 84 | let devices = Self::find_isp_device(part)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | request_device: devices.request, [INFO] [stdout] 87 | | #[cfg(target_os = "windows")] [INFO] [stdout] 88 | | data_device: devices.data, [INFO] [stdout] 89 | | part, [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sinowealth-kb-tool` (bin "sinowealth-kb-tool" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "3b7f471fd7549539109778d494528bde1edfd72e994e234fefae9810195fcb91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b7f471fd7549539109778d494528bde1edfd72e994e234fefae9810195fcb91", kill_on_drop: false }` [INFO] [stdout] 3b7f471fd7549539109778d494528bde1edfd72e994e234fefae9810195fcb91