[INFO] cloning repository https://github.com/carlosconley/surely-raytracing [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/carlosconley/surely-raytracing" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcarlosconley%2Fsurely-raytracing", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcarlosconley%2Fsurely-raytracing'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f08056bef9f39e8ef0817f0ccf41f1016efbe72b [INFO] checking carlosconley/surely-raytracing/f08056bef9f39e8ef0817f0ccf41f1016efbe72b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcarlosconley%2Fsurely-raytracing" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/carlosconley/surely-raytracing on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/carlosconley/surely-raytracing [INFO] finished tweaking git repo https://github.com/carlosconley/surely-raytracing [INFO] tweaked toml for git repo https://github.com/carlosconley/surely-raytracing written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/carlosconley/surely-raytracing already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a071ebef9f3a0b4e6cc8c434c16b37125e6840ba05fdb429184e739134e08f2 [INFO] running `Command { std: "docker" "start" "-a" "1a071ebef9f3a0b4e6cc8c434c16b37125e6840ba05fdb429184e739134e08f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a071ebef9f3a0b4e6cc8c434c16b37125e6840ba05fdb429184e739134e08f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a071ebef9f3a0b4e6cc8c434c16b37125e6840ba05fdb429184e739134e08f2", kill_on_drop: false }` [INFO] [stdout] 1a071ebef9f3a0b4e6cc8c434c16b37125e6840ba05fdb429184e739134e08f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 644af1705858022ffd9297c05d4aebfe5ff8f33ad50547714350fd51f1695abf [INFO] running `Command { std: "docker" "start" "-a" "644af1705858022ffd9297c05d4aebfe5ff8f33ad50547714350fd51f1695abf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking half v2.4.0 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Checking rayon v1.9.0 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking raytracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constant `INF` is never used [INFO] [stdout] --> src/utils.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | pub const INF: f64 = f64::INFINITY; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_int` is never used [INFO] [stdout] --> src/utils.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn random_int(min: i64, max: i64) -> i64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INF` is never used [INFO] [stdout] --> src/utils.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | pub const INF: f64 = f64::INFINITY; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_range` is never used [INFO] [stdout] --> src/utils.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn random_range(min: f64, max: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_int` is never used [INFO] [stdout] --> src/utils.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn random_int(min: i64, max: i64) -> i64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INF` is never used [INFO] [stdout] --> src/utils.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | pub const INF: f64 = f64::INFINITY; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_range` is never used [INFO] [stdout] --> src/utils.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn random_range(min: f64, max: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_int` is never used [INFO] [stdout] --> src/utils.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn random_int(min: i64, max: i64) -> i64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INF` is never used [INFO] [stdout] --> src/utils.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | pub const INF: f64 = f64::INFINITY; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_int` is never used [INFO] [stdout] --> src/utils.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn random_int(min: i64, max: i64) -> i64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/object.rs:8:23 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::interval::{self, Interval, EMPTY}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::f64::consts::PI` [INFO] [stdout] --> src/render.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::f64::consts::PI; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `CosinePDF` [INFO] [stdout] --> src/render.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::pdf::{CosinePDF, HittablePDF, MixturePDF, PDF}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/object.rs:8:23 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::interval::{self, Interval, EMPTY}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::f64::consts::PI` [INFO] [stdout] --> src/render.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::f64::consts::PI; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `CosinePDF` [INFO] [stdout] --> src/render.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::pdf::{CosinePDF, HittablePDF, MixturePDF, PDF}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `origin` [INFO] [stdout] --> src/hittable.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 46 | fn pdf_value(&self, origin: &Point3, direction: &Vec3) -> f64 { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_origin` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `direction` [INFO] [stdout] --> src/hittable.rs:46:42 [INFO] [stdout] | [INFO] [stdout] 46 | fn pdf_value(&self, origin: &Point3, direction: &Vec3) -> f64 { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_direction` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `origin` [INFO] [stdout] --> src/hittable.rs:50:22 [INFO] [stdout] | [INFO] [stdout] 50 | fn random(&self, origin: &Point3) -> Vec3 { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_origin` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `origin` [INFO] [stdout] --> src/hittable.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 46 | fn pdf_value(&self, origin: &Point3, direction: &Vec3) -> f64 { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_origin` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `direction` [INFO] [stdout] --> src/hittable.rs:46:42 [INFO] [stdout] | [INFO] [stdout] 46 | fn pdf_value(&self, origin: &Point3, direction: &Vec3) -> f64 { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_direction` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `origin` [INFO] [stdout] --> src/hittable.rs:50:22 [INFO] [stdout] | [INFO] [stdout] 50 | fn random(&self, origin: &Point3) -> Vec3 { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_origin` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:62:23 [INFO] [stdout] | [INFO] [stdout] 62 | fn scatter(&self, r_in: &Ray, rec: &HitRecord) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rec` [INFO] [stdout] --> src/material.rs:62:35 [INFO] [stdout] | [INFO] [stdout] 62 | fn scatter(&self, r_in: &Ray, rec: &HitRecord) -> Option { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:70:30 [INFO] [stdout] | [INFO] [stdout] 70 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rec` [INFO] [stdout] --> src/material.rs:70:42 [INFO] [stdout] | [INFO] [stdout] 70 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scattered` [INFO] [stdout] --> src/material.rs:70:59 [INFO] [stdout] | [INFO] [stdout] 70 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_scattered` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:93:23 [INFO] [stdout] | [INFO] [stdout] 93 | fn scatter(&self, r_in: &Ray, rec: &HitRecord) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:100:30 [INFO] [stdout] | [INFO] [stdout] 100 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:136:30 [INFO] [stdout] | [INFO] [stdout] 136 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rec` [INFO] [stdout] --> src/material.rs:136:42 [INFO] [stdout] | [INFO] [stdout] 136 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scattered` [INFO] [stdout] --> src/material.rs:136:59 [INFO] [stdout] | [INFO] [stdout] 136 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_scattered` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:210:27 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn emitted(&self, r_in: &Ray, rec: &HitRecord, u: f64, v: f64, p: &Point3) -> Color { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:242:23 [INFO] [stdout] | [INFO] [stdout] 242 | fn scatter(&self, r_in: &Ray, rec: &HitRecord) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:62:23 [INFO] [stdout] | [INFO] [stdout] 62 | fn scatter(&self, r_in: &Ray, rec: &HitRecord) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rec` [INFO] [stdout] --> src/material.rs:62:35 [INFO] [stdout] | [INFO] [stdout] 62 | fn scatter(&self, r_in: &Ray, rec: &HitRecord) -> Option { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:70:30 [INFO] [stdout] | [INFO] [stdout] 70 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rec` [INFO] [stdout] --> src/material.rs:70:42 [INFO] [stdout] | [INFO] [stdout] 70 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scattered` [INFO] [stdout] --> src/material.rs:70:59 [INFO] [stdout] | [INFO] [stdout] 70 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_scattered` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:93:23 [INFO] [stdout] | [INFO] [stdout] 93 | fn scatter(&self, r_in: &Ray, rec: &HitRecord) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:100:30 [INFO] [stdout] | [INFO] [stdout] 100 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:136:30 [INFO] [stdout] | [INFO] [stdout] 136 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rec` [INFO] [stdout] --> src/material.rs:136:42 [INFO] [stdout] | [INFO] [stdout] 136 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scattered` [INFO] [stdout] --> src/material.rs:136:59 [INFO] [stdout] | [INFO] [stdout] 136 | fn scattering_pdf(&self, r_in: &Ray, rec: &HitRecord, scattered: &Ray) -> f64 { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_scattered` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:210:27 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn emitted(&self, r_in: &Ray, rec: &HitRecord, u: f64, v: f64, p: &Point3) -> Color { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material.rs:242:23 [INFO] [stdout] | [INFO] [stdout] 242 | fn scatter(&self, r_in: &Ray, rec: &HitRecord) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `aluminum` [INFO] [stdout] --> src/main.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 462 | let aluminum = Metal::new(Color::new(0.8, 0.85, 0.88), 0.1); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_aluminum` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `box2` [INFO] [stdout] --> src/main.rs:479:9 [INFO] [stdout] | [INFO] [stdout] 479 | let box2 = Translate::new(box2.into(), Vec3::new(130., 0., 65.)); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_box2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `aluminum` [INFO] [stdout] --> src/main.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 462 | let aluminum = Metal::new(Color::new(0.8, 0.85, 0.88), 0.1); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_aluminum` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `box2` [INFO] [stdout] --> src/main.rs:479:9 [INFO] [stdout] | [INFO] [stdout] 479 | let box2 = Translate::new(box2.into(), Vec3::new(130., 0., 65.)); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_box2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `direction` is never read [INFO] [stdout] --> src/object.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 216 | pub struct Sun { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 217 | pub direction: Vec3, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `direction` is never read [INFO] [stdout] --> src/object.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 216 | pub struct Sun { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 217 | pub direction: Vec3, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `aspect_ratio`, `vfov`, `lookat`, `vup`, and `focus_dist` are never read [INFO] [stdout] --> src/render.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct Camera { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 16 | pub aspect_ratio: f64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub vfov: f64, // Vertical view angle (field of view) [INFO] [stdout] | ^^^^ [INFO] [stdout] 21 | pub lookat: Point3, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 22 | pub vup: Vec3, [INFO] [stdout] | ^^^ [INFO] [stdout] 23 | pub defocus_angle: f64, [INFO] [stdout] 24 | pub focus_dist: f64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `draw_depth` is never used [INFO] [stdout] --> src/render.rs:313:4 [INFO] [stdout] | [INFO] [stdout] 313 | fn draw_depth(cam: &Camera, depth_buffer: &Vec) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constant_medium.rs:24:24 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(boundary: Arc, density: f64, c: Color) -> Object { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Object::Volume(ConstantMedium { [INFO] [stdout] | ________________________^ [INFO] [stdout] 25 | | boundary, [INFO] [stdout] 26 | | neg_inv_density: -1. / density, [INFO] [stdout] 27 | | phase_function: Isotropic::new(c), [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constant_medium.rs:32:24 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn _from_texture(boundary: Arc, density: f64, albedo: Arc) -> Object { [INFO] [stdout] | --------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Object::Volume(ConstantMedium { [INFO] [stdout] | ________________________^ [INFO] [stdout] 33 | | boundary, [INFO] [stdout] 34 | | neg_inv_density: -1. / density, [INFO] [stdout] 35 | | phase_function: Isotropic::_from_texture(albedo), [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/material.rs:88:30 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn from_texture(texture: Arc) -> Material { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Material::Lambertian(Lambertian { texture }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/material.rs:207:32 [INFO] [stdout] | [INFO] [stdout] 206 | pub fn _from_texture(emit: Arc) -> Material { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | Material::DiffuseLight(DiffuseLight { emit }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/material.rs:237:29 [INFO] [stdout] | [INFO] [stdout] 236 | pub fn _from_texture(albedo: Arc) -> Material { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | Material::Isotropic(Isotropic { albedo }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:85:24 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(center: Point3, radius: f64, mat: Material) -> Object { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let rvec = Vec3::new(radius, radius, radius); [INFO] [stdout] 85 | Object::Sphere(Sphere { [INFO] [stdout] | ________________________^ [INFO] [stdout] 86 | | center, [INFO] [stdout] 87 | | radius, [INFO] [stdout] 88 | | mat, [INFO] [stdout] 89 | | center_vec: None, [INFO] [stdout] 90 | | bbox: Aabb::from_points(&(center - rvec), &(center + rvec)), [INFO] [stdout] 91 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:98:24 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn new_moving(center1: Point3, center2: Point3, radius: f64, mat: Material) -> Object { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Object::Sphere(Sphere { [INFO] [stdout] | ________________________^ [INFO] [stdout] 99 | | center: center1, [INFO] [stdout] 100 | | radius, [INFO] [stdout] 101 | | mat, [INFO] [stdout] 102 | | center_vec: Some(center2 - center1), [INFO] [stdout] 103 | | bbox: Aabb::from_boxes(&box1, &box2), [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:251:24 [INFO] [stdout] | [INFO] [stdout] 250 | pub fn _new(point: Point3, normal: Vec3, mat: Material) -> Object { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | Object::_Plane(Plane { [INFO] [stdout] | ________________________^ [INFO] [stdout] 252 | | point, [INFO] [stdout] 253 | | normal: unit_vector(&normal), [INFO] [stdout] 254 | | mat, [INFO] [stdout] 255 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:434:22 [INFO] [stdout] | [INFO] [stdout] 428 | pub fn new(q: Point3, u: Vec3, v: Vec3, mat: Material) -> Object { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | Object::Quad(Quad { [INFO] [stdout] | ______________________^ [INFO] [stdout] 435 | | q, [INFO] [stdout] 436 | | u, [INFO] [stdout] 437 | | v, [INFO] [stdout] ... | [INFO] [stdout] 443 | | area: n.length(), [INFO] [stdout] 444 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:559:18 [INFO] [stdout] | [INFO] [stdout] 512 | let mut sides = HittableList::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | Object::List(Arc::new(sides)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/texture.rs:56:26 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn _new(scale: f64, even: Arc, odd: Arc) -> Texture { [INFO] [stdout] | ------------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Texture::Checker(CheckerTexture { [INFO] [stdout] | __________________________^ [INFO] [stdout] 57 | | inv_scale: 1. / scale, [INFO] [stdout] 58 | | even, [INFO] [stdout] 59 | | odd, [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transform.rs:48:27 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(p: Arc, displacement: Vec3) -> Object { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Object::Transform(Transform::Translate(Translate { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 49 | | bbox, [INFO] [stdout] 50 | | object: p, [INFO] [stdout] 51 | | offset: displacement, [INFO] [stdout] 52 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transform.rs:180:27 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn new(p: Arc, angle: f64) -> Object { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | Object::Transform(Transform::RotY(RotateY { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 181 | | object: p, [INFO] [stdout] 182 | | bbox, [INFO] [stdout] 183 | | cos_theta, [INFO] [stdout] 184 | | sin_theta, [INFO] [stdout] 185 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdf.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn new(objects: Arc, origin: Point3) -> AnyPDF { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | AnyPDF::Hittable(HittablePDF { objects, origin }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `aspect_ratio`, `vfov`, `lookat`, `vup`, and `focus_dist` are never read [INFO] [stdout] --> src/render.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct Camera { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 16 | pub aspect_ratio: f64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub vfov: f64, // Vertical view angle (field of view) [INFO] [stdout] | ^^^^ [INFO] [stdout] 21 | pub lookat: Point3, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 22 | pub vup: Vec3, [INFO] [stdout] | ^^^ [INFO] [stdout] 23 | pub defocus_angle: f64, [INFO] [stdout] 24 | pub focus_dist: f64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `draw_depth` is never used [INFO] [stdout] --> src/render.rs:313:4 [INFO] [stdout] | [INFO] [stdout] 313 | fn draw_depth(cam: &Camera, depth_buffer: &Vec) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constant_medium.rs:24:24 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(boundary: Arc, density: f64, c: Color) -> Object { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Object::Volume(ConstantMedium { [INFO] [stdout] | ________________________^ [INFO] [stdout] 25 | | boundary, [INFO] [stdout] 26 | | neg_inv_density: -1. / density, [INFO] [stdout] 27 | | phase_function: Isotropic::new(c), [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constant_medium.rs:32:24 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn _from_texture(boundary: Arc, density: f64, albedo: Arc) -> Object { [INFO] [stdout] | --------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Object::Volume(ConstantMedium { [INFO] [stdout] | ________________________^ [INFO] [stdout] 33 | | boundary, [INFO] [stdout] 34 | | neg_inv_density: -1. / density, [INFO] [stdout] 35 | | phase_function: Isotropic::_from_texture(albedo), [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/material.rs:88:30 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn from_texture(texture: Arc) -> Material { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Material::Lambertian(Lambertian { texture }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/material.rs:207:32 [INFO] [stdout] | [INFO] [stdout] 206 | pub fn _from_texture(emit: Arc) -> Material { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | Material::DiffuseLight(DiffuseLight { emit }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/material.rs:237:29 [INFO] [stdout] | [INFO] [stdout] 236 | pub fn _from_texture(albedo: Arc) -> Material { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | Material::Isotropic(Isotropic { albedo }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:85:24 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(center: Point3, radius: f64, mat: Material) -> Object { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let rvec = Vec3::new(radius, radius, radius); [INFO] [stdout] 85 | Object::Sphere(Sphere { [INFO] [stdout] | ________________________^ [INFO] [stdout] 86 | | center, [INFO] [stdout] 87 | | radius, [INFO] [stdout] 88 | | mat, [INFO] [stdout] 89 | | center_vec: None, [INFO] [stdout] 90 | | bbox: Aabb::from_points(&(center - rvec), &(center + rvec)), [INFO] [stdout] 91 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:98:24 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn new_moving(center1: Point3, center2: Point3, radius: f64, mat: Material) -> Object { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Object::Sphere(Sphere { [INFO] [stdout] | ________________________^ [INFO] [stdout] 99 | | center: center1, [INFO] [stdout] 100 | | radius, [INFO] [stdout] 101 | | mat, [INFO] [stdout] 102 | | center_vec: Some(center2 - center1), [INFO] [stdout] 103 | | bbox: Aabb::from_boxes(&box1, &box2), [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:251:24 [INFO] [stdout] | [INFO] [stdout] 250 | pub fn _new(point: Point3, normal: Vec3, mat: Material) -> Object { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | Object::_Plane(Plane { [INFO] [stdout] | ________________________^ [INFO] [stdout] 252 | | point, [INFO] [stdout] 253 | | normal: unit_vector(&normal), [INFO] [stdout] 254 | | mat, [INFO] [stdout] 255 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:434:22 [INFO] [stdout] | [INFO] [stdout] 428 | pub fn new(q: Point3, u: Vec3, v: Vec3, mat: Material) -> Object { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | Object::Quad(Quad { [INFO] [stdout] | ______________________^ [INFO] [stdout] 435 | | q, [INFO] [stdout] 436 | | u, [INFO] [stdout] 437 | | v, [INFO] [stdout] ... | [INFO] [stdout] 443 | | area: n.length(), [INFO] [stdout] 444 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:559:18 [INFO] [stdout] | [INFO] [stdout] 512 | let mut sides = HittableList::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | Object::List(Arc::new(sides)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/texture.rs:56:26 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn _new(scale: f64, even: Arc, odd: Arc) -> Texture { [INFO] [stdout] | ------------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Texture::Checker(CheckerTexture { [INFO] [stdout] | __________________________^ [INFO] [stdout] 57 | | inv_scale: 1. / scale, [INFO] [stdout] 58 | | even, [INFO] [stdout] 59 | | odd, [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transform.rs:48:27 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(p: Arc, displacement: Vec3) -> Object { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Object::Transform(Transform::Translate(Translate { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 49 | | bbox, [INFO] [stdout] 50 | | object: p, [INFO] [stdout] 51 | | offset: displacement, [INFO] [stdout] 52 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transform.rs:180:27 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn new(p: Arc, angle: f64) -> Object { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | Object::Transform(Transform::RotY(RotateY { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 181 | | object: p, [INFO] [stdout] 182 | | bbox, [INFO] [stdout] 183 | | cos_theta, [INFO] [stdout] 184 | | sin_theta, [INFO] [stdout] 185 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 23 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdf.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn new(objects: Arc, origin: Point3) -> AnyPDF { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | AnyPDF::Hittable(HittablePDF { objects, origin }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 23 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raytracer` (bin "raytracer") due to 15 previous errors; 23 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `raytracer` (bin "raytracer" test) due to 15 previous errors; 23 warnings emitted [INFO] running `Command { std: "docker" "inspect" "644af1705858022ffd9297c05d4aebfe5ff8f33ad50547714350fd51f1695abf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "644af1705858022ffd9297c05d4aebfe5ff8f33ad50547714350fd51f1695abf", kill_on_drop: false }` [INFO] [stdout] 644af1705858022ffd9297c05d4aebfe5ff8f33ad50547714350fd51f1695abf