[INFO] cloning repository https://github.com/care0717/lsm_engine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/care0717/lsm_engine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcare0717%2Flsm_engine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcare0717%2Flsm_engine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e28b201dee6771d91ed904442b8f69fbba7bdc03 [INFO] checking care0717/lsm_engine/e28b201dee6771d91ed904442b8f69fbba7bdc03 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcare0717%2Flsm_engine" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/care0717/lsm_engine on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/care0717/lsm_engine [INFO] finished tweaking git repo https://github.com/care0717/lsm_engine [INFO] tweaked toml for git repo https://github.com/care0717/lsm_engine written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/care0717/lsm_engine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc7086c97dc38d0a16702ce1689d0001ec29a9147c17ffe95ba2676830292ff9 [INFO] running `Command { std: "docker" "start" "-a" "cc7086c97dc38d0a16702ce1689d0001ec29a9147c17ffe95ba2676830292ff9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc7086c97dc38d0a16702ce1689d0001ec29a9147c17ffe95ba2676830292ff9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc7086c97dc38d0a16702ce1689d0001ec29a9147c17ffe95ba2676830292ff9", kill_on_drop: false }` [INFO] [stdout] cc7086c97dc38d0a16702ce1689d0001ec29a9147c17ffe95ba2676830292ff9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1d865adcf685a348634192f93895e4b0534ca3b52ffa392107dc0a90b4cd1f02 [INFO] running `Command { std: "docker" "start" "-a" "1d865adcf685a348634192f93895e4b0534ca3b52ffa392107dc0a90b4cd1f02", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling anyhow v1.0.41 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking lsm_engine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::memtable::Memtable` [INFO] [stdout] --> src/avl.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | use crate::memtable::Memtable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `delete` is never used [INFO] [stdout] --> src/avl.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 18 | impl AvlTreeMap { [INFO] [stdout] | --------------------------------------------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 26 | fn delete(&mut self, key: &K) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `delete`, `delete_root`, `combine`, and `delete_max` are never used [INFO] [stdout] --> src/avl/tree.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 17 | impl AvlNode { [INFO] [stdout] | -------------------------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn delete(mut self, key: &K) -> AvlTree { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 71 | fn delete_root(self) -> AvlTree { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | fn combine(self, left: Box>) -> AvlNode { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | fn delete_max(mut self) -> (AvlTree, K, V) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `print` and `print_tree` are never used [INFO] [stdout] --> src/avl/tree.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 155 | impl AvlNode { [INFO] [stdout] | ------------------------------------------------------ methods in this implementation [INFO] [stdout] 156 | fn print(&self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 159 | fn print_tree(&self, depth: usize) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avl/tree.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(key: K, value: V) -> Self { [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | left: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avl/tree.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(key: K, value: V) -> Self { [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | right: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avl/tree.rs:72:15 [INFO] [stdout] | [INFO] [stdout] 71 | fn delete_root(self) -> AvlTree { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | match (self.left, self.right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / commands [INFO] [stdout] 25 | | .clone() [INFO] [stdout] 26 | | .first() [INFO] [stdout] 27 | | .ok_or(io::Error::new(io::ErrorKind::InvalidInput, "no content")) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memtable.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(mut wal: Wal) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let vec = wal.recover()?; [INFO] [stdout] 24 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | wal, [INFO] [stdout] 26 | | map: AvlTreeMap::from_iter(vec), [INFO] [stdout] 27 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sstable.rs:25:60 [INFO] [stdout] | [INFO] [stdout] 25 | let mut paths: Vec<_> = fs::read_dir(dir)?.map(|r| r.unwrap().path()).collect(); [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wal.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | let file = OpenOptions::new().create(true).append(true).open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 18 | | path, [INFO] [stdout] 19 | | write_file: file, [INFO] [stdout] 20 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lsm_engine` (lib) due to 8 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `delete` is never used [INFO] [stdout] --> src/avl.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 18 | impl AvlTreeMap { [INFO] [stdout] | --------------------------------------------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 26 | fn delete(&mut self, key: &K) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `print` and `print_tree` are never used [INFO] [stdout] --> src/avl/tree.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 155 | impl AvlNode { [INFO] [stdout] | ------------------------------------------------------ methods in this implementation [INFO] [stdout] 156 | fn print(&self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 159 | fn print_tree(&self, depth: usize) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `search` is never used [INFO] [stdout] --> src/avl/tree.rs:370:8 [INFO] [stdout] | [INFO] [stdout] 370 | fn search() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avl/tree.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(key: K, value: V) -> Self { [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | left: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avl/tree.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(key: K, value: V) -> Self { [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | right: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avl/tree.rs:72:15 [INFO] [stdout] | [INFO] [stdout] 71 | fn delete_root(self) -> AvlTree { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | match (self.left, self.right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / commands [INFO] [stdout] 25 | | .clone() [INFO] [stdout] 26 | | .first() [INFO] [stdout] 27 | | .ok_or(io::Error::new(io::ErrorKind::InvalidInput, "no content")) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memtable.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(mut wal: Wal) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let vec = wal.recover()?; [INFO] [stdout] 24 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | wal, [INFO] [stdout] 26 | | map: AvlTreeMap::from_iter(vec), [INFO] [stdout] 27 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sstable.rs:25:60 [INFO] [stdout] | [INFO] [stdout] 25 | let mut paths: Vec<_> = fs::read_dir(dir)?.map(|r| r.unwrap().path()).collect(); [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wal.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | let file = OpenOptions::new().create(true).append(true).open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 18 | | path, [INFO] [stdout] 19 | | write_file: file, [INFO] [stdout] 20 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lsm_engine` (lib test) due to 8 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1d865adcf685a348634192f93895e4b0534ca3b52ffa392107dc0a90b4cd1f02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d865adcf685a348634192f93895e4b0534ca3b52ffa392107dc0a90b4cd1f02", kill_on_drop: false }` [INFO] [stdout] 1d865adcf685a348634192f93895e4b0534ca3b52ffa392107dc0a90b4cd1f02