[INFO] cloning repository https://github.com/cannero/monkey_interpreter_compiler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cannero/monkey_interpreter_compiler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcannero%2Fmonkey_interpreter_compiler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcannero%2Fmonkey_interpreter_compiler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cdae8be83281df0607fbaa79ab73ce86f6066d4f [INFO] checking cannero/monkey_interpreter_compiler/cdae8be83281df0607fbaa79ab73ce86f6066d4f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcannero%2Fmonkey_interpreter_compiler" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cannero/monkey_interpreter_compiler on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cannero/monkey_interpreter_compiler [INFO] finished tweaking git repo https://github.com/cannero/monkey_interpreter_compiler [INFO] tweaked toml for git repo https://github.com/cannero/monkey_interpreter_compiler written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cannero/monkey_interpreter_compiler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b4334ceb03f92a8c251451bafa9fb053552439b46f409c6709de47b6398665cc [INFO] running `Command { std: "docker" "start" "-a" "b4334ceb03f92a8c251451bafa9fb053552439b46f409c6709de47b6398665cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b4334ceb03f92a8c251451bafa9fb053552439b46f409c6709de47b6398665cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4334ceb03f92a8c251451bafa9fb053552439b46f409c6709de47b6398665cc", kill_on_drop: false }` [INFO] [stdout] b4334ceb03f92a8c251451bafa9fb053552439b46f409c6709de47b6398665cc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 97d014c31b7dbe444acc22bc8ff97ddb9aca8cd523830f9b302225e3126e2f24 [INFO] running `Command { std: "docker" "start" "-a" "97d014c31b7dbe444acc22bc8ff97ddb9aca8cd523830f9b302225e3126e2f24", kill_on_drop: false }` [INFO] [stderr] Checking libinterpreter v0.1.0 (/opt/rustwide/workdir/libinterpreter) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/evaluator.rs:135:15 [INFO] [stdout] | [INFO] [stdout] 134 | fn eval_infix_expression(&self, infix: &Infix, left: Object, right: Object) -> Object { [INFO] [stdout] | ------------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | match (left, right) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/evaluator/object.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn build_type_mismatch(infix: &Infix, left: Object, right: Object) -> Object { [INFO] [stdout] | ------------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Error(TypeMismatch(Box::new(left), infix.clone(), Box::new(right))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/evaluator/object.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn build_prefix_mismatch(right: Object) -> Object { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Error(PrefixMismatch(Box::new(right))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/parser.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 92 | let expression = self.parse_expression(Precedence::Lowest)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Ok(Statement::Let(Ident(identifier), expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/parser.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 103 | let expression = self.parse_expression(Precedence::Lowest)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(Statement::Return(expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/parser.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 223 | let condition = Box::new(self.parse_expression(Precedence::Lowest)?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let consequence = self.parse_block_statement(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | [INFO] [stdout] 234 | let alternative = if self.peek_token == Token::Else { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | Ok(Expression::If { [INFO] [stdout] | ____________^ [INFO] [stdout] 245 | | condition, [INFO] [stdout] 246 | | consequence, [INFO] [stdout] 247 | | alternative, [INFO] [stdout] 248 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/parser.rs:264:12 [INFO] [stdout] | [INFO] [stdout] 262 | let body = self.parse_block_statement(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | [INFO] [stdout] 264 | Ok(Expression::Function { parameters, body }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/parser.rs:288:12 [INFO] [stdout] | [INFO] [stdout] 287 | fn parse_call_expression(&mut self, function: Expression) -> ExpressionResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | Ok(Expression::Call { [INFO] [stdout] | ____________^ [INFO] [stdout] 289 | | function: Box::new(function), [INFO] [stdout] 290 | | arguments: self.parse_comma_separated(&Self::parse_call_argument), [INFO] [stdout] 291 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libinterpreter` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/evaluator.rs:135:15 [INFO] [stdout] | [INFO] [stdout] 134 | fn eval_infix_expression(&self, infix: &Infix, left: Object, right: Object) -> Object { [INFO] [stdout] | ------------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | match (left, right) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/evaluator/object.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn build_type_mismatch(infix: &Infix, left: Object, right: Object) -> Object { [INFO] [stdout] | ------------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Error(TypeMismatch(Box::new(left), infix.clone(), Box::new(right))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/evaluator/object.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn build_prefix_mismatch(right: Object) -> Object { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Error(PrefixMismatch(Box::new(right))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/parser.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 92 | let expression = self.parse_expression(Precedence::Lowest)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Ok(Statement::Let(Ident(identifier), expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/parser.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 103 | let expression = self.parse_expression(Precedence::Lowest)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(Statement::Return(expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/parser.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 223 | let condition = Box::new(self.parse_expression(Precedence::Lowest)?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let consequence = self.parse_block_statement(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | [INFO] [stdout] 234 | let alternative = if self.peek_token == Token::Else { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | Ok(Expression::If { [INFO] [stdout] | ____________^ [INFO] [stdout] 245 | | condition, [INFO] [stdout] 246 | | consequence, [INFO] [stdout] 247 | | alternative, [INFO] [stdout] 248 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/parser.rs:264:12 [INFO] [stdout] | [INFO] [stdout] 262 | let body = self.parse_block_statement(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | [INFO] [stdout] 264 | Ok(Expression::Function { parameters, body }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libinterpreter/src/parser.rs:288:12 [INFO] [stdout] | [INFO] [stdout] 287 | fn parse_call_expression(&mut self, function: Expression) -> ExpressionResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | Ok(Expression::Call { [INFO] [stdout] | ____________^ [INFO] [stdout] 289 | | function: Box::new(function), [INFO] [stdout] 290 | | arguments: self.parse_comma_separated(&Self::parse_call_argument), [INFO] [stdout] 291 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> libinterpreter/src/parser.rs:544:45 [INFO] [stdout] | [INFO] [stdout] 544 | assert!(parser.errors().len() == 2, parser.errors().join(";")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 544 | assert!(parser.errors().len() == 2, "{}", parser.errors().join(";")); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libinterpreter` (lib test) due to 9 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "97d014c31b7dbe444acc22bc8ff97ddb9aca8cd523830f9b302225e3126e2f24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97d014c31b7dbe444acc22bc8ff97ddb9aca8cd523830f9b302225e3126e2f24", kill_on_drop: false }` [INFO] [stdout] 97d014c31b7dbe444acc22bc8ff97ddb9aca8cd523830f9b302225e3126e2f24