[INFO] cloning repository https://github.com/campbellcole/computercraft-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/campbellcole/computercraft-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcampbellcole%2Fcomputercraft-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcampbellcole%2Fcomputercraft-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c14721543c14c8dbdc2790a92c06ee371683c700 [INFO] checking campbellcole/computercraft-rs/c14721543c14c8dbdc2790a92c06ee371683c700 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcampbellcole%2Fcomputercraft-rs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/campbellcole/computercraft-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/campbellcole/computercraft-rs [INFO] finished tweaking git repo https://github.com/campbellcole/computercraft-rs [INFO] tweaked toml for git repo https://github.com/campbellcole/computercraft-rs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/campbellcole/computercraft-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6ac8c8407fd556a0226d78f0c42bb8da5f44b3ee9917a7586cfba02dfc8ef8b9 [INFO] running `Command { std: "docker" "start" "-a" "6ac8c8407fd556a0226d78f0c42bb8da5f44b3ee9917a7586cfba02dfc8ef8b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6ac8c8407fd556a0226d78f0c42bb8da5f44b3ee9917a7586cfba02dfc8ef8b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ac8c8407fd556a0226d78f0c42bb8da5f44b3ee9917a7586cfba02dfc8ef8b9", kill_on_drop: false }` [INFO] [stdout] 6ac8c8407fd556a0226d78f0c42bb8da5f44b3ee9917a7586cfba02dfc8ef8b9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a0049aa9ea829e440aed0cd9828e8e07ee315b5bb60fa0c8ff494a298f4a2b89 [INFO] running `Command { std: "docker" "start" "-a" "a0049aa9ea829e440aed0cd9828e8e07ee315b5bb60fa0c8ff494a298f4a2b89", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling serde v1.0.185 [INFO] [stderr] Checking pin-project-lite v0.2.12 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling openssl v0.10.56 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Compiling thiserror v1.0.47 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Compiling async-trait v0.1.73 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking data-encoding v2.4.0 [INFO] [stderr] Compiling erased-serde v0.3.29 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking socket2 v0.5.3 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling openssl-sys v0.9.91 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha1 v0.10.5 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.9.3 [INFO] [stderr] Compiling serde_derive v1.0.185 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.47 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Checking tungstenite v0.20.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-tungstenite v0.20.0 [INFO] [stderr] Checking serde_bytes v0.11.12 [INFO] [stderr] Checking serde_path_to_error v0.1.14 [INFO] [stderr] Checking uuid v1.4.1 [INFO] [stderr] Checking fastnbt v2.4.4 [INFO] [stderr] Checking computercraft v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `error::Error` [INFO] [stdout] --> src/socket.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::{computer::Computer, error::Error}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn listen_on(addr: impl ToSocketAddrs + Send + 'static) -> Self { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Self { [INFO] [stdout] 43 | inner: Arc::new(Mutex::new(ServerInner::spawn_new(addr))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:113:24 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn spawn_new(addr: impl ToSocketAddrs + Send + 'static) -> Self { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let (tx, rx) = unbounded_channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let handle = tokio::spawn(socket::socket_thread(addr, tx)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | computers: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wrappers/lua_compat.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 46 | d: D, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | ) -> Result, D::Error> { [INFO] [stdout] 48 | Ok(EmptyVecOrEmptyObject::deserialize(d)?.into_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `computercraft` (lib) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "a0049aa9ea829e440aed0cd9828e8e07ee315b5bb60fa0c8ff494a298f4a2b89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0049aa9ea829e440aed0cd9828e8e07ee315b5bb60fa0c8ff494a298f4a2b89", kill_on_drop: false }` [INFO] [stdout] a0049aa9ea829e440aed0cd9828e8e07ee315b5bb60fa0c8ff494a298f4a2b89