[INFO] cloning repository https://github.com/cameron-williams/ezr-photo-viewer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cameron-williams/ezr-photo-viewer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcameron-williams%2Fezr-photo-viewer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcameron-williams%2Fezr-photo-viewer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 338876c5789b7352b83bf1d986abae7a2a3dd8de [INFO] checking cameron-williams/ezr-photo-viewer/338876c5789b7352b83bf1d986abae7a2a3dd8de against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcameron-williams%2Fezr-photo-viewer" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cameron-williams/ezr-photo-viewer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cameron-williams/ezr-photo-viewer [INFO] finished tweaking git repo https://github.com/cameron-williams/ezr-photo-viewer [INFO] tweaked toml for git repo https://github.com/cameron-williams/ezr-photo-viewer written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cameron-williams/ezr-photo-viewer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3278cfd2dac03112c0fc779b5de0e94999630c1ed760c35e4d38ac8ddea42348 [INFO] running `Command { std: "docker" "start" "-a" "3278cfd2dac03112c0fc779b5de0e94999630c1ed760c35e4d38ac8ddea42348", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3278cfd2dac03112c0fc779b5de0e94999630c1ed760c35e4d38ac8ddea42348", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3278cfd2dac03112c0fc779b5de0e94999630c1ed760c35e4d38ac8ddea42348", kill_on_drop: false }` [INFO] [stdout] 3278cfd2dac03112c0fc779b5de0e94999630c1ed760c35e4d38ac8ddea42348 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f662b0c72536d515e0105f969262c181d75991daa90b755cab965c95e2e2593 [INFO] running `Command { std: "docker" "start" "-a" "1f662b0c72536d515e0105f969262c181d75991daa90b755cab965c95e2e2593", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.16 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling bitflags v1.2.0 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.11 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling proc-macro-nested v0.1.3 [INFO] [stderr] Compiling gio v0.7.0 [INFO] [stderr] Checking futures-sink v0.3.1 [INFO] [stderr] Compiling cairo-rs v0.7.1 [INFO] [stderr] Compiling gdk-pixbuf v0.7.0 [INFO] [stderr] Compiling pango v0.7.0 [INFO] [stderr] Checking fragile v0.3.0 [INFO] [stderr] Checking futures-core v0.3.1 [INFO] [stderr] Checking futures-io v0.3.1 [INFO] [stderr] Checking futures-task v0.3.1 [INFO] [stderr] Compiling atk v0.7.0 [INFO] [stderr] Compiling gdk v0.11.0 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling gtk v0.7.0 [INFO] [stderr] Checking futures-channel v0.3.1 [INFO] [stderr] Compiling glib-sys v0.9.0 [INFO] [stderr] Compiling gobject-sys v0.9.0 [INFO] [stderr] Compiling gio-sys v0.9.0 [INFO] [stderr] Compiling cairo-sys-rs v0.9.0 [INFO] [stderr] Compiling pango-sys v0.9.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.9.0 [INFO] [stderr] Compiling atk-sys v0.9.0 [INFO] [stderr] Compiling gdk-sys v0.9.0 [INFO] [stderr] Compiling gtk-sys v0.9.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking glib v0.8.2 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling futures-macro v0.3.1 [INFO] [stderr] Checking futures-util v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.1 [INFO] [stderr] Checking futures v0.3.1 [INFO] [stderr] Checking ezr-photo-viewer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `img` is never read [INFO] [stdout] --> src/main.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 60 | struct LoadedImage { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 61 | img: Image, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LoadedImage` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `img` is never read [INFO] [stdout] --> src/main.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 60 | struct LoadedImage { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 61 | img: Image, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LoadedImage` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:52:24 [INFO] [stdout] | [INFO] [stdout] 49 | let ea = EzrPhotoViewerApplication { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | AppWindow::new(Arc::new(ea)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:52:24 [INFO] [stdout] | [INFO] [stdout] 49 | let ea = EzrPhotoViewerApplication { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | AppWindow::new(Arc::new(ea)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:103:14 [INFO] [stdout] | [INFO] [stdout] 71 | let pbuf = match Pixbuf::new_from_file_at_scale(&path, -1, height, true) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Ok(p) => p, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let img = Image::new_from_pixbuf(Some(&pbuf)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let ebox = EventBox::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Some(LoadedImage { [INFO] [stdout] | ______________^ [INFO] [stdout] 104 | | img, [INFO] [stdout] 105 | | pbuf, [INFO] [stdout] 106 | | path, [INFO] [stdout] ... | [INFO] [stdout] 109 | | eventbox: ebox, [INFO] [stdout] 110 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:103:14 [INFO] [stdout] | [INFO] [stdout] 71 | let pbuf = match Pixbuf::new_from_file_at_scale(&path, -1, height, true) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Ok(p) => p, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let img = Image::new_from_pixbuf(Some(&pbuf)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let ebox = EventBox::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Some(LoadedImage { [INFO] [stdout] | ______________^ [INFO] [stdout] 104 | | img, [INFO] [stdout] 105 | | pbuf, [INFO] [stdout] 106 | | path, [INFO] [stdout] ... | [INFO] [stdout] 109 | | eventbox: ebox, [INFO] [stdout] 110 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:219:18 [INFO] [stdout] | [INFO] [stdout] 186 | fn init_main_window(main_app: Arc) -> Arc { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | // Highest level window widget. Holds the ScrollableWindow. [INFO] [stdout] 188 | let window = gtk::Window::new(gtk::WindowType::Toplevel); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let hb = gtk::HeaderBar::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let dir_chooser = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | let email_btn = gtk::Button::new_with_label("Email Selected Photos"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | let scrolled_window = gtk::ScrolledWindow::new(NONE_ADJUSTMENT, NONE_ADJUSTMENT); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let layout = gtk::Layout::new(NONE_ADJUSTMENT, NONE_ADJUSTMENT); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 220 | | window: window, [INFO] [stdout] 221 | | container: layout, [INFO] [stdout] 222 | | dimensions, [INFO] [stdout] ... | [INFO] [stdout] 225 | | application: main_app, [INFO] [stdout] 226 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:219:18 [INFO] [stdout] | [INFO] [stdout] 186 | fn init_main_window(main_app: Arc) -> Arc { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | // Highest level window widget. Holds the ScrollableWindow. [INFO] [stdout] 188 | let window = gtk::Window::new(gtk::WindowType::Toplevel); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let hb = gtk::HeaderBar::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let dir_chooser = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | let email_btn = gtk::Button::new_with_label("Email Selected Photos"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | let scrolled_window = gtk::ScrolledWindow::new(NONE_ADJUSTMENT, NONE_ADJUSTMENT); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let layout = gtk::Layout::new(NONE_ADJUSTMENT, NONE_ADJUSTMENT); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 220 | | window: window, [INFO] [stdout] 221 | | container: layout, [INFO] [stdout] 222 | | dimensions, [INFO] [stdout] ... | [INFO] [stdout] 225 | | application: main_app, [INFO] [stdout] 226 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:323:15 [INFO] [stdout] | [INFO] [stdout] 307 | fn email_selected_images(app_window: Arc) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | match std::process::Command::new("thunderbird") [INFO] [stdout] | _______________^ [INFO] [stdout] 324 | | .arg("--compose") [INFO] [stdout] 325 | | .arg(format!("attachment='{}'", attachment_str)) [INFO] [stdout] 326 | | .spawn() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:314:36 [INFO] [stdout] | [INFO] [stdout] 314 | .filter_map(|i| match *i.selected.borrow() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:323:15 [INFO] [stdout] | [INFO] [stdout] 307 | fn email_selected_images(app_window: Arc) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | match std::process::Command::new("thunderbird") [INFO] [stdout] | _______________^ [INFO] [stdout] 324 | | .arg("--compose") [INFO] [stdout] 325 | | .arg(format!("attachment='{}'", attachment_str)) [INFO] [stdout] 326 | | .spawn() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:314:36 [INFO] [stdout] | [INFO] [stdout] 314 | .filter_map(|i| match *i.selected.borrow() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:366:17 [INFO] [stdout] | [INFO] [stdout] 366 | ¤t_row_items.clear(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 366 | let _ = ¤t_row_items.clear(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:369:13 [INFO] [stdout] | [INFO] [stdout] 369 | ¤t_row_items.push(img); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 369 | let _ = ¤t_row_items.push(img); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:366:17 [INFO] [stdout] | [INFO] [stdout] 366 | ¤t_row_items.clear(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 366 | let _ = ¤t_row_items.clear(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:369:13 [INFO] [stdout] | [INFO] [stdout] 369 | ¤t_row_items.push(img); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 369 | let _ = ¤t_row_items.push(img); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:437:5 [INFO] [stdout] | [INFO] [stdout] 436 | fn load_images_for_path>(path: P) -> Vec { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 437 | / read_dir(path) [INFO] [stdout] 438 | | .unwrap() [INFO] [stdout] 439 | | .filter_map(|e| { [INFO] [stdout] 440 | | match e { [INFO] [stdout] ... | [INFO] [stdout] 446 | | } [INFO] [stdout] 447 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:437:5 [INFO] [stdout] | [INFO] [stdout] 436 | fn load_images_for_path>(path: P) -> Vec { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 437 | / read_dir(path) [INFO] [stdout] 438 | | .unwrap() [INFO] [stdout] 439 | | .filter_map(|e| { [INFO] [stdout] 440 | | match e { [INFO] [stdout] ... | [INFO] [stdout] 446 | | } [INFO] [stdout] 447 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ezr-photo-viewer` (bin "ezr-photo-viewer") due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ezr-photo-viewer` (bin "ezr-photo-viewer" test) due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1f662b0c72536d515e0105f969262c181d75991daa90b755cab965c95e2e2593", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f662b0c72536d515e0105f969262c181d75991daa90b755cab965c95e2e2593", kill_on_drop: false }` [INFO] [stdout] 1f662b0c72536d515e0105f969262c181d75991daa90b755cab965c95e2e2593