[INFO] cloning repository https://github.com/callummance/primrose [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/callummance/primrose" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcallummance%2Fprimrose", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcallummance%2Fprimrose'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f75cc41f18c19094a53f8dc9c586b6dc87862ff5 [INFO] checking callummance/primrose/f75cc41f18c19094a53f8dc9c586b6dc87862ff5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcallummance%2Fprimrose" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/callummance/primrose on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/callummance/primrose [INFO] finished tweaking git repo https://github.com/callummance/primrose [INFO] tweaked toml for git repo https://github.com/callummance/primrose written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/callummance/primrose already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 78190c8aec565da1fbf549261e2a7fa78e152d0c240ee5f69855fa92ad055cbf [INFO] running `Command { std: "docker" "start" "-a" "78190c8aec565da1fbf549261e2a7fa78e152d0c240ee5f69855fa92ad055cbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "78190c8aec565da1fbf549261e2a7fa78e152d0c240ee5f69855fa92ad055cbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78190c8aec565da1fbf549261e2a7fa78e152d0c240ee5f69855fa92ad055cbf", kill_on_drop: false }` [INFO] [stdout] 78190c8aec565da1fbf549261e2a7fa78e152d0c240ee5f69855fa92ad055cbf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3fd0b46f34436511a4ba58b0b39e94926e9b98e7918385147e76df31a447fb77 [INFO] running `Command { std: "docker" "start" "-a" "3fd0b46f34436511a4ba58b0b39e94926e9b98e7918385147e76df31a447fb77", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.123 [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling rusb v0.9.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Compiling libusb1-sys v0.6.1 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling strum_macros v0.24.0 [INFO] [stderr] Checking strum v0.24.0 [INFO] [stderr] Checking primrose v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn init(stream_base_path: String, mut device: ItgioDevice) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | device.open()?; [INFO] [stdout] 33 | let device = Arc::new(Mutex::new(device)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let should_close = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let close_notifier = Parker::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | [INFO] [stdout] 40 | Ok(ItgioTranslator { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | device, [INFO] [stdout] 42 | | should_close, [INFO] [stdout] 43 | | close_notifier, [INFO] [stdout] 44 | | reader_path, [INFO] [stdout] 45 | | writer_path, [INFO] [stdout] 46 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/itgio.rs:63:29 [INFO] [stdout] | [INFO] [stdout] 53 | .map(|libusb_dev| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | handle: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sextetstream.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 48 | let file = get_or_create_pipe(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | Ok(SextetStreamReader { reader }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sextetstream.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 66 | let writer = get_or_create_pipe(&path)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | [INFO] [stdout] 68 | Ok(SextetStreamWriter { writer }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn init(stream_base_path: String, mut device: ItgioDevice) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | device.open()?; [INFO] [stdout] 33 | let device = Arc::new(Mutex::new(device)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let should_close = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let close_notifier = Parker::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | [INFO] [stdout] 40 | Ok(ItgioTranslator { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | device, [INFO] [stdout] 42 | | should_close, [INFO] [stdout] 43 | | close_notifier, [INFO] [stdout] 44 | | reader_path, [INFO] [stdout] 45 | | writer_path, [INFO] [stdout] 46 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/itgio.rs:63:29 [INFO] [stdout] | [INFO] [stdout] 53 | .map(|libusb_dev| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | handle: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sextetstream.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 48 | let file = get_or_create_pipe(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | Ok(SextetStreamReader { reader }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sextetstream.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 66 | let writer = get_or_create_pipe(&path)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | [INFO] [stdout] 68 | Ok(SextetStreamWriter { writer }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `primrose` (bin "primrose" test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `primrose` (bin "primrose") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "3fd0b46f34436511a4ba58b0b39e94926e9b98e7918385147e76df31a447fb77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fd0b46f34436511a4ba58b0b39e94926e9b98e7918385147e76df31a447fb77", kill_on_drop: false }` [INFO] [stdout] 3fd0b46f34436511a4ba58b0b39e94926e9b98e7918385147e76df31a447fb77