[INFO] cloning repository https://github.com/caldwell/rt11fs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/caldwell/rt11fs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcaldwell%2Frt11fs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcaldwell%2Frt11fs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 90d28023828740f1a23b0e2d6ba2ed3278bb4f49 [INFO] checking caldwell/rt11fs/90d28023828740f1a23b0e2d6ba2ed3278bb4f49 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcaldwell%2Frt11fs" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/caldwell/rt11fs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/caldwell/rt11fs [INFO] finished tweaking git repo https://github.com/caldwell/rt11fs [INFO] tweaked toml for git repo https://github.com/caldwell/rt11fs written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/caldwell/rt11fs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9fbcafb474d248a0057fef5b13d082e37c3c25076f6d9721c989a8f5537e48ca [INFO] running `Command { std: "docker" "start" "-a" "9fbcafb474d248a0057fef5b13d082e37c3c25076f6d9721c989a8f5537e48ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9fbcafb474d248a0057fef5b13d082e37c3c25076f6d9721c989a8f5537e48ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9fbcafb474d248a0057fef5b13d082e37c3c25076f6d9721c989a8f5537e48ca", kill_on_drop: false }` [INFO] [stdout] 9fbcafb474d248a0057fef5b13d082e37c3c25076f6d9721c989a8f5537e48ca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 06de43247ffa4e3cc7aeb101c2ecac37213f8e211828d265694708bec7f9dc80 [INFO] running `Command { std: "docker" "start" "-a" "06de43247ffa4e3cc7aeb101c2ecac37213f8e211828d265694708bec7f9dc80", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde v1.0.192 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling neon-build v0.10.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking const_for v0.1.3 [INFO] [stderr] Checking radix50 v0.1.0 [INFO] [stderr] Checking whoami v1.4.1 [INFO] [stderr] Checking pretty-hex v0.3.0 [INFO] [stderr] Checking join-string v0.3.0 [INFO] [stderr] Checking bytebuffer v2.2.0 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling neon v0.10.1 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking neon-runtime v0.10.1 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling syn-mid v0.5.4 [INFO] [stderr] Compiling neon-macros v0.10.1 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling serde_derive v1.0.192 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking docopt v1.1.1 [INFO] [stderr] Checking pdpfs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fs/rt11.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(image: B) -> anyhow::Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(RT11FS { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | image, [INFO] [stdout] 34 | | home, [INFO] [stdout] 35 | | dir, [INFO] [stdout] 36 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fs/rt11.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 165 | let Some((segment, entry)) = self.find_empty_space(blocks) else { return Err(anyhow!("No space available in image")) }; [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | Ok(RT11FileWriter{ [INFO] [stdout] | ____________^ [INFO] [stdout] 185 | | image: &mut self.image, [INFO] [stdout] 186 | | direntry: &self.dir[segment].entries[entry], [INFO] [stdout] 187 | | residue: vec![], [INFO] [stdout] 188 | | pos: 0, [INFO] [stdout] 189 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fs/xxdp.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(image: B) -> anyhow::Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let (mfd, ufd, ufd_block_list, bitmap, bitmap_block_list) = Self::try_new(&image)?; [INFO] [stdout] 47 | Ok(XxdpFs { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | image, [INFO] [stdout] 49 | | mfd, [INFO] [stdout] 50 | | ufd, [INFO] [stdout] ... | [INFO] [stdout] 53 | | bitmap_block_list, [INFO] [stdout] 54 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ops.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | Ok(match (&image[0..3], image.len()) { [INFO] [stdout] | ________^ [INFO] [stdout] 78 | | (magic, _) if magic == "IMD".as_bytes() => { [INFO] [stdout] 79 | | let imd = IMD::from_bytes(&image).with_context(|| "Malformed IMD file")?; [INFO] [stdout] 80 | | match imd.total_bytes() { [INFO] [stdout] ... | [INFO] [stdout] 93 | | (magic, len) => return Err(anyhow!("Unknown image type (magic number: {:x?}, length: {})", magic, len)), [INFO] [stdout] 94 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ops.rs:243:8 [INFO] [stdout] | [INFO] [stdout] 238 | let dev = match imtype { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Ok(match fstype { [INFO] [stdout] | ________^ [INFO] [stdout] 244 | | FileSystemType::RT11 => Box::new(RT11FS::mkfs(dev)?) as Box>>, [INFO] [stdout] 245 | | FileSystemType::XXDP => Box::new(XxdpFs::mkfs(dev)?) as Box>>, [INFO] [stdout] 246 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pdpfs` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fs/rt11.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(image: B) -> anyhow::Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(RT11FS { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | image, [INFO] [stdout] 34 | | home, [INFO] [stdout] 35 | | dir, [INFO] [stdout] 36 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fs/rt11.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 165 | let Some((segment, entry)) = self.find_empty_space(blocks) else { return Err(anyhow!("No space available in image")) }; [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | Ok(RT11FileWriter{ [INFO] [stdout] | ____________^ [INFO] [stdout] 185 | | image: &mut self.image, [INFO] [stdout] 186 | | direntry: &self.dir[segment].entries[entry], [INFO] [stdout] 187 | | residue: vec![], [INFO] [stdout] 188 | | pos: 0, [INFO] [stdout] 189 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fs/xxdp.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(image: B) -> anyhow::Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let (mfd, ufd, ufd_block_list, bitmap, bitmap_block_list) = Self::try_new(&image)?; [INFO] [stdout] 47 | Ok(XxdpFs { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | image, [INFO] [stdout] 49 | | mfd, [INFO] [stdout] 50 | | ufd, [INFO] [stdout] ... | [INFO] [stdout] 53 | | bitmap_block_list, [INFO] [stdout] 54 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ops.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | Ok(match (&image[0..3], image.len()) { [INFO] [stdout] | ________^ [INFO] [stdout] 78 | | (magic, _) if magic == "IMD".as_bytes() => { [INFO] [stdout] 79 | | let imd = IMD::from_bytes(&image).with_context(|| "Malformed IMD file")?; [INFO] [stdout] 80 | | match imd.total_bytes() { [INFO] [stdout] ... | [INFO] [stdout] 93 | | (magic, len) => return Err(anyhow!("Unknown image type (magic number: {:x?}, length: {})", magic, len)), [INFO] [stdout] 94 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ops.rs:243:8 [INFO] [stdout] | [INFO] [stdout] 238 | let dev = match imtype { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Ok(match fstype { [INFO] [stdout] | ________^ [INFO] [stdout] 244 | | FileSystemType::RT11 => Box::new(RT11FS::mkfs(dev)?) as Box>>, [INFO] [stdout] 245 | | FileSystemType::XXDP => Box::new(XxdpFs::mkfs(dev)?) as Box>>, [INFO] [stdout] 246 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pdpfs` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "06de43247ffa4e3cc7aeb101c2ecac37213f8e211828d265694708bec7f9dc80", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06de43247ffa4e3cc7aeb101c2ecac37213f8e211828d265694708bec7f9dc80", kill_on_drop: false }` [INFO] [stdout] 06de43247ffa4e3cc7aeb101c2ecac37213f8e211828d265694708bec7f9dc80