[INFO] cloning repository https://github.com/caibirdme/kvstore [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/caibirdme/kvstore" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcaibirdme%2Fkvstore", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcaibirdme%2Fkvstore'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f365ad42529a930278b581b9e7db1e76efc9ca7c [INFO] checking caibirdme/kvstore/f365ad42529a930278b581b9e7db1e76efc9ca7c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcaibirdme%2Fkvstore" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/caibirdme/kvstore on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/caibirdme/kvstore [INFO] finished tweaking git repo https://github.com/caibirdme/kvstore [INFO] tweaked toml for git repo https://github.com/caibirdme/kvstore written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/caibirdme/kvstore already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8af2e45b1bff2c1a58ea2c858211a1c0535612ed45491431117c8c836b1928fd [INFO] running `Command { std: "docker" "start" "-a" "8af2e45b1bff2c1a58ea2c858211a1c0535612ed45491431117c8c836b1928fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8af2e45b1bff2c1a58ea2c858211a1c0535612ed45491431117c8c836b1928fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8af2e45b1bff2c1a58ea2c858211a1c0535612ed45491431117c8c836b1928fd", kill_on_drop: false }` [INFO] [stdout] 8af2e45b1bff2c1a58ea2c858211a1c0535612ed45491431117c8c836b1928fd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 919d29e733c481908e413e39749b598746d0a8c76e3bc301cb53316c0b5f7404 [INFO] running `Command { std: "docker" "start" "-a" "919d29e733c481908e413e39749b598746d0a8c76e3bc301cb53316c0b5f7404", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling serde v1.0.105 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling failure_derive v0.1.7 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Compiling escargot v0.4.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Compiling backtrace-sys v0.1.35 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking float-cmp v0.6.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking backtrace v0.3.46 [INFO] [stderr] Checking regex v1.3.6 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking predicates v1.0.4 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling serde_derive v1.0.105 [INFO] [stderr] Checking failure v0.1.7 [INFO] [stderr] Checking serde_json v1.0.51 [INFO] [stderr] Checking kvs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | #[macro_use] extern crate failure; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | let mut writer = Self::new_log_file(last_id, file_path.as_path(), &mut readers)?; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | let mut writer = Self::new_log_file(fid, path.as_path(), &mut readers)?; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | let mut t = r.take(len); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | let mut writer = Self::new_log_file(2, self.file_path.as_path(), &mut self.readers)?; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | let mut fd = OpenOptions::new() [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:225:13 [INFO] [stdout] | [INFO] [stdout] 225 | let mut writer = BufWriter::new(fd); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:226:13 [INFO] [stdout] | [INFO] [stdout] 226 | let mut r = OpenOptions::new().read(true).open(p)?; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 33 | fn new(inner: File) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Self { [INFO] [stdout] 35 | inner: std::io::BufWriter::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:28 [INFO] [stdout] | [INFO] [stdout] 66 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn open(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let mut readers = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let mut writer = Self::new_log_file(last_id, file_path.as_path(), &mut readers)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Ok(Self{readers, writer, index, fid: last_id, file_path, rubbish}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 102 | let mut reader = BufReader::new(OpenOptions::new().read(true).open(f_path)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let mut readers = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let mut writer = Self::new_log_file(fid, path.as_path(), &mut readers)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Ok(Self{readers, writer, file_path: path, fid, index, rubbish}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:234:20 [INFO] [stdout] | [INFO] [stdout] 233 | .flat_map(|dir| -> Result<_> { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | Ok(dir?.path()) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib) due to 6 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "919d29e733c481908e413e39749b598746d0a8c76e3bc301cb53316c0b5f7404", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "919d29e733c481908e413e39749b598746d0a8c76e3bc301cb53316c0b5f7404", kill_on_drop: false }` [INFO] [stdout] 919d29e733c481908e413e39749b598746d0a8c76e3bc301cb53316c0b5f7404