[INFO] cloning repository https://github.com/c-gamble/rs-cpp-compiler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/c-gamble/rs-cpp-compiler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fc-gamble%2Frs-cpp-compiler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fc-gamble%2Frs-cpp-compiler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0d49d7d5d3482c37f8b8c177045f944a53af8d0a [INFO] checking c-gamble/rs-cpp-compiler/0d49d7d5d3482c37f8b8c177045f944a53af8d0a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fc-gamble%2Frs-cpp-compiler" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/c-gamble/rs-cpp-compiler on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/c-gamble/rs-cpp-compiler [INFO] finished tweaking git repo https://github.com/c-gamble/rs-cpp-compiler [INFO] tweaked toml for git repo https://github.com/c-gamble/rs-cpp-compiler written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/c-gamble/rs-cpp-compiler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2d4aab6ecb65df3ce39a6111e25b9bdf6fe5ccc73a2d4c64753ca9cf8e4fceb [INFO] running `Command { std: "docker" "start" "-a" "a2d4aab6ecb65df3ce39a6111e25b9bdf6fe5ccc73a2d4c64753ca9cf8e4fceb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2d4aab6ecb65df3ce39a6111e25b9bdf6fe5ccc73a2d4c64753ca9cf8e4fceb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2d4aab6ecb65df3ce39a6111e25b9bdf6fe5ccc73a2d4c64753ca9cf8e4fceb", kill_on_drop: false }` [INFO] [stdout] a2d4aab6ecb65df3ce39a6111e25b9bdf6fe5ccc73a2d4c64753ca9cf8e4fceb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e904e5f1b10439bc327e211203f173247a9a3196ea026c52b01f5ee7591c7580 [INFO] running `Command { std: "docker" "start" "-a" "e904e5f1b10439bc327e211203f173247a9a3196ea026c52b01f5ee7591c7580", kill_on_drop: false }` [INFO] [stderr] Checking rust-compiler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fmt::Binary` [INFO] [stdout] --> src/ast/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Binary; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `iter::Peekable` and `str::Chars` [INFO] [stdout] --> src/ast/lexer.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{iter::Peekable, str::Chars}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Lexer` [INFO] [stdout] --> src/ast/parser.rs:2:25 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::ast::lexer::{Lexer, Token, TokenKind}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Binary` [INFO] [stdout] --> src/ast/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Binary; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `iter::Peekable` and `str::Chars` [INFO] [stdout] --> src/ast/lexer.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{iter::Peekable, str::Chars}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Lexer` [INFO] [stdout] --> src/ast/parser.rs:2:25 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::ast::lexer::{Lexer, Token, TokenKind}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `kind` is never read [INFO] [stdout] --> src/ast/lexer.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | let mut kind = TokenKind::Bad; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `token` is never read [INFO] [stdout] --> src/ast/mod.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 155 | pub struct ASTBinaryOperator { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 156 | kind: ASTBinaryOperatorKind, [INFO] [stdout] 157 | token: Token, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `length` is never used [INFO] [stdout] --> src/ast/lexer.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 23 | impl TextSpan { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn length(&self) -> usize { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:138:27 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn expression(expr: ASTExpression) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | ASTStatement::new(ASTStatementKind::Expression(expr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:202:28 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn binary(operator: ASTBinaryOperator, left: ASTExpression, right: ASTExpression) -> Self { [INFO] [stdout] | ------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | ASTExpression::new(ASTExpressionKind::Binary(ASTBinaryExpression{ left: Box::new(left), operator, right: Box::new(right) })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:206:28 [INFO] [stdout] | [INFO] [stdout] 205 | pub fn parenthesized(expression: ASTExpression) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | ASTExpression::new(ASTExpressionKind::Parenthesized(ASTParenthesizedExpression{ expression: Box::new(expression) })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-compiler` (bin "rust-compiler" test) due to 4 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: value assigned to `kind` is never read [INFO] [stdout] --> src/ast/lexer.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | let mut kind = TokenKind::Bad; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `token` is never read [INFO] [stdout] --> src/ast/mod.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 155 | pub struct ASTBinaryOperator { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 156 | kind: ASTBinaryOperatorKind, [INFO] [stdout] 157 | token: Token, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `length` is never used [INFO] [stdout] --> src/ast/lexer.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 23 | impl TextSpan { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn length(&self) -> usize { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:138:27 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn expression(expr: ASTExpression) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | ASTStatement::new(ASTStatementKind::Expression(expr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:202:28 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn binary(operator: ASTBinaryOperator, left: ASTExpression, right: ASTExpression) -> Self { [INFO] [stdout] | ------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | ASTExpression::new(ASTExpressionKind::Binary(ASTBinaryExpression{ left: Box::new(left), operator, right: Box::new(right) })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:206:28 [INFO] [stdout] | [INFO] [stdout] 205 | pub fn parenthesized(expression: ASTExpression) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | ASTExpression::new(ASTExpressionKind::Parenthesized(ASTParenthesizedExpression{ expression: Box::new(expression) })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-compiler` (bin "rust-compiler") due to 4 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e904e5f1b10439bc327e211203f173247a9a3196ea026c52b01f5ee7591c7580", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e904e5f1b10439bc327e211203f173247a9a3196ea026c52b01f5ee7591c7580", kill_on_drop: false }` [INFO] [stdout] e904e5f1b10439bc327e211203f173247a9a3196ea026c52b01f5ee7591c7580